Re: Review Request 74071: ATLAS-4649 : Upgrade Spring Framework to 5.3.21
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74071/ --- (Updated Aug. 2, 2022, 5:02 a.m.) Review request for atlas, Jayendra Parab and Pinal Shah. Bugs: ATLAS-4649 https://issues.apache.org/jira/browse/ATLAS-4649 Repository: atlas Description --- current version for Spring Framework is 5.3.20 Diffs - pom.xml 1e32e45f3 Diff: https://reviews.apache.org/r/74071/diff/1/ Testing (updated) --- mvn clean -DskipTests package -Pdist,embedded-hbase-solr mvn clean install -Drat.skip atlas server running successfully https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1158/consoleFull Thanks, chaitali
Re: Review Request 74072: ATLAS-4648 : Upgrade Netty version to 4.1.78.Final
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74072/ --- (Updated Aug. 2, 2022, 4:59 a.m.) Review request for atlas, Jayendra Parab and Pinal Shah. Bugs: ATLAS-4648 https://issues.apache.org/jira/browse/ATLAS-4648 Repository: atlas Description --- current version for Netty to 4.1.77.Final Diffs - pom.xml 1e32e45f3 Diff: https://reviews.apache.org/r/74072/diff/1/ Testing (updated) --- mvn clean -DskipTests package -Pdist,embedded-hbase-solr mvn clean install -Drat.skip atlas server running successfully https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1169/consoleFull Thanks, chaitali
Re: Contribute
Patrik, Thank you for your interest in contributing to Apache Atlas. You now have contributor access in Apache Atlas. Welcome to Apache Atlas. Thanks, Madhan Apache Atlas PMC On 7/28/22, 11:17 PM, "Patrik Marton" wrote: Hi Atlas Team, I am interested in contributing to Apache Atlas project, please add me as a contributor. My Jira id is pmarton Thanks!
Review Request 74075: UI: Add classification button appears for deleted hive_columns in Schema Tab of hive_table entity details page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74075/ --- Review request for atlas and Prasad Pawar. Bugs: ATLAS-4600 https://issues.apache.org/jira/browse/ATLAS-4600 Repository: atlas Description --- If user navigate to a deleted hive_table entity's Schema tab, it is possible to get an 'add classification' button. Diffs - dashboardv2/public/js/views/schema/SchemaLayoutView.js ab776e9cf dashboardv3/public/js/views/schema/SchemaLayoutView.js 79ddc573b Diff: https://reviews.apache.org/r/74075/diff/1/ Testing --- Manually tested on local for the above mentioned scenario. Thanks, Farhan Khan
Re: Review Request 74065: ATLAS-4615 :- Not able to edit custom entity in Atlas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74065/
---
(Updated Aug. 1, 2022, 12:30 p.m.)
Review request for atlas, Jayendra Parab and Pinal Shah.
Bugs: ATLAS-4615
https://issues.apache.org/jira/browse/ATLAS-4615
Repository: atlas
Description
---
Problem Statement : Given a custom entity that defines an array attribute of
another custom type, any removed elements always appear in the array
Diffs
-
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
a8fe5a762
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/InverseReferenceUpdateSoftDeleteV2Test.java
afa1c5991
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/InverseReferenceUpdateV2Test.java
d01ea3043
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java
6a00c1764
Diff: https://reviews.apache.org/r/74065/diff/3/
Testing
---
Manual testing done as follows:
created a custom type "Tab"
created 4 entities of this type : tab1,tab2,tab3 and tab4
created another custom type "Alphatab" having an attribute "tabArray" of type
array
created entity ATEntity of type Alphatab with tabArray = {tab1, tab2}
//add an element and remove an element from array
updated ATEntity with tabArray = {tab1, tab3}
// add back removed element to array
updated ATEntity with tabArray = {tab1, tab2, tab3}
// delete an entity in the array by its guid
deleted tab2; size of array doesnt change yet (tab2 is soft deleted)
//removed 2 and added 1 element
updated ATEntity with tabArray = {tab3, tab4}
//remove one add 2 elements
updated ATEntity with tabArray = {tab1, tab2, tab3}
//elements returned by getById(guid) mwthod will return an array of only ACTIVE
edges (DELETEd edges will be ignored)
size of array = number of active edges
Note : Following test cases have been edited to accomodate the feature
change(set ignoreInactive=true as default)
1.org.apache.atlas.repository.store.graph.v2.InverseReferenceUpdateV2Test
2.org.apache.atlas.repository.store.graph.v2.InverseReferenceUpdateSoftDeleteV2Test
Thanks,
Sheetal Shah
