[jira] [Commented] (ATLAS-4610) ATLAS UI : Classification/ Term: Add parent name for classification & name

2022-08-26 Thread Rahul Kurup (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585321#comment-17585321
 ] 

Rahul Kurup commented on ATLAS-4610:


+1

> ATLAS UI : Classification/ Term: Add parent name for classification & name 
> ---
>
> Key: ATLAS-4610
> URL: https://issues.apache.org/jira/browse/ATLAS-4610
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4610-ATLAS-UI-Classification-Term-Add-parent-n.patch
>
>
> The classification and term assignment section should display their parents 
> if present, on the detail page.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ATLAS-4610) ATLAS UI : Classification/ Term: Add parent name for classification & name

2022-08-26 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4610:
---
Attachment: (was: 
0001-ATLAS-4610-ATLAS-UI-Classification-Term-Add-parent-n.patch)

> ATLAS UI : Classification/ Term: Add parent name for classification & name 
> ---
>
> Key: ATLAS-4610
> URL: https://issues.apache.org/jira/browse/ATLAS-4610
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4610-ATLAS-UI-Classification-Term-Add-parent-n.patch
>
>
> The classification and term assignment section should display their parents 
> if present, on the detail page.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ATLAS-4666) Intermittently, the audits for creation of hive_db registered are different than expected.

2022-08-26 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4666:
--

Assignee: Mandar Ambawane

> Intermittently, the audits for creation of hive_db registered are different 
> than expected.
> --
>
> Key: ATLAS-4666
> URL: https://issues.apache.org/jira/browse/ATLAS-4666
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Mandar Ambawane
>Priority: Major
>
> Sometimes, when I create a hive database and then check for the same in 
> Atlas, the audits tab shows unexpected audit entries: it shows two audit 
> entries both marked as 'Entity Updated' rather than showing a 'Entity 
> Created' audit entry anywhere.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ATLAS-4610) ATLAS UI : Classification/ Term: Add parent name for classification & name

2022-08-26 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4610:
---
Attachment: 0001-ATLAS-4610-ATLAS-UI-Classification-Term-Add-parent-n.patch

> ATLAS UI : Classification/ Term: Add parent name for classification & name 
> ---
>
> Key: ATLAS-4610
> URL: https://issues.apache.org/jira/browse/ATLAS-4610
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4610-ATLAS-UI-Classification-Term-Add-parent-n.patch
>
>
> The classification and term assignment section should display their parents 
> if present, on the detail page.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ATLAS-4667) Cannot create subclassification using subTypes field.

2022-08-26 Thread Rahul Kurup (Jira)
Rahul Kurup created ATLAS-4667:
--

 Summary: Cannot create subclassification using subTypes field.
 Key: ATLAS-4667
 URL: https://issues.apache.org/jira/browse/ATLAS-4667
 Project: Atlas
  Issue Type: Bug
Reporter: Rahul Kurup


If I create two classifications and then attempt to create parent-child 
relation between them, the following request, where the superType is specified, 
works:

 

{{{}}
{{    "classificationDefs": [}}
{{        {}}
{{            "category": "CLASSIFICATION",}}
{{            "guid": "39a8acf8-0d4c-427d-94f1-e677487a9423",}}
{{            "createdBy": "admin",}}
{{            "updatedBy": "admin",}}
{{            "createTime": 1661496389541,}}
{{            "updateTime": 1661496389541,}}
{{            "version": 1,}}
{{            "name": "TCLASS",}}
{{            "description": "TCLASSS",}}
{{            "typeVersion": "1.0",}}
{{            "attributeDefs": [],}}
{{            "superTypes": ["XCLASS1"],}}
{{            "entityTypes": [],}}
{{            "subTypes": []}}
{{        }}}
{{    ],}}
{{    "entityDefs": [],}}
{{    "enumDefs": [],}}
{{    "structDefs": []}}
{{}}}

 

But this request to create the sub-classification link,where subType is 
specified instead, doesnt work:

 

{{{}}
{{    "classificationDefs": [}}
{{        {}}
{{            "category": "CLASSIFICATION",}}
{{            "guid": "39a8acf8-0d4c-427d-94f1-e677487a9423",}}
{{            "createdBy": "admin",}}
{{            "updatedBy": "admin",}}
{{            "createTime": 1661496389541,}}
{{            "updateTime": 1661496389541,}}
{{            "version": 1,}}
{{            "name": "XCLASS1",}}
{{            "description": "XCLASSS",}}
{{            "typeVersion": "1.0",}}
{{            "attributeDefs": [],}}
{{            "superTypes": [],}}
{{            "entityTypes": [],}}
{{            "subTypes": ["TCLASS"]}}
{{        }}}
{{    ],}}
{{    "entityDefs": [],}}
{{    "enumDefs": [],}}
{{    "structDefs": []}}
{{}}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ATLAS-4666) Intermittently, the audits for creation of hive_db registered are different than expected.

2022-08-26 Thread Rahul Kurup (Jira)
Rahul Kurup created ATLAS-4666:
--

 Summary: Intermittently, the audits for creation of hive_db 
registered are different than expected.
 Key: ATLAS-4666
 URL: https://issues.apache.org/jira/browse/ATLAS-4666
 Project: Atlas
  Issue Type: Bug
Reporter: Rahul Kurup


Sometimes, when I create a hive database and then check for the same in Atlas, 
the audits tab shows unexpected audit entries: it shows two audit entries both 
marked as 'Entity Updated' rather than showing a 'Entity Created' audit entry 
anywhere.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4611) Atlas UI: Add text-editor for string attribute value of Business Metadata and for "description" field while creating Classification and Business Metadata.

2022-08-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585284#comment-17585284
 ] 

ASF subversion and git services commented on ATLAS-4611:


Commit 8bc54fd196bd6b6c6136b48258402eb4463315e7 in atlas's branch 
refs/heads/branch-2.0 from Farhan Khan
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=8bc54fd19 ]

ATLAS-4611 : (UI)Add text-editor for string attribute value of Business 
Metadata and for description field while creating Classification and Business 
Metadata

Signed-off-by: Pinal Shah 
(cherry picked from commit d034bad23188f4292ee9befb2414d621b5be8945)


> Atlas UI: Add text-editor for string attribute value of Business Metadata and 
> for "description" field while creating Classification and Business Metadata.
> --
>
> Key: ATLAS-4611
> URL: https://issues.apache.org/jira/browse/ATLAS-4611
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Prasad P. Pawar
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 
> 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch
>
>
> 1) Business Metadata ( Entity Detail Page)
> String attribute value should have text editor.
> 2) Classification and Business Metadata 
>  The "Description" field should have text editor as it has been implemented 
> for the Glossary section.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4611) Atlas UI: Add text-editor for string attribute value of Business Metadata and for "description" field while creating Classification and Business Metadata.

2022-08-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585283#comment-17585283
 ] 

ASF subversion and git services commented on ATLAS-4611:


Commit d034bad23188f4292ee9befb2414d621b5be8945 in atlas's branch 
refs/heads/master from Farhan Khan
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d034bad23 ]

ATLAS-4611 : (UI)Add text-editor for string attribute value of Business 
Metadata and for description field while creating Classification and Business 
Metadata

Signed-off-by: Pinal Shah 


> Atlas UI: Add text-editor for string attribute value of Business Metadata and 
> for "description" field while creating Classification and Business Metadata.
> --
>
> Key: ATLAS-4611
> URL: https://issues.apache.org/jira/browse/ATLAS-4611
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Prasad P. Pawar
>Assignee: Farhan Khan
>Priority: Major
> Attachments: 
> 0001-ATLAS-4611-UI-Add-text-editor-for-string-attribute-v.patch
>
>
> 1) Business Metadata ( Entity Detail Page)
> String attribute value should have text editor.
> 2) Classification and Business Metadata 
>  The "Description" field should have text editor as it has been implemented 
> for the Glossary section.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74095: Add text-editor for string attribute value of Business Metadata and for "description" field while creating Classification and Business Metadata.

2022-08-26 Thread Prasad Pawar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74095/#review224643
---


Ship it!




Ship It!

- Prasad Pawar


On Aug. 24, 2022, 11:45 a.m., Farhan Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74095/
> ---
> 
> (Updated Aug. 24, 2022, 11:45 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4611
> https://issues.apache.org/jira/browse/ATLAS-4611
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1) Business Metadata ( Entity Detail Page)
> String attribute value should have text editor.
> 
> 2) Classification and Business Metadata 
> 
>  The "Description" field should have text editor as it has been implemented 
> for the Glossary section.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/scss/override.scss f98c7fcb7 
>   dashboardv2/public/css/scss/texteditor.scss 275bdcc3d 
>   dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js 7ef6d172e 
>   
> dashboardv2/public/js/templates/business_metadata/BusinessMetadataAttributeItemView_tmpl.html
>  3d316f688 
>   
> dashboardv2/public/js/templates/business_metadata/BusinessMetadataDetailLayoutView_tmpl.html
>  d8a2b5b87 
>   
> dashboardv2/public/js/templates/business_metadata/CreateBusinessMetadataLayoutView_tmpl.html
>  a78614d15 
>   dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 
> c8b55f783 
>   dashboardv2/public/js/templates/tag/CreateTagLayoutView_tmpl.html 27ea91247 
>   dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 
> d12785bd8 
>   dashboardv2/public/js/utils/CommonViewFunction.js f15b32e1c 
>   dashboardv2/public/js/utils/Helper.js 0ba1b6c4e 
>   dashboardv2/public/js/utils/Utils.js f3126db75 
>   
> dashboardv2/public/js/views/business_metadata/BusinessMetadataDetailLayoutView.js
>  422808b82 
>   
> dashboardv2/public/js/views/business_metadata/BusinessMetadataTableLayoutView.js
>  6527eeb27 
>   
> dashboardv2/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
>  21bb663ab 
>   dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js 
> ff285068d 
>   dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js 213e7cc01 
>   dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js b070c5509 
>   dashboardv2/public/js/views/tag/CreateTagLayoutView.js 476007a2c 
>   dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js be33e7c32 
>   dashboardv2/public/js/views/tag/TagLayoutView.js f7af026b7 
>   dashboardv3/public/css/scss/override.scss fec5f6f02 
>   dashboardv3/public/css/scss/texteditor.scss 275bdcc3d 
>   dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js 7ef6d172e 
>   
> dashboardv3/public/js/templates/business_metadata/BusinessMetadataAttributeItemView_tmpl.html
>  3d316f688 
>   
> dashboardv3/public/js/templates/business_metadata/BusinessMetadataDetailLayoutView_tmpl.html
>  2ad5ba5e0 
>   
> dashboardv3/public/js/templates/business_metadata/CreateBusinessMetadataLayoutView_tmpl.html
>  a78614d15 
>   dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 
> 64e603135 
>   dashboardv3/public/js/templates/tag/CreateTagLayoutView_tmpl.html 27ea91247 
>   dashboardv3/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 
> c999fe140 
>   dashboardv3/public/js/utils/CommonViewFunction.js 7aacb9887 
>   dashboardv3/public/js/utils/Helper.js 164beac57 
>   dashboardv3/public/js/utils/Utils.js d4db9f4b9 
>   
> dashboardv3/public/js/views/business_metadata/BusinessMetadataDetailLayoutView.js
>  ee5b84bdf 
>   
> dashboardv3/public/js/views/business_metadata/BusinessMetadataTableLayoutView.js
>  80932ce51 
>   
> dashboardv3/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
>  21bb663ab 
>   dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js 
> 913cc0faf 
>   dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js 81db8935e 
>   dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 845ace1c9 
>   dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 
> e31260d40 
>   dashboardv3/public/js/views/tag/CreateTagLayoutView.js 476007a2c 
>   dashboardv3/public/js/views/tag/TagAttributeDetailLayoutView.js 52ff0431d 
> 
> 
> Diff: https://reviews.apache.org/r/74095/diff/2/
> 
> 
> Testing
> ---
> 
> 1)Tested manually for all the pages where text-editor has been implemented 
> for all the possible scenarios.
> 
> 2)Did testing against XSS vulnerability.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>



[jira] [Updated] (ATLAS-4610) ATLAS UI : Classification/ Term: Add parent name for classification & name

2022-08-26 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4610:
---
Description: The classification and term assignment section should display 
their parents if present, on the detail page.  (was: The classification and 
term assignment section should display their parents if present, on the detail 
page and search page.)

> ATLAS UI : Classification/ Term: Add parent name for classification & name 
> ---
>
> Key: ATLAS-4610
> URL: https://issues.apache.org/jira/browse/ATLAS-4610
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4610-ATLAS-UI-Classification-Term-Add-parent-n.patch
>
>
> The classification and term assignment section should display their parents 
> if present, on the detail page.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)