[jira] [Assigned] (ATLAS-4669) Atlas - Upgrade Junit to 4.13.2

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole reassigned ATLAS-4669:
--

Assignee: chaitali borole

> Atlas - Upgrade Junit to 4.13.2
> ---
>
> Key: ATLAS-4669
> URL: https://issues.apache.org/jira/browse/ATLAS-4669
> Project: Atlas
>  Issue Type: Improvement
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> currently Junit version is 4.13.1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4669) Atlas - Upgrade Junit to 4.13.2

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4669:
---
Description: currently Junit version is 4.13.1

> Atlas - Upgrade Junit to 4.13.2
> ---
>
> Key: ATLAS-4669
> URL: https://issues.apache.org/jira/browse/ATLAS-4669
> Project: Atlas
>  Issue Type: Improvement
>Reporter: chaitali borole
>Priority: Major
>
> currently Junit version is 4.13.1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74101: ATLAS-4668 : When classification is created with multiple super types having same attributes , Atlas doesn't throw an exception

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74101/#review224645
---




intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java
Lines 564 (patched)


attributeToClassificationNameMap.containsKey(attributeName)

I think having only this check is enough to identify duplicate attribute 
name from different parent defs

Also, if above statement is true, map allAttributes can be used instead 
defining another map called attributeToClassificationNameMap


- Nikhil Bonte


On Sept. 6, 2022, 11:06 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74101/
> ---
> 
> (Updated Sept. 6, 2022, 11:06 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, madhan, Pinal Shah, Radhika Kundam, 
> Sheetal Shah, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4668
> https://issues.apache.org/jira/browse/ATLAS-4668
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When an entity type is created with multiple super types having same 
> attribute name, Atlas throws exception.
> 
> Ex:
> 
> if there are 2 types:
> 
> type1 - attr1, attr2
> 
> type2- attr1, attr2
> 
> Both types cant be added to super type to type3 since both type1 and type2 
> have same attribute - attr1
> 
> This patch will check for the exact scenario in case of Classification 
> Typedef as well.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> 5b86b808b 
> 
> 
> Diff: https://reviews.apache.org/r/74101/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

[jira] [Created] (ATLAS-4669) Atlas - Upgrade Junit to 4.13.2

[chaitali borole (Jira)]

chaitali borole created ATLAS-4669:
--

 Summary: Atlas - Upgrade Junit to 4.13.2
 Key: ATLAS-4669
 URL: https://issues.apache.org/jira/browse/ATLAS-4669
 Project: Atlas
  Issue Type: Improvement
Reporter: chaitali borole






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74101: ATLAS-4668 : When classification is created with multiple super types having same attributes , Atlas doesn't throw an exception

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74101/
---

(Updated Sept. 6, 2022, 5:36 a.m.)


Review request for atlas, Jayendra Parab, madhan, Pinal Shah, Radhika Kundam, 
Sheetal Shah, and Sidharth Mishra.


Bugs: ATLAS-4668
https://issues.apache.org/jira/browse/ATLAS-4668


Repository: atlas


Description
---

When an entity type is created with multiple super types having same attribute 
name, Atlas throws exception.

Ex:

if there are 2 types:

type1 - attr1, attr2

type2- attr1, attr2

Both types cant be added to super type to type3 since both type1 and type2 have 
same attribute - attr1

This patch will check for the exact scenario in case of Classification Typedef 
as well.


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
5b86b808b 


Diff: https://reviews.apache.org/r/74101/diff/1/


Testing
---


Thanks,

Mandar Ambawane

Review Request 74102: ATLAS-4666 : Intermittently, the audits for creation of hive_db registered are different than expected

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74102/
---

Review request for atlas, Jayendra Parab, Pinal Shah, Radhika Kundam, and 
Sidharth Mishra.


Bugs: ATLAS-4666
https://issues.apache.org/jira/browse/ATLAS-4666


Repository: atlas


Description
---

Sometimes, when I create a hive database and then check for the same in Atlas, 
the audits tab shows unexpected audit entries: it shows two audit entries both 
marked as 'Entity Updated' rather than showing a 'Entity Created' audit entry 
anywhere.

This patch will check for the Shell entities created and then assign the Entity 
status to the Audit entry.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 d48c91709 


Diff: https://reviews.apache.org/r/74102/diff/1/


Testing
---


Thanks,

Mandar Ambawane