Re: Review Request 74195: ATLAS-3403 : Term assigned to historical entity is not visible in Search results page.

2022-11-14 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74195/
---

(Updated Nov. 15, 2022, 5:56 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-3403
https://issues.apache.org/jira/browse/ATLAS-3403


Repository: atlas


Description
---

Let us consider that a classification and a term has been assigned to an 
entity. 

If that entity is deleted, and then when the "Show Historical Entities" filter 
is enabled on the search results page for that entity, the classification is 
displayed but not the term.

This patch handles above issue


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 0ed418330 


Diff: https://reviews.apache.org/r/74195/diff/1/


Testing (updated)
---

mvn clean install
Sanity testing
PC successful
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1284/console

Below json for output after fixing issue we can see term getting added in 
MeaningNames and meanings:

http://localhost:21000/api/atlas/v2/search/basic


{"queryType":"BASIC","searchParameters":{"typeName":"hdfs_path","excludeDeletedEntities":false,"includeClassificationAttributes":true,"includeSubTypes":true,"includeSubClassifications":true,"excludeHeaderAttributes":false,"limit":25,"offset":0,"attributes":[]},"entities":[{"typeName":"hdfs_path","attributes":{"owner":"","createTime":166784580,"qualifiedName":"abc","name":"abc","description":""},"guid":"22f365a3-5d7c-49d0-b2dc-324adf77d3fe","status":"DELETED","displayText":"abc","classificationNames":["class1"],"classifications":[{"typeName":"class1","entityGuid":"22f365a3-5d7c-49d0-b2dc-324adf77d3fe","entityStatus":"DELETED","propagate":true,"validityPeriods":[],"removePropagationsOnEntityDelete":false}],"meaningNames":["term1"],"meanings":[{"termGuid":"c983b9b9-5b0a-409b-9a30-c0328cd1b3ad","relationGuid":"29ddea1a-adbf-4e48-9c85-72b8a97e10ac","displayText":"term1","confidence":0,"qualifiedName":"term1@gloss1"}],"isIncomplete":false,"labels":[]}],"approximateCount":1}


Thanks,

chaitali



Re: Review Request 74197: ATLAS-4707: updated loader-utils version from 1.4.0 to 1.4.1

2022-11-14 Thread Prasad Pawar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74197/#review224862
---


Ship it!




Ship It!

- Prasad Pawar


On Nov. 8, 2022, 6:12 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74197/
> ---
> 
> (Updated Nov. 8, 2022, 6:12 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nikhil Bonte, 
> Nixon Rodrigues, Pinal Shah, Prasad Pawar, Radhika Kundam, Sarath 
> Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4707
> https://issues.apache.org/jira/browse/ATLAS-4707
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Patch from following pull requests:
> - https://github.com/apache/atlas/pull/205
> - https://github.com/apache/atlas/pull/206
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/external_lib/atlas-lineage/package-lock.json 
> 890350198 
>   dashboardv3/public/js/external_lib/atlas-lineage/package-lock.json 
> 890350198 
> 
> 
> Diff: https://reviews.apache.org/r/74197/diff/1/
> 
> 
> Testing
> ---
> 
> - sanity testing of Atlas UI
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>