[GitHub] [atlas] mneethiraj commented on pull request #222: Update copy constructor of AtlasClassification
mneethiraj commented on PR #222: URL: https://github.com/apache/atlas/pull/222#issuecomment-1577568328 @TomDu - thank you for the fix. Can you please file a JIRA at https://issues.apache.org/jira/issues/?jql=project%3DATLAS, and include the JIRA # in commit message? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [atlas] mneethiraj commented on pull request #231: [ATLAS-4759] Do not suppress HTTP 503 error in Python client
mneethiraj commented on PR #231: URL: https://github.com/apache/atlas/pull/231#issuecomment-1577551676 @dolfinus - thank you for the fix. Fix is merged in master and branch-2.0 branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [atlas] mneethiraj closed pull request #231: [ATLAS-4759] Do not suppress HTTP 503 error in Python client
mneethiraj closed pull request #231: [ATLAS-4759] Do not suppress HTTP 503 error in Python client URL: https://github.com/apache/atlas/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (ATLAS-4759) Atlas Python client suppresses 503 error
[
https://issues.apache.org/jira/browse/ATLAS-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Madhan Neethiraj resolved ATLAS-4759.
-
Fix Version/s: 3.0.0
2.4.0
Assignee: Maxim Martynov
Resolution: Fixed
[~dolfinus] - thank you for the fix. The patch is now merged in following
branches:
{noformat}
commit b7849aeb78856f2f8e205c5e784cee84409cbc72 (HEAD -> master, origin/master,
origin/HEAD)
Author: Maxim Martynov
Date: Mon Jun 5 12:33:35 2023 -0700
ATLAS-4759: Python client - do not suppress HTTP 503 (SERVICE_UNAVAILABLE)
Signed-off-by: Madhan Neethiraj
{noformat}
{noformat}
commit b1d9450761de70adf9b3ecd35b5f62dc31d70489 (HEAD -> branch-2.0,
origin/branch-2.0)
Author: Maxim Martynov
Date: Mon Jun 5 12:33:35 2023 -0700
ATLAS-4759: Python client - do not suppress HTTP 503 (SERVICE_UNAVAILABLE)
Signed-off-by: Madhan Neethiraj
(cherry picked from commit b7849aeb78856f2f8e205c5e784cee84409cbc72)
{noformat}
> Atlas Python client suppresses 503 error
>
>
> Key: ATLAS-4759
> URL: https://issues.apache.org/jira/browse/ATLAS-4759
> Project: Atlas
> Issue Type: Bug
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Assignee: Maxim Martynov
>Priority: Major
> Fix For: 3.0.0, 2.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently if Python client for Apache Atlas gets HTTP 503 error code, it
> always returns {{None}}:
> https://github.com/apache/atlas/blob/b19fba2ad96e3007af79d646ba17b6bd783d9156/intg/src/main/python/apache_atlas/client/base_client.py#L113-L116
> So if someone writes data to Atlas (e.g. update entity properties, save
> lineage info), there is no distinction if {{None}} is returned because it is
> supposed to do (e.g. 204 No content) or Atlas is not available.
> It is recommended to raise exception here.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ATLAS-4759) Atlas Python client suppresses 503 error
[
https://issues.apache.org/jira/browse/ATLAS-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729449#comment-17729449
]
ASF subversion and git services commented on ATLAS-4759:
Commit b1d9450761de70adf9b3ecd35b5f62dc31d70489 in atlas's branch
refs/heads/branch-2.0 from Maxim Martynov
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b1d945076 ]
ATLAS-4759: Python client - do not suppress HTTP 503 (SERVICE_UNAVAILABLE)
Signed-off-by: Madhan Neethiraj
(cherry picked from commit b7849aeb78856f2f8e205c5e784cee84409cbc72)
> Atlas Python client suppresses 503 error
>
>
> Key: ATLAS-4759
> URL: https://issues.apache.org/jira/browse/ATLAS-4759
> Project: Atlas
> Issue Type: Bug
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently if Python client for Apache Atlas gets HTTP 503 error code, it
> always returns {{None}}:
> https://github.com/apache/atlas/blob/b19fba2ad96e3007af79d646ba17b6bd783d9156/intg/src/main/python/apache_atlas/client/base_client.py#L113-L116
> So if someone writes data to Atlas (e.g. update entity properties, save
> lineage info), there is no distinction if {{None}} is returned because it is
> supposed to do (e.g. 204 No content) or Atlas is not available.
> It is recommended to raise exception here.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ATLAS-4759) Atlas Python client suppresses 503 error
[
https://issues.apache.org/jira/browse/ATLAS-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729448#comment-17729448
]
ASF subversion and git services commented on ATLAS-4759:
Commit b7849aeb78856f2f8e205c5e784cee84409cbc72 in atlas's branch
refs/heads/master from Maxim Martynov
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b7849aeb7 ]
ATLAS-4759: Python client - do not suppress HTTP 503 (SERVICE_UNAVAILABLE)
Signed-off-by: Madhan Neethiraj
> Atlas Python client suppresses 503 error
>
>
> Key: ATLAS-4759
> URL: https://issues.apache.org/jira/browse/ATLAS-4759
> Project: Atlas
> Issue Type: Bug
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently if Python client for Apache Atlas gets HTTP 503 error code, it
> always returns {{None}}:
> https://github.com/apache/atlas/blob/b19fba2ad96e3007af79d646ba17b6bd783d9156/intg/src/main/python/apache_atlas/client/base_client.py#L113-L116
> So if someone writes data to Atlas (e.g. update entity properties, save
> lineage info), there is no distinction if {{None}} is returned because it is
> supposed to do (e.g. 204 No content) or Atlas is not available.
> It is recommended to raise exception here.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (ATLAS-4658) base_client.py implementation is a bit messy
[
https://issues.apache.org/jira/browse/ATLAS-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Madhan Neethiraj reassigned ATLAS-4658:
---
Assignee: Maxim Martynov
> base_client.py implementation is a bit messy
>
>
> Key: ATLAS-4658
> URL: https://issues.apache.org/jira/browse/ATLAS-4658
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Assignee: Maxim Martynov
>Priority: Major
> Fix For: 3.0.0, 2.4.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> atlas_client/client/base_client.py looks a bit messy:
> https://github.com/apache/atlas/blob/c1daaa44c3833be31c006753a2cf2f6f2e476cdc/intg/src/main/python/apache_atlas/client/base_client.py#L79-L120
> # There is no need to make conditions with mapping between HTTPMethod enum
> values and corresponding {{requests.Session}} methods - there is a
> {{requests.Session.request}} method which accepts HTTP method as argument
> # There is no need to use {{elif}} in conditions if previous clauses are
> ended with {{return}} or {{raise}} statements
> # There is not need to use {{logger.isEnabledFor(logging.DEBUG)}} before
> calling {{{}logger.debug{}}}, this is already done in {{.debug}} method itself
> # Use {{{}logging{}}}, not {{print}}
> # logging.exception already shows full exception traceback, no need
> to explicitly show add it into a logging message
>
> I've creates pull request with a fix for all these items:
> https://github.com/apache/atlas/pull/158/files
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (ATLAS-4658) base_client.py implementation is a bit messy
[
https://issues.apache.org/jira/browse/ATLAS-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Madhan Neethiraj resolved ATLAS-4658.
-
Fix Version/s: 3.0.0
2.4.0
Resolution: Fixed
[~dolfinus] - thank you for the fix. The patch is now merged in following
branches:
{noformat}
commit ad24235f492066378842cb0c1fbf9bde43da0391 (HEAD -> master, origin/master,
origin/HEAD)
Author: Maxim Martynov
Date: Mon Jun 5 12:07:51 2023 -0700
ATLAS-4658: Python client - simply if clauses in AtlasClient.call_api
Signed-off-by: Madhan Neethiraj
{noformat}
{noformat}
commit 8df8b41a5b9ce7410efe388f3184d109201080d4 (HEAD -> branch-2.0,
origin/branch-2.0)
Author: Maxim Martynov
Date: Mon Jun 5 12:07:51 2023 -0700
ATLAS-4658: Python client - simply if clauses in AtlasClient.call_api
Signed-off-by: Madhan Neethiraj
(cherry picked from commit ad24235f492066378842cb0c1fbf9bde43da0391)
{noformat}
> base_client.py implementation is a bit messy
>
>
> Key: ATLAS-4658
> URL: https://issues.apache.org/jira/browse/ATLAS-4658
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Priority: Major
> Fix For: 3.0.0, 2.4.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> atlas_client/client/base_client.py looks a bit messy:
> https://github.com/apache/atlas/blob/c1daaa44c3833be31c006753a2cf2f6f2e476cdc/intg/src/main/python/apache_atlas/client/base_client.py#L79-L120
> # There is no need to make conditions with mapping between HTTPMethod enum
> values and corresponding {{requests.Session}} methods - there is a
> {{requests.Session.request}} method which accepts HTTP method as argument
> # There is no need to use {{elif}} in conditions if previous clauses are
> ended with {{return}} or {{raise}} statements
> # There is not need to use {{logger.isEnabledFor(logging.DEBUG)}} before
> calling {{{}logger.debug{}}}, this is already done in {{.debug}} method itself
> # Use {{{}logging{}}}, not {{print}}
> # logging.exception already shows full exception traceback, no need
> to explicitly show add it into a logging message
>
> I've creates pull request with a fix for all these items:
> https://github.com/apache/atlas/pull/158/files
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ATLAS-4658) base_client.py implementation is a bit messy
[
https://issues.apache.org/jira/browse/ATLAS-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729439#comment-17729439
]
ASF subversion and git services commented on ATLAS-4658:
Commit 8df8b41a5b9ce7410efe388f3184d109201080d4 in atlas's branch
refs/heads/branch-2.0 from Maxim Martynov
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=8df8b41a5 ]
ATLAS-4658: Python client - simply if clauses in AtlasClient.call_api
Signed-off-by: Madhan Neethiraj
(cherry picked from commit ad24235f492066378842cb0c1fbf9bde43da0391)
> base_client.py implementation is a bit messy
>
>
> Key: ATLAS-4658
> URL: https://issues.apache.org/jira/browse/ATLAS-4658
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> atlas_client/client/base_client.py looks a bit messy:
> https://github.com/apache/atlas/blob/c1daaa44c3833be31c006753a2cf2f6f2e476cdc/intg/src/main/python/apache_atlas/client/base_client.py#L79-L120
> # There is no need to make conditions with mapping between HTTPMethod enum
> values and corresponding {{requests.Session}} methods - there is a
> {{requests.Session.request}} method which accepts HTTP method as argument
> # There is no need to use {{elif}} in conditions if previous clauses are
> ended with {{return}} or {{raise}} statements
> # There is not need to use {{logger.isEnabledFor(logging.DEBUG)}} before
> calling {{{}logger.debug{}}}, this is already done in {{.debug}} method itself
> # Use {{{}logging{}}}, not {{print}}
> # logging.exception already shows full exception traceback, no need
> to explicitly show add it into a logging message
>
> I've creates pull request with a fix for all these items:
> https://github.com/apache/atlas/pull/158/files
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ATLAS-4658) base_client.py implementation is a bit messy
[
https://issues.apache.org/jira/browse/ATLAS-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729432#comment-17729432
]
ASF subversion and git services commented on ATLAS-4658:
Commit ad24235f492066378842cb0c1fbf9bde43da0391 in atlas's branch
refs/heads/master from Maxim Martynov
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ad24235f4 ]
ATLAS-4658: Python client - simply if clauses in AtlasClient.call_api
Signed-off-by: Madhan Neethiraj
> base_client.py implementation is a bit messy
>
>
> Key: ATLAS-4658
> URL: https://issues.apache.org/jira/browse/ATLAS-4658
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-intg
>Affects Versions: 2.1.0
>Reporter: Maxim Martynov
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> atlas_client/client/base_client.py looks a bit messy:
> https://github.com/apache/atlas/blob/c1daaa44c3833be31c006753a2cf2f6f2e476cdc/intg/src/main/python/apache_atlas/client/base_client.py#L79-L120
> # There is no need to make conditions with mapping between HTTPMethod enum
> values and corresponding {{requests.Session}} methods - there is a
> {{requests.Session.request}} method which accepts HTTP method as argument
> # There is no need to use {{elif}} in conditions if previous clauses are
> ended with {{return}} or {{raise}} statements
> # There is not need to use {{logger.isEnabledFor(logging.DEBUG)}} before
> calling {{{}logger.debug{}}}, this is already done in {{.debug}} method itself
> # Use {{{}logging{}}}, not {{print}}
> # logging.exception already shows full exception traceback, no need
> to explicitly show add it into a logging message
>
> I've creates pull request with a fix for all these items:
> https://github.com/apache/atlas/pull/158/files
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Call for Presentations, Community Over Code Asia 2023
You are receiving this message because you are subscribed to one more more developer mailing lists at the Apache Software Foundation. The call for presentations is now open at "https://apachecon.com/acasia2023/cfp.html;, and will be closed by Sunday, Jun 18th, 2023 11:59 PM GMT. The event will be held in Beijing, China, August 18-20, 2023. We are looking for presentations about anything relating to Apache Software Foundation projects, open-source governance, community, and software development. In particular, this year we are building content tracks around the following specific topics/projects: AI / Machine learning API / Microservice Community CloudNative Data Storage & Computing DataOps Data Lake & Data Warehouse OLAP & Data Analysis Performance Engineering Incubator IoT/IIoT Messaging RPC Streaming Workflow / Data Processing Web Server / Tomcat If your proposed presentation falls into one of these categories, please select that topic in the CFP entry form. Or select Others if it’s related to another topic or project area. Looking forward to hearing from you! Willem Jiang, and the Community Over Code planners
[GitHub] [atlas] dolfinus commented on a diff in pull request #158: [ATLAS-4658] Simply if clauses in AtlasClient.call_api
dolfinus commented on code in PR #158:
URL: https://github.com/apache/atlas/pull/158#discussion_r1217884091
##
intg/src/main/python/apache_atlas/client/base_client.py:
##
@@ -68,51 +68,36 @@ def call_api(self, api, response_type=None,
query_params=None, request_obj=None)
if request_obj is not None:
params['data'] = json.dumps(request_obj)
-if log.isEnabledFor(logging.DEBUG):
-log.debug("--")
-log.debug("Call : %s %s", api.method, path)
-log.debug("Content-type : %s", api.consumes)
-log.debug("Accept : %s", api.produces)
-
-response = None
-
-if api.method == HTTPMethod.GET:
-response = self.session.get(path, **params)
-elif api.method == HTTPMethod.POST:
-response = self.session.post(path, **params)
-elif api.method == HTTPMethod.PUT:
-response = self.session.put(path, **params)
-elif api.method == HTTPMethod.DELETE:
-response = self.session.delete(path, **params)
-
-if response is not None:
-log.debug("HTTP Status: %s", response.status_code)
-
-if response is None:
-return None
-elif response.status_code == api.expected_status:
+log.debug("--")
+log.debug("Call : %s %s", api.method, path)
+log.debug("Content-type : %s", api.consumes)
+log.debug("Accept : %s", api.produces)
+
+method = HTTPMethod(api.method)
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [atlas] dolfinus commented on a diff in pull request #158: [ATLAS-4658] Simply if clauses in AtlasClient.call_api
dolfinus commented on code in PR #158:
URL: https://github.com/apache/atlas/pull/158#discussion_r1217880632
##
intg/src/main/python/apache_atlas/client/base_client.py:
##
@@ -68,51 +68,36 @@ def call_api(self, api, response_type=None,
query_params=None, request_obj=None)
if request_obj is not None:
params['data'] = json.dumps(request_obj)
-if log.isEnabledFor(logging.DEBUG):
-log.debug("--")
-log.debug("Call : %s %s", api.method, path)
-log.debug("Content-type : %s", api.consumes)
-log.debug("Accept : %s", api.produces)
-
-response = None
-
-if api.method == HTTPMethod.GET:
-response = self.session.get(path, **params)
-elif api.method == HTTPMethod.POST:
-response = self.session.post(path, **params)
-elif api.method == HTTPMethod.PUT:
-response = self.session.put(path, **params)
-elif api.method == HTTPMethod.DELETE:
-response = self.session.delete(path, **params)
-
-if response is not None:
-log.debug("HTTP Status: %s", response.status_code)
-
-if response is None:
-return None
-elif response.status_code == api.expected_status:
+log.debug("--")
+log.debug("Call : %s %s", api.method, path)
+log.debug("Content-type : %s", api.consumes)
+log.debug("Accept : %s", api.produces)
+
+method = HTTPMethod(api.method)
+response = self.session.request(method.value, path, **params)
+log.debug("HTTP Status: %s", response.status_code)
+
+if response.status_code == api.expected_status:
if response_type is None:
return None
+
+if response.content is None:
+return None
+log.debug("<== __call_api(%s,%s,%s), result = %s", vars(api),
params, request_obj, response)
try:
-if response.content is not None:
-if log.isEnabledFor(logging.DEBUG):
-log.debug("<== __call_api(%s,%s,%s), result = %s",
vars(api), params, request_obj, response)
+log.debug(response.json())
-log.debug(response.json())
-if response_type == str:
-return json.dumps(response.json())
+if response_type == str:
+return json.dumps(response.json())
-return type_coerce(response.json(), response_type)
-else:
-return None
+return type_coerce(response.json(), response_type)
except Exception as e:
-log.exception("Exception occurred while parsing response with
msg: %s", e)
+log.exception("Exception occurred while parsing response")
Review Comment:
`log.exception` already prints exception stacktrace and message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
