[jira] [Resolved] (ATLAS-4822) Relationship Search feature should be configurable

[VINAYAK MARRAIYA (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

VINAYAK MARRAIYA resolved ATLAS-4822.
-
Resolution: Fixed

> Relationship Search feature should be configurable
> --
>
> Key: ATLAS-4822
> URL: https://issues.apache.org/jira/browse/ATLAS-4822
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0, 2.3.0
>Reporter: VINAYAK MARRAIYA
>Assignee: VINAYAK MARRAIYA
>Priority: Major
> Attachments: 
> 0001-ATLAS-4822-ATLAS-UI-Relationship-Search-feature-shou.patch, 
> 0002-ATLAS-4822-ATLAS-UI-Relationship-Search-feature-shou.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4822) Relationship Search feature should be configurable

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827383#comment-17827383
 ] 

ASF subversion and git services commented on ATLAS-4822:


Commit 9a5ad2d4736577eaabe73887afc65f7b15634907 in atlas's branch 
refs/heads/branch-2.0 from vinayak.marraiya
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=9a5ad2d47 ]

ATLAS-4822: Relationship Search feature should be configurable

Signed-off-by: Pinal Shah 


> Relationship Search feature should be configurable
> --
>
> Key: ATLAS-4822
> URL: https://issues.apache.org/jira/browse/ATLAS-4822
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0, 2.3.0
>Reporter: VINAYAK MARRAIYA
>Assignee: VINAYAK MARRAIYA
>Priority: Major
> Attachments: 
> 0001-ATLAS-4822-ATLAS-UI-Relationship-Search-feature-shou.patch, 
> 0002-ATLAS-4822-ATLAS-UI-Relationship-Search-feature-shou.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ATLAS-4822) Relationship Search feature should be configurable

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827382#comment-17827382
 ] 

ASF subversion and git services commented on ATLAS-4822:


Commit b4745dcfe1799d9eddf43f62cffa162d19ad0c92 in atlas's branch 
refs/heads/master from vinayak.marraiya
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b4745dcfe ]

ATLAS-4822: Relationship Search feature should be configurable

Signed-off-by: Pinal Shah 


> Relationship Search feature should be configurable
> --
>
> Key: ATLAS-4822
> URL: https://issues.apache.org/jira/browse/ATLAS-4822
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0, 2.3.0
>Reporter: VINAYAK MARRAIYA
>Assignee: VINAYAK MARRAIYA
>Priority: Major
> Attachments: 
> 0001-ATLAS-4822-ATLAS-UI-Relationship-Search-feature-shou.patch, 
> 0002-ATLAS-4822-ATLAS-UI-Relationship-Search-feature-shou.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Prasad Pawar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/#review226330
---


Ship it!




UI Changes looks Good to me. Ship it!

- Prasad Pawar


On March 15, 2024, 5:23 a.m., Vinayak Marraiya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74851/
> ---
> 
> (Updated March 15, 2024, 5:23 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and 
> Sheetal Shah.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Relationship search  is enabled (for backend and UI), by default and the 
> value for atlas.relationship.search.enabled is true.
> Relationship search will be disabled from backend and UI, if the value for 
> atlas.relationship.search.enabled is false.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
>   dashboardv2/public/js/main.js f0cea7999 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
>   dashboardv2/public/js/utils/Globals.js 431a24b38 
>   dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
>   dashboardv3/public/js/main.js 7423c88c3 
>   dashboardv3/public/js/utils/Globals.js 410d82881 
>   dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js 
> c81a74fd8 
>   dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
> ea7185b35 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
>  c3a9106fa 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 27ec59d37 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 
> 
> 
> Diff: https://reviews.apache.org/r/74851/diff/10/
> 
> 
> Testing
> ---
> 
> Tested following:
> 
> 1. Checked whether default behaviour (relationship search APIs are disabled 
> in UI) works.
> 2. Checked whether following APIs are disabled when property is set to false.
>   GET/POST /v2/search/relations
>   GET /v2/search/relationship
> 3. Checked whether current basic search and dsl search functionalities work 
> even when relationship search is disabled.
> 4. Tested disabling and enabling of property
> 
> 
> Precommit - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console
> 
> 
> Thanks,
> 
> Vinayak Marraiya
> 
>

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/#review226329
---


Ship it!




Ship It!

- Pinal Shah


On March 14, 2024, 4:05 p.m., Vinayak Marraiya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74851/
> ---
> 
> (Updated March 14, 2024, 4:05 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Relationship search  is enabled (for backend and UI), by default and the 
> value for atlas.relationship.search.enabled is true.
> Relationship search will be disabled from backend and UI, if the value for 
> atlas.relationship.search.enabled is false.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
>   dashboardv2/public/js/main.js f0cea7999 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
>   dashboardv2/public/js/utils/Globals.js 431a24b38 
>   dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
>   dashboardv3/public/js/main.js 7423c88c3 
>   dashboardv3/public/js/utils/Globals.js 410d82881 
>   dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js 
> c81a74fd8 
>   dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
> ea7185b35 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
>  c3a9106fa 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 27ec59d37 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 
> 
> 
> Diff: https://reviews.apache.org/r/74851/diff/10/
> 
> 
> Testing
> ---
> 
> Tested following:
> 
> 1. Checked whether default behaviour (relationship search APIs are disabled 
> in UI) works.
> 2. Checked whether following APIs are disabled when property is set to false.
>   GET/POST /v2/search/relations
>   GET /v2/search/relationship
> 3. Checked whether current basic search and dsl search functionalities work 
> even when relationship search is disabled.
> 4. Tested disabling and enabling of property
> 
> 
> Precommit - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console
> 
> 
> Thanks,
> 
> Vinayak Marraiya
> 
>

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Vinayak Marraiya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
---

(Updated March 14, 2024, 4:05 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Repository: atlas


Description
---

Relationship search  is enabled (for backend and UI), by default and the value 
for atlas.relationship.search.enabled is true.
Relationship search will be disabled from backend and UI, if the value for 
atlas.relationship.search.enabled is false.


Diffs (updated)
-

  dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
  dashboardv2/public/js/main.js f0cea7999 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
  dashboardv2/public/js/utils/Globals.js 431a24b38 
  dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
  dashboardv3/public/js/main.js 7423c88c3 
  dashboardv3/public/js/utils/Globals.js 410d82881 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8 
  dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
ea7185b35 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
  
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
 c3a9106fa 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
27ec59d37 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 


Diff: https://reviews.apache.org/r/74851/diff/10/

Changes: https://reviews.apache.org/r/74851/diff/9-10/


Testing
---

Tested following:

1. Checked whether default behaviour (relationship search APIs are disabled in 
UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work 
even when relationship search is disabled.
4. Tested disabling and enabling of property


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console


Thanks,

Vinayak Marraiya

Re: [DRAFT] [REPORT] Apache Atlas - March 2024

[Nikhil Bonte]

Looks Good to me
Thanks Madhan for putting this together


Regards
Nikhil P. Bonte

On Wed, 13 Mar 2024 at 1:17 PM, Madhan Neethiraj  wrote:

> Atlas community,
>
> Please review the following draft report for this quarter.
>
> Thanks,
> Madhan
>
>
> ## Description:
> The mission of Apache Atlas is the creation and maintenance of software
> related
> to a scalable and extensible set of core foundational governance services
> -
> enabling enterprises to effectively and efficiently meet their compliance
> requirements
>
> ## Project Status:
> Current project status: Ongoing, with low activity
> Issues for the board: here are no issues requiring board attention.
>
> ## Membership Data:
> Apache Atlas was founded 2017-06-20 (7 years ago)
> There are currently 48 committers and 32 PMC members in this project.
> The Committer-to-PMC ratio is 3:2.
>
> Community changes, past quarter:
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
> ## Project Activity:
> - fixes in download search results functionality
> - UI updates to improve usability of tag-propagation enable/disable
> - fix in business metadata changes to update system attributes
> - updated versions of Spring Security, netty
>
> ## Community Health:
> - dev@atlas.apache.org had a 40% decrease in traffic in the past quarter
> (143
>   emails compared to 238)
> - u...@atlas.apache.org had a 100% increase in traffic in the past
> quarter (8
>   emails compared to 4)
> - 10 commits in the past quarter (-73% change)
> - 6 code contributors in the past quarter (-50% change)
>
> ## Recent releases:
> - Apache Atlas 2.3.0 was released on 2022-12-06
> - Apache Atlas 2.2.0 was released on 2021-08-17
> - Apache Atlas 2.1.0 was released on 2020-07-15
>
>
>
>
>

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/#review226328
---




webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
Lines 549 (patched)


Remove the check from here, this api is not for relationship edge search.


- Pinal Shah


On March 13, 2024, 5:09 p.m., Vinayak Marraiya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74851/
> ---
> 
> (Updated March 13, 2024, 5:09 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Relationship search  is enabled (for backend and UI), by default and the 
> value for atlas.relationship.search.enabled is true.
> Relationship search will be disabled from backend and UI, if the value for 
> atlas.relationship.search.enabled is false.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
>   dashboardv2/public/js/main.js f0cea7999 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
>   dashboardv2/public/js/utils/Globals.js 431a24b38 
>   dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
>   dashboardv3/public/js/main.js 7423c88c3 
>   dashboardv3/public/js/utils/Globals.js 410d82881 
>   dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js 
> c81a74fd8 
>   dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
> ea7185b35 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
>  c3a9106fa 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 4d59fa3d6 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 
> 
> 
> Diff: https://reviews.apache.org/r/74851/diff/9/
> 
> 
> Testing
> ---
> 
> Tested following:
> 
> 1. Checked whether default behaviour (relationship search APIs are disabled 
> in UI) works.
> 2. Checked whether following APIs are disabled when property is set to false.
>   GET/POST /v2/search/relations
>   GET /v2/search/relationship
> 3. Checked whether current basic search and dsl search functionalities work 
> even when relationship search is disabled.
> 4. Tested disabling and enabling of property
> 
> 
> Precommit - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console
> 
> 
> Thanks,
> 
> Vinayak Marraiya
> 
>