Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-23 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/#review226393
---




intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Lines 1083 (patched)


please another method for #1083 to #1090

private static boolean hasCJKChar(String value, int i) {

}



repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 120 (patched)


please move this piece of code above
#233
 if (needFullTextProcessor()) {



repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 121 (patched)


This will be checked twice, one here and other in 
EntityDiscoveryService.java

public AtlasQuickSearchResult quickSearch(QuickSearchParameters 
quickSearchParameters) throws AtlasBaseException {
String query = quickSearchParameters.getQuery();
if (StringUtils.isNotEmpty(query) && 
!AtlasStructType.AtlasAttribute.hastokenizeChar(query)) {
query = query + "*";
}
quickSearchParameters.setQuery(query);

please remove from here



repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 123 (patched)


please review the conditions again, for the below cases

query = abc@123* should be query = abc@123
query = abc@123  should be query = abc@123
query = abc  should be query = abc*
query = abc* should be query = abc*

if (StringUtils.isNotEmpty(query) && query.endsWith("*")) {
  query = query.substring(0, query.length()-1);

}

if (StringUtils.isNotEmpty(query) && 
!AtlasStructType.AtlasAttribute.hastokenizeChar(query)) {
query = query + "*";
searchParameters.setQuery(query);
}


- Pinal Shah


On April 23, 2024, 8:04 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74925/
> ---
> 
> (Updated April 23, 2024, 8:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
> Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4225
> https://issues.apache.org/jira/browse/ATLAS-4225
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated latest patch with synchronized code 
> 
> Creating this review request to track and close 
> https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
> with latest code
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 9a9a5512a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  01b88eb2f 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  282a3fd4a 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  1489b2760 
> 
> 
> Diff: https://reviews.apache.org/r/74925/diff/3/
> 
> 
> Testing
> ---
> 
> Testcases are added in the patch
> PC is successful : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 74925: ATLAS-4225 : Support for Chinese character in entity data.

2024-04-23 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74925/
---

(Updated April 23, 2024, 8:04 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal 
Shah, and Sheetal Shah.


Bugs: ATLAS-4225
https://issues.apache.org/jira/browse/ATLAS-4225


Repository: atlas


Description
---

Updated latest patch with synchronized code 

Creating this review request to track and close 
https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync 
with latest code


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
9a9a5512a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 01b88eb2f 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 282a3fd4a 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 1489b2760 


Diff: https://reviews.apache.org/r/74925/diff/3/

Changes: https://reviews.apache.org/r/74925/diff/2-3/


Testing
---

Testcases are added in the patch
PC is successful : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull


Thanks,

chaitali

Review Request 74961: ATLAS-4854 : Atlas - Upgrade Spring Security to 5.8.11

2024-04-23 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74961/
---

Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4854
https://issues.apache.org/jira/browse/ATLAS-4854


Repository: atlas


Description
---

Currently Atlas is using Spring security version 5.8.5 upgrading it to 5.8.11


Diffs
-

  pom.xml 6e6724275 


Diff: https://reviews.apache.org/r/74961/diff/1/


Testing
---


Thanks,

Priyanshi Shah

[jira] [Updated] (ATLAS-4854) Atlas - Upgrade Spring Security to 5.8.11

2024-04-23 Thread Priyanshi Shah (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priyanshi Shah updated ATLAS-4854:
--
Description: Upgrading spring security from 5.8.5 to 5.8.11

> Atlas - Upgrade Spring Security to 5.8.11
> -
>
> Key: ATLAS-4854
> URL: https://issues.apache.org/jira/browse/ATLAS-4854
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Priyanshi Shah
>Assignee: Priyanshi Shah
>Priority: Major
> Fix For: 3.0.0
>
>
> Upgrading spring security from 5.8.5 to 5.8.11



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (ATLAS-4854) Atlas - Upgrade Spring Security to 5.8.11

2024-04-23 Thread Priyanshi Shah (Jira) 
Priyanshi Shah created ATLAS-4854:
-

 Summary: Atlas - Upgrade Spring Security to 5.8.11
 Key: ATLAS-4854
 URL: https://issues.apache.org/jira/browse/ATLAS-4854
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Reporter: Priyanshi Shah
 Fix For: 3.0.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (ATLAS-4854) Atlas - Upgrade Spring Security to 5.8.11

2024-04-23 Thread Priyanshi Shah (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priyanshi Shah reassigned ATLAS-4854:
-

Assignee: Priyanshi Shah

> Atlas - Upgrade Spring Security to 5.8.11
> -
>
> Key: ATLAS-4854
> URL: https://issues.apache.org/jira/browse/ATLAS-4854
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Priyanshi Shah
>Assignee: Priyanshi Shah
>Priority: Major
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ATLAS-4844) Atlas - Upgrade Common Configuration2 to 2.10.1

2024-04-23 Thread Priyanshi Shah (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priyanshi Shah updated ATLAS-4844:
--
Due Date: (was: 2/Apr/24)

> Atlas - Upgrade Common Configuration2 to 2.10.1
> ---
>
> Key: ATLAS-4844
> URL: https://issues.apache.org/jira/browse/ATLAS-4844
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Priyanshi Shah
>Assignee: Priyanshi Shah
>Priority: Major
>
> Upgrading common configurations2 from 2.8.0 to 2.10.1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)