[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598761#comment-16598761 ] ASF subversion and git services commented on ATLAS-2724: Commit 27be0da52cef2ed268442d140527d3a00083c3e7 in atlas's branch refs/heads/branch-1.0 from kevalbhatt [ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=27be0da ] ATLAS-2724 : UI enhancement for Avro schemas and other JSON-valued attributes > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Keval Bhatt >Priority: Critical > Fix For: 0.8.3, 1.1.0, 2.0.0 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, > ATLAS-2724-master.patch, ATLAS-2724.patch, new_table.png > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593833#comment-16593833 ] Barbara Eckman commented on ATLAS-2724: --- Thanks, [~kevalbhatt]!! > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Keval Bhatt >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, > ATLAS-2724-master.patch, ATLAS-2724.patch, new_table.png > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593346#comment-16593346 ] ASF subversion and git services commented on ATLAS-2724: Commit df4f87d0956fa5ae3c0097b1abb8ab4dc30df82c in atlas's branch refs/heads/branch-0.8 from kevalbhatt [ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=df4f87d ] ATLAS-2724 : UI enhancement for Avro schemas and other JSON-valued attributes > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Keval Bhatt >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, > ATLAS-2724-master.patch, ATLAS-2724.patch, new_table.png > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593343#comment-16593343 ] ASF subversion and git services commented on ATLAS-2724: Commit 37c753bdde22b6d9307855a13ad79d8deeece936 in atlas's branch refs/heads/master from kevalbhatt [ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=37c753b ] ATLAS-2724 : UI enhancement for Avro schemas and other JSON-valued attributes > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Keval Bhatt >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, > ATLAS-2724-master.patch, ATLAS-2724.patch, new_table.png > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591767#comment-16591767 ] Barbara Eckman commented on ATLAS-2724: --- [~kevalbhatt] sure, let's go with [^ATLAS-2724.patch] . We can always revisit in future to tweak or add new features. Thanks a lot! > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Barbara Eckman >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, > ATLAS-2724-master.patch, ATLAS-2724.patch, new_table.png > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589771#comment-16589771 ] Keval Bhatt commented on ATLAS-2724: [~barbara] [^ATLAS-2724.patch] this patch will support map and structs but if JSON object key has value as JSON-valued strings then it won't parse the value. Regarding arrays cutoff, there is no mechanism written to check the array size and the cutoff accordingly because it is very hard to find the cutoff as array value size is not fixed. we can do one thing in the subsequent patch when box (pre tag) height is greater the 50px or any specified height then will add collapse button to it instead of having the sophisticated length check. > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Barbara Eckman >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, > ATLAS-2724-master.patch, ATLAS-2724.patch, new_table.png > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586309#comment-16586309 ] Barbara Eckman commented on ATLAS-2724: --- [~kevalbhatt] Sorry the patch didn't apply on branch-0.8. Must have been an oversight. Does your version work on maps and structs as well as JSON-valued strings? Looks like it would, and we would LOVE that. I'm not sure about applying it to arrays, though. I think by default most users would want to see all columns of a hive table, for example, without having to scroll through. Though we do have some RDBMS tables with over 100 columns, and collapsing them makes a lot of sense. Perhaps for arrays the cutoff shouldn't be 1 but something like 10? What are your thoughts on this? > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Barbara Eckman >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, > ATLAS-2724-master.patch, ATLAS-2724.patch, new_table.png > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583875#comment-16583875 ] Keval Bhatt commented on ATLAS-2724: [~barbara] I have updated the patch since it didn't apply on branch-0.8. I have made few improvements to render JSON in colour format please check the attached screenshot. Please review. *Note*: Please take the latest update on branch-0.8 and apply the new patch. > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Barbara Eckman >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch, > ATLAS-2724.patch, new_table.png > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582608#comment-16582608 ] Keval Bhatt commented on ATLAS-2724: Thanks [~barbara] I will review the patch in a day or two > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Barbara Eckman >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580339#comment-16580339 ] Barbara Eckman commented on ATLAS-2724: --- [~kevalbhatt] I just uploaded the patch file, developed by [~tstefanovicz] > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Barbara Eckman >Priority: Critical > Fix For: 0.8.3 > > Attachments: 0001-Add-pretty-printed-json-values-in-tables.patch > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564344#comment-16564344 ] Barbara Eckman commented on ATLAS-2724: --- [~kevalbhatt] Hi, we're working on it this sprint. Sorry for the delay. Q2 deliverables and Q3 planning got in the way. > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating >Reporter: Barbara Eckman >Assignee: Barbara Eckman >Priority: Critical > Fix For: 0.8.3 > > Attachments: atlas0_8UIChanges.tar > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2724) UI enhancement for Avro schemas and other JSON-valued attributes
[ https://issues.apache.org/jira/browse/ATLAS-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563679#comment-16563679 ] Keval Bhatt commented on ATLAS-2724: [~barbara] can you please provide the patch for this enhancement. > UI enhancement for Avro schemas and other JSON-valued attributes > > > Key: ATLAS-2724 > URL: https://issues.apache.org/jira/browse/ATLAS-2724 > Project: Atlas > Issue Type: New Feature >Reporter: Barbara Eckman >Assignee: Barbara Eckman >Priority: Critical > Fix For: 0.8.3 > > Attachments: atlas0_8UIChanges.tar > > > Currently JSON-valued attributes are fully displayed in-line with other > attributes, not pretty-printed, cluttering the display. To support a better > display, we can display JSON-valued attributes in a one-line box that can be > scrolled down, or fully expanded with a mouse click that pretty-prints the > JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
