[jira] [Commented] (ATLAS-2836) Remove redundant encoding of vertex property keys
[ https://issues.apache.org/jira/browse/ATLAS-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593231#comment-16593231 ] ASF subversion and git services commented on ATLAS-2836: Commit 250d932172291fe8c9a9e07afb634042f67b09e5 in atlas's branch refs/heads/branch-0.8 from [~mad...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=250d932 ] ATLAS-2836: Remove redundant encoding of vertex property keys ATLAS-2838: Replace GraphHelper.encodeProperty() with AtlasGraphUtilsV1.encodeProperty() (cherry picked from commit b6a664df305d18918ea84ec1351307fcefeec53c) (cherry picked from commit 0ed9f0e25d2b064bb7728b2d8481968ba4375ba2) > Remove redundant encoding of vertex property keys > - > > Key: ATLAS-2836 > URL: https://issues.apache.org/jira/browse/ATLAS-2836 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 1.0.0-alpha, 1.0.0 >Reporter: Sarath Subramanian >Assignee: Sarath Subramanian >Priority: Major > Fix For: 1.1.0 > > > JanusGraph has RESERVED characters which are restricted as property keys. > RESERVED_CHARS => *{ } "* > Atlas encodes them before writing to vertex/edge. Lot of duplicate encoding > is currently present. Encoding is costly operation and should be done only > once. This JIRA will refactor and remove duplicate encoding. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2836) Remove redundant encoding of vertex property keys
[ https://issues.apache.org/jira/browse/ATLAS-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593119#comment-16593119 ] ASF subversion and git services commented on ATLAS-2836: Commit 3483b71c7f13164ea8fbaf7e16050f503f2e460e in atlas's branch refs/heads/branch-1.0 from [~mad...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=3483b71 ] ATLAS-2836: Remove redundant encoding of vertex property keys - #2 (cherry picked from commit 9c45d2e8e88b8845330632ad2a164448c13840fd) > Remove redundant encoding of vertex property keys > - > > Key: ATLAS-2836 > URL: https://issues.apache.org/jira/browse/ATLAS-2836 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 1.0.0-alpha, 1.0.0 >Reporter: Sarath Subramanian >Assignee: Sarath Subramanian >Priority: Major > Fix For: 1.1.0 > > > JanusGraph has RESERVED characters which are restricted as property keys. > RESERVED_CHARS => *{ } "* > Atlas encodes them before writing to vertex/edge. Lot of duplicate encoding > is currently present. Encoding is costly operation and should be done only > once. This JIRA will refactor and remove duplicate encoding. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2836) Remove redundant encoding of vertex property keys
[ https://issues.apache.org/jira/browse/ATLAS-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593116#comment-16593116 ] ASF subversion and git services commented on ATLAS-2836: Commit 9c45d2e8e88b8845330632ad2a164448c13840fd in atlas's branch refs/heads/master from [~mad...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=9c45d2e ] ATLAS-2836: Remove redundant encoding of vertex property keys - #2 > Remove redundant encoding of vertex property keys > - > > Key: ATLAS-2836 > URL: https://issues.apache.org/jira/browse/ATLAS-2836 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 1.0.0-alpha, 1.0.0 >Reporter: Sarath Subramanian >Assignee: Sarath Subramanian >Priority: Major > Fix For: 1.1.0 > > > JanusGraph has RESERVED characters which are restricted as property keys. > RESERVED_CHARS => *{ } "* > Atlas encodes them before writing to vertex/edge. Lot of duplicate encoding > is currently present. Encoding is costly operation and should be done only > once. This JIRA will refactor and remove duplicate encoding. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2836) Remove redundant encoding of vertex property keys
[ https://issues.apache.org/jira/browse/ATLAS-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592248#comment-16592248 ] ASF subversion and git services commented on ATLAS-2836: Commit bcf904d8d4b762b78bd5e150e7e76845434c8525 in atlas's branch refs/heads/branch-1.0 from [~sarath.ku...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=bcf904d ] ATLAS-2836: Remove redundant encoding of vertex property keys (cherry picked from commit b6a664df305d18918ea84ec1351307fcefeec53c) > Remove redundant encoding of vertex property keys > - > > Key: ATLAS-2836 > URL: https://issues.apache.org/jira/browse/ATLAS-2836 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 1.0.0-alpha, 1.0.0 >Reporter: Sarath Subramanian >Assignee: Sarath Subramanian >Priority: Major > Fix For: 1.1.0 > > > JanusGraph has RESERVED characters which are restricted as property keys. > RESERVED_CHARS => *{ } "* > Atlas encodes them before writing to vertex/edge. Lot of duplicate encoding > is currently present. Encoding is costly operation and should be done only > once. This JIRA will refactor and remove duplicate encoding. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2836) Remove redundant encoding of vertex property keys
[ https://issues.apache.org/jira/browse/ATLAS-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592232#comment-16592232 ] ASF subversion and git services commented on ATLAS-2836: Commit b6a664df305d18918ea84ec1351307fcefeec53c in atlas's branch refs/heads/master from [~sarath.ku...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=b6a664d ] ATLAS-2836: Remove redundant encoding of vertex property keys > Remove redundant encoding of vertex property keys > - > > Key: ATLAS-2836 > URL: https://issues.apache.org/jira/browse/ATLAS-2836 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 1.0.0-alpha, 1.0.0 >Reporter: Sarath Subramanian >Assignee: Sarath Subramanian >Priority: Major > Fix For: 1.1.0 > > > JanusGraph has RESERVED characters which are restricted as property keys. > RESERVED_CHARS => *{ } "* > Atlas encodes them before writing to vertex/edge. Lot of duplicate encoding > is currently present. Encoding is costly operation and should be done only > once. This JIRA will refactor and remove duplicate encoding. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2836) Remove redundant encoding of vertex property keys
[ https://issues.apache.org/jira/browse/ATLAS-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590750#comment-16590750 ] Sarath Subramanian commented on ATLAS-2836: --- Code Review: https://reviews.apache.org/r/68492/ > Remove redundant encoding of vertex property keys > - > > Key: ATLAS-2836 > URL: https://issues.apache.org/jira/browse/ATLAS-2836 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 1.0.0-alpha, 1.0.0 >Reporter: Sarath Subramanian >Assignee: Sarath Subramanian >Priority: Major > Fix For: 1.1.0 > > > JanusGraph has RESERVED characters which are restricted as property keys. > RESERVED_CHARS = { '{' , '}', '"' }; > Atlas encodes them before writing to vertex/edge. Lot of duplicate encoding > is currently present. Encoding is costly operation and should be done only > once. This JIRA will refactor and remove duplicate encoding. -- This message was sent by Atlassian JIRA (v7.6.3#76005)