Re: Review Request 66936: ATLAS-2521: Remove Titan 0.5.4 support from Atlas

2018-05-03 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66936/#review202381
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 3, 2018, 7:06 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66936/
> ---
> 
> (Updated May 3, 2018, 7:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2521
> https://issues.apache.org/jira/browse/ATLAS-2521
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Now that Atlas is using JanusGraph as the backend store and all new features 
> developed depends on TinkerPop3 queries and enhanced capabilities of 
> JanusGraph, I propose we remove support for Titan 0.5.4 in Atlas.
> 
> 
> Diffs
> -
> 
>   addons/falcon-bridge-shim/pom.xml e2c41b3a 
>   addons/falcon-bridge/pom.xml 53f6d368 
>   addons/falcon-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/falcon-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hbase-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/hbase-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml fe34bb8d 
>   addons/hive-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hive-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/sqoop-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/sqoop-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/storm-bridge/src/test/resources/atlas-application.properties 
> 5e3836ba 
>   addons/storm-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   authorization/src/test/resources/atlas-application.properties 2e02678a 
>   build-tools/src/main/resources/checkstyle-suppressions.xml bf16a9dd 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 0cef5f2e 
>   common/src/test/resources/atlas-log4j.xml 8a1de629 
>   distro/pom.xml 9f6f2bdc 
>   distro/src/conf/atlas-env.sh 9213f488 
>   distro/src/conf/atlas-log4j.xml a0f96296 
>   distro/src/conf/solr/schema.xml 1d445b15 
>   distro/src/conf/solr/solrconfig.xml 1d414f76 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
>  d6806541 
>   graphdb/janus/readme.txt fb935be2 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  86cd2990 
>   graphdb/pom.xml cef77c94 
>   graphdb/readme.txt 92edd002 
>   graphdb/titan0/pom.xml dc840581 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/AdminMask.java
>  e255f1b6 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/ConnectionMask.java
>  feb578bd 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin0_98.java
>  0cd47950 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin1_0.java
>  7e8f72d1 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java
>  c1af7b66 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat0_98.java
>  2c0f3b4b 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_0.java
>  bb3fb3b0 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_1.java
>  e5c3d31c 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java
>  4d61b608 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java
>  d454f379 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java
>  4bdd3204 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseTransaction.java
>  e13593fa 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection0_98.java
>  86606447 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection1_0.java
>  91e50266 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable0_98.java
>  b11532ac 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable1_0.java
>  5c90617c 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/TableMask.java
>  54f87434 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java
>  95669af3 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java
>  90d24e4d 
>   
>

Re: Review Request 66936: ATLAS-2521: Remove Titan 0.5.4 support from Atlas

2018-05-03 Thread Sarath Subramanian 


> On May 3, 2018, 1:01 p.m., Madhan Neethiraj wrote:
> > tools/atlas-migration-exporter/pom.xml
> > Line 37 (original)
> > 
> >
> > migration-exporter needs to read data in previous Atlas release, which 
> > uses titan-0.5.4. So, I think almost all changes to 
> > atlas-migration-exporter module need to be reverted.
> > 
> > Please make sure that references to Titan are restricted to 
> > atlas-migration-exporter module.

there is a reference to atlas-titan0-graphdb in the pom.xml of 
atlas-migration-exporter. I'm removing it now and Ashutosh will fix titan0 
dependency in a follow up patch.


- Sarath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66936/#review202371
---


On May 3, 2018, 12:06 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66936/
> ---
> 
> (Updated May 3, 2018, 12:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2521
> https://issues.apache.org/jira/browse/ATLAS-2521
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Now that Atlas is using JanusGraph as the backend store and all new features 
> developed depends on TinkerPop3 queries and enhanced capabilities of 
> JanusGraph, I propose we remove support for Titan 0.5.4 in Atlas.
> 
> 
> Diffs
> -
> 
>   addons/falcon-bridge-shim/pom.xml e2c41b3a 
>   addons/falcon-bridge/pom.xml 53f6d368 
>   addons/falcon-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/falcon-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hbase-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/hbase-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml fe34bb8d 
>   addons/hive-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hive-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/sqoop-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/sqoop-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/storm-bridge/src/test/resources/atlas-application.properties 
> 5e3836ba 
>   addons/storm-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   authorization/src/test/resources/atlas-application.properties 2e02678a 
>   build-tools/src/main/resources/checkstyle-suppressions.xml bf16a9dd 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 0cef5f2e 
>   common/src/test/resources/atlas-log4j.xml 8a1de629 
>   distro/pom.xml 9f6f2bdc 
>   distro/src/conf/atlas-env.sh 9213f488 
>   distro/src/conf/atlas-log4j.xml a0f96296 
>   distro/src/conf/solr/schema.xml 1d445b15 
>   distro/src/conf/solr/solrconfig.xml 1d414f76 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
>  d6806541 
>   graphdb/janus/readme.txt fb935be2 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  86cd2990 
>   graphdb/pom.xml cef77c94 
>   graphdb/readme.txt 92edd002 
>   graphdb/titan0/pom.xml dc840581 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/AdminMask.java
>  e255f1b6 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/ConnectionMask.java
>  feb578bd 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin0_98.java
>  0cd47950 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin1_0.java
>  7e8f72d1 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java
>  c1af7b66 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat0_98.java
>  2c0f3b4b 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_0.java
>  bb3fb3b0 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_1.java
>  e5c3d31c 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java
>  4d61b608 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java
>  d454f379 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java
>  4bdd3204 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseTransaction.java
>  e13593fa 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection0_98.java
>  86606447 
>

Re: Review Request 66936: ATLAS-2521: Remove Titan 0.5.4 support from Atlas

2018-05-03 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66936/#review202371
---




tools/atlas-migration-exporter/pom.xml
Line 37 (original)


migration-exporter needs to read data in previous Atlas release, which uses 
titan-0.5.4. So, I think almost all changes to atlas-migration-exporter module 
need to be reverted.

Please make sure that references to Titan are restricted to 
atlas-migration-exporter module.


- Madhan Neethiraj


On May 3, 2018, 7:06 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66936/
> ---
> 
> (Updated May 3, 2018, 7:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2521
> https://issues.apache.org/jira/browse/ATLAS-2521
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Now that Atlas is using JanusGraph as the backend store and all new features 
> developed depends on TinkerPop3 queries and enhanced capabilities of 
> JanusGraph, I propose we remove support for Titan 0.5.4 in Atlas.
> 
> 
> Diffs
> -
> 
>   addons/falcon-bridge-shim/pom.xml e2c41b3a 
>   addons/falcon-bridge/pom.xml 53f6d368 
>   addons/falcon-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/falcon-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hbase-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/hbase-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml fe34bb8d 
>   addons/hive-bridge/src/test/resources/atlas-application.properties 91fd8b09 
>   addons/hive-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/sqoop-bridge/src/test/resources/atlas-application.properties 
> 91fd8b09 
>   addons/sqoop-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   addons/storm-bridge/src/test/resources/atlas-application.properties 
> 5e3836ba 
>   addons/storm-bridge/src/test/resources/atlas-log4j.xml a0f96296 
>   authorization/src/test/resources/atlas-application.properties 2e02678a 
>   build-tools/src/main/resources/checkstyle-suppressions.xml bf16a9dd 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 0cef5f2e 
>   common/src/test/resources/atlas-log4j.xml 8a1de629 
>   distro/pom.xml 9f6f2bdc 
>   distro/src/conf/atlas-env.sh 9213f488 
>   distro/src/conf/atlas-log4j.xml a0f96296 
>   distro/src/conf/solr/schema.xml 1d445b15 
>   distro/src/conf/solr/solrconfig.xml 1d414f76 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
>  d6806541 
>   graphdb/janus/readme.txt fb935be2 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  86cd2990 
>   graphdb/pom.xml cef77c94 
>   graphdb/readme.txt 92edd002 
>   graphdb/titan0/pom.xml dc840581 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/AdminMask.java
>  e255f1b6 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/ConnectionMask.java
>  feb578bd 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin0_98.java
>  0cd47950 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin1_0.java
>  7e8f72d1 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java
>  c1af7b66 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat0_98.java
>  2c0f3b4b 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_0.java
>  bb3fb3b0 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_1.java
>  e5c3d31c 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java
>  4d61b608 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java
>  d454f379 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java
>  4bdd3204 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseTransaction.java
>  e13593fa 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection0_98.java
>  86606447 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection1_0.java
>  91e50266 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable0_98.java
>  b11532ac 
>   
>