Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/#review219902
---


Ship it!




Ship It!

- Sarath Subramanian


On March 11, 2020, 1:23 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72223/
> ---
> 
> (Updated March 11, 2020, 1:23 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth 
> Mishra, and Umesh Padashetty.
> 
> 
> Bugs: ATLAS-3660
> https://issues.apache.org/jira/browse/ATLAS-3660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added model for ADLS-Gen2
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72223/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Madhan Neethiraj]

> On March 11, 2020, 8:36 p.m., Sarath Subramanian wrote:
> > addons/models/3000-Cloud/3040-azure_adls_typedefs.json
> > Lines 414 (patched)
> > 
> >
> > propagation turned ON by default? if account contains lot of container. 
> > 
> > account -> countainers and parent -> children

Yes, this is intentional. Having propagation ON is crucial to ensure that 
classifications at container/directory are considered while authorizing acceess 
to sub-dir/files. Atlas is likely to have only subset of ADLS-Gen2 entities 
i.e. which are part of data lineage with other entities, like hive_table. In 
such use, having propagation ON should not cause performance concerns.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/#review219898
---


On March 11, 2020, 8:23 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72223/
> ---
> 
> (Updated March 11, 2020, 8:23 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth 
> Mishra, and Umesh Padashetty.
> 
> 
> Bugs: ATLAS-3660
> https://issues.apache.org/jira/browse/ATLAS-3660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added model for ADLS-Gen2
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72223/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/#review219898
---




addons/models/3000-Cloud/3040-azure_adls_typedefs.json
Lines 414 (patched)


propagation turned ON by default? if account contains lot of container. 

account -> countainers and parent -> children


- Sarath Subramanian


On March 11, 2020, 1:23 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72223/
> ---
> 
> (Updated March 11, 2020, 1:23 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth 
> Mishra, and Umesh Padashetty.
> 
> 
> Bugs: ATLAS-3660
> https://issues.apache.org/jira/browse/ATLAS-3660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added model for ADLS-Gen2
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72223/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72223: ATLAS-3660: added model for ADLS-Gen2

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72223/#review219897
---


Ship it!




Ship It!

- Sarath Subramanian


On March 11, 2020, 1:23 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72223/
> ---
> 
> (Updated March 11, 2020, 1:23 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, Pinal Shah, Sarath Subramanian, Sharmadha Sainath, Sidharth 
> Mishra, and Umesh Padashetty.
> 
> 
> Bugs: ATLAS-3660
> https://issues.apache.org/jira/browse/ATLAS-3660
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added model for ADLS-Gen2
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3040-azure_adls_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72223/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>