Re: Review Request 73671: ATLAS-4463: Infinite loop at Index Health Monitor (IndexRecoveryService)

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73671/#review223688
---


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 28, 2021, 2:32 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73671/
> ---
> 
> (Updated Oct. 28, 2021, 2:32 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4463
> https://issues.apache.org/jira/browse/ATLAS-4463
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4463: Fixed Infinite loop at Index Health Monitor (IndexRecoveryService)
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java
>  2f1161067 
> 
> 
> Diff: https://reviews.apache.org/r/73671/diff/2/
> 
> 
> Testing
> ---
> 
> Run local UT/ITs and Manually ran jetty run and some IT to see the loop is 
> exiting at the end
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73671: ATLAS-4463: Infinite loop at Index Health Monitor (IndexRecoveryService)

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73671/#review223686
---


Ship it!




Ship It!

- Ashutosh Mestry


On Oct. 28, 2021, 9:32 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73671/
> ---
> 
> (Updated Oct. 28, 2021, 9:32 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4463
> https://issues.apache.org/jira/browse/ATLAS-4463
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4463: Fixed Infinite loop at Index Health Monitor (IndexRecoveryService)
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java
>  2f1161067 
> 
> 
> Diff: https://reviews.apache.org/r/73671/diff/2/
> 
> 
> Testing
> ---
> 
> Run local UT/ITs and Manually ran jetty run and some IT to see the loop is 
> exiting at the end
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73671: ATLAS-4463: Infinite loop at Index Health Monitor (IndexRecoveryService)

[Sidharth Mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73671/
---

(Updated Oct. 28, 2021, 9:32 p.m.)


Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4463
https://issues.apache.org/jira/browse/ATLAS-4463


Repository: atlas


Description
---

ATLAS-4463: Fixed Infinite loop at Index Health Monitor (IndexRecoveryService)


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java
 2f1161067 


Diff: https://reviews.apache.org/r/73671/diff/2/

Changes: https://reviews.apache.org/r/73671/diff/1-2/


Testing
---

Run local UT/ITs and Manually ran jetty run and some IT to see the loop is 
exiting at the end


Thanks,

Sidharth Mishra

Re: Review Request 73671: ATLAS-4463: Infinite loop at Index Health Monitor (IndexRecoveryService)

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73671/#review223684
---


Fix it, then Ship it!




Fix it, then Ship it!


repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java
Lines 185 (patched)


Use:

try {
LOG.info("==> Index Health Monitor: Shutdown: Starting...");

// handle the case where thread was not started at all
// and shutdown called
if (shouldRun.get() == false) {
return;
}

shouldRun.set(false);
}
finally {
LOG.info("<== Index Health Monitor: Shutdown: Done!");
}


- Ashutosh Mestry


On Oct. 28, 2021, 9:21 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73671/
> ---
> 
> (Updated Oct. 28, 2021, 9:21 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4463
> https://issues.apache.org/jira/browse/ATLAS-4463
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4463: Fixed Infinite loop at Index Health Monitor (IndexRecoveryService)
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java
>  2f1161067 
> 
> 
> Diff: https://reviews.apache.org/r/73671/diff/1/
> 
> 
> Testing
> ---
> 
> Run local UT/ITs and Manually ran jetty run and some IT to see the loop is 
> exiting at the end
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>