Re: Review Request 74545: ATLAS-4783: Fix NoSuchElementException when running different indexing backend than Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74545/#review225737 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 17, 2023, 8:49 a.m., Szymon Orzechowski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74545/ > --- > > (Updated Aug. 17, 2023, 8:49 a.m.) > > > Review request for atlas, Madhan Neethiraj, Pinal Shah, Prasad Pawar, and > Radhika Kundam. > > > Bugs: ATLAS-4783 > https://issues.apache.org/jira/browse/ATLAS-4783 > > > Repository: atlas > > > Description > --- > > Elasticsearch is in tech preview as an alternative to Solr as indexing > backend. However current Atlas code causes NoSuchElementException when > property atlas.graph.index.search.solr.wait-searcher is not set. This however > shouldn't be a requirement when not using Solr. This patch fixes that. > > > Diffs > - > > intg/src/main/java/org/apache/atlas/ApplicationProperties.java f83dff699 > > > Diff: https://reviews.apache.org/r/74545/diff/1/ > > > Testing > --- > > Ran mvn clean test and tested on my cluster with Elasticsearch > > > Thanks, > > Szymon Orzechowski > >
Re: Review Request 74545: ATLAS-4783: Fix NoSuchElementException when running different indexing backend than Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74545/#review225659 --- Ship it! Ship It! - Pinal Shah On Aug. 17, 2023, 8:49 a.m., Szymon Orzechowski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74545/ > --- > > (Updated Aug. 17, 2023, 8:49 a.m.) > > > Review request for atlas, Madhan Neethiraj, Pinal Shah, Prasad Pawar, and > Radhika Kundam. > > > Bugs: ATLAS-4783 > https://issues.apache.org/jira/browse/ATLAS-4783 > > > Repository: atlas > > > Description > --- > > Elasticsearch is in tech preview as an alternative to Solr as indexing > backend. However current Atlas code causes NoSuchElementException when > property atlas.graph.index.search.solr.wait-searcher is not set. This however > shouldn't be a requirement when not using Solr. This patch fixes that. > > > Diffs > - > > intg/src/main/java/org/apache/atlas/ApplicationProperties.java f83dff699 > > > Diff: https://reviews.apache.org/r/74545/diff/1/ > > > Testing > --- > > Ran mvn clean test and tested on my cluster with Elasticsearch > > > Thanks, > > Szymon Orzechowski > >
