Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-30 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/#review179336
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 30, 2017, 6:27 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60159/
> ---
> 
> (Updated June 30, 2017, 6:27 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1880
> https://issues.apache.org/jira/browse/ATLAS-1880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> See JIRA
> 
> 
> Sample Request structure
> 
> ```json
> {
>   "typeName": "hive_table",
>   "excludeDeletedEntities": false,
>   "limit": 25,
>   "offset": 0,
>   "entityFilters": {
>   "condition": "AND",
>   "criterion": [{
>   "attributeName": "retention",
>   "operator": "=",
>   "attributeValue": "10"
>   }, {
>   "condition": "OR",
>   "criterion": [{
>   "attributeName": "createTime",
>   "operator": ">",
>   "attributeValue": "11"
>   }, {
>   "attributeName": "lastAccessTime",
>   "operator": "<=",
>   "attributeValue": "22"
>   }]
>   }]
>   }
> }
> ```
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 
>   common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 
>   distro/src/conf/atlas-log4j.xml e6c0d9f6 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  841edf71 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  1ff9d5ed 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  53f490f5 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
>  0211ff05 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  0077a21f 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java
>  68f0eb28 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java
>  24e4f5bc 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java
>  54ff7cb7 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
>  1ed1734f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
>  bd8b897f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
>  7ec6ffeb 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
>  4073dd2a 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
>  4452bcdd 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
>  1ca900d8 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> a402c628 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
> 21b64273 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  923a198b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  128cdbf9 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
> b07091a0 
>   repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  35dbf6c4 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
>  3411f8de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  42bd58fb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  9a8695af 
>

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-28 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/
---

(Updated June 29, 2017, 3:05 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Suma Shivaprasad.


Changes
---

1. Removed status active check for TAG
2. On type change the vertex index keys should be refreshed
3. Fixed the OR condition gremlin query generation


Bugs: ATLAS-1880
https://issues.apache.org/jira/browse/ATLAS-1880


Repository: atlas


Description
---

See JIRA


Sample Request structure

```json
{
"typeName": "hive_table",
"excludeDeletedEntities": false,
"limit": 25,
"offset": 0,
"entityFilters": {
"condition": "AND",
"criterion": [{
"attributeName": "retention",
"operator": "=",
"attributeValue": "10"
}, {
"condition": "OR",
"criterion": [{
"attributeName": "createTime",
"operator": ">",
"attributeValue": "11"
}, {
"attributeName": "lastAccessTime",
"operator": "<=",
"attributeValue": "22"
}]
}]
}
}
```


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 
  common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 
  distro/src/conf/atlas-log4j.xml e6c0d9f6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 841edf71 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 1ff9d5ed 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
 53f490f5 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
 0211ff05 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
 0077a21f 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java
 68f0eb28 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java
 24e4f5bc 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
 1ed1734f 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
 bd8b897f 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
 7ec6ffeb 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
 4073dd2a 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
 4452bcdd 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
 1ca900d8 
  intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
a402c628 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
21b64273 
  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
923a198b 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
128cdbf9 
  repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 35dbf6c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
3411f8de 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
 42bd58fb 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 9a8695af 
  repository/src/main/java/org/apache/atlas/util/SearchTracker.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/TestModules.java fa2ac0d8 
  
repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
 5d5b043e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
8c5623fa 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ea550211 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
1fe31198 


Diff: https://reviews.apache.org/r/60159/diff/10/

Changes: https://reviews.apache.org/r/60159/diff/9-10/


Testing
---

1. Tested Json

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-28 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/#review179179
---




graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
Lines 175 (patched)


This should be offset + limit


- Apoorv Naik


On June 28, 2017, 9:18 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60159/
> ---
> 
> (Updated June 28, 2017, 9:18 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1880
> https://issues.apache.org/jira/browse/ATLAS-1880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> See JIRA
> 
> 
> Sample Request structure
> 
> ```json
> {
>   "typeName": "hive_table",
>   "excludeDeletedEntities": false,
>   "limit": 25,
>   "offset": 0,
>   "entityFilters": {
>   "condition": "AND",
>   "criterion": [{
>   "attributeName": "retention",
>   "operator": "=",
>   "attributeValue": "10"
>   }, {
>   "condition": "OR",
>   "criterion": [{
>   "attributeName": "createTime",
>   "operator": ">",
>   "attributeValue": "11"
>   }, {
>   "attributeName": "lastAccessTime",
>   "operator": "<=",
>   "attributeValue": "22"
>   }]
>   }]
>   }
> }
> ```
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 
>   common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 
>   distro/src/conf/atlas-log4j.xml e6c0d9f6 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  841edf71 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  1ff9d5ed 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  53f490f5 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
>  0211ff05 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  0077a21f 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java
>  68f0eb28 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java
>  24e4f5bc 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
>  1ed1734f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
>  bd8b897f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
>  7ec6ffeb 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
>  4073dd2a 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
>  4452bcdd 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
>  1ca900d8 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> a402c628 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
> 21b64273 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  923a198b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  128cdbf9 
>   repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
>  3411f8de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  42bd58fb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  9a8695af 
>   repository/src/main/java/org/apache/atlas/util/SearchContextContainer.java 
> PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/TestModules.java fa2ac0d8 
>   
>

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-28 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/
---

(Updated June 28, 2017, 1:52 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Suma Shivaprasad.


Changes
---

Latest rebase


Bugs: ATLAS-1880
https://issues.apache.org/jira/browse/ATLAS-1880


Repository: atlas


Description
---

See JIRA


Sample Request structure

```json
{
"typeName": "hive_table",
"excludeDeletedEntities": false,
"limit": 25,
"offset": 0,
"entityFilters": {
"condition": "AND",
"criterion": [{
"attributeName": "retention",
"operator": "=",
"attributeValue": "10"
}, {
"condition": "OR",
"criterion": [{
"attributeName": "createTime",
"operator": ">",
"attributeValue": "11"
}, {
"attributeName": "lastAccessTime",
"operator": "<=",
"attributeValue": "22"
}]
}]
}
}
```


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 
  common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 
  distro/src/conf/atlas-log4j.xml e6c0d9f6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 841edf71 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 1ff9d5ed 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
 53f490f5 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
 0211ff05 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
 0077a21f 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java
 68f0eb28 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java
 24e4f5bc 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
 1ed1734f 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
 bd8b897f 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
 7ec6ffeb 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
 4073dd2a 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
 4452bcdd 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
 1ca900d8 
  intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
a402c628 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
21b64273 
  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
923a198b 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
128cdbf9 
  repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
3411f8de 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
 42bd58fb 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 9a8695af 
  repository/src/main/java/org/apache/atlas/util/SearchContextContainer.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/TestModules.java fa2ac0d8 
  
repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
 5d5b043e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
8c5623fa 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ea550211 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
1fe31198 


Diff: https://reviews.apache.org/r/60159/diff/7/

Changes: https://reviews.apache.org/r/60159/diff/6-7/


Testing
---

1. Tested Json marshalling and unmarshalling via REST
2. Tested with the attached request JSONs 

In progress

UTs (coding)


File Attachments


Asset contains

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-26 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/
---

(Updated June 26, 2017, 10:32 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Suma Shivaprasad.


Changes
---

There are some TODO items which need to be removed in the next round.


Bugs: ATLAS-1880
https://issues.apache.org/jira/browse/ATLAS-1880


Repository: atlas


Description
---

See JIRA


Sample Request structure

```json
{
"typeName": "hive_table",
"excludeDeletedEntities": false,
"limit": 25,
"offset": 0,
"entityFilters": {
"condition": "AND",
"criterion": [{
"attributeName": "retention",
"operator": "=",
"attributeValue": "10"
}, {
"condition": "OR",
"criterion": [{
"attributeName": "createTime",
"operator": ">",
"attributeValue": "11"
}, {
"attributeName": "lastAccessTime",
"operator": "<=",
"attributeValue": "22"
}]
}]
}
}
```


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 
  common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 
  distro/src/conf/atlas-log4j.xml e6c0d9f6 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
 841edf71 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
 1ff9d5ed 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
 53f490f5 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
 0211ff05 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
 0077a21f 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java
 68f0eb28 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java
 24e4f5bc 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
 1ed1734f 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
 bd8b897f 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
 7ec6ffeb 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
 4073dd2a 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
 4452bcdd 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
 1ca900d8 
  intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
a402c628 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
b19f7097 
  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
923a198b 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
128cdbf9 
  repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
4ffbb88c 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 75e91320 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
 00fe94b6 
  repository/src/main/java/org/apache/atlas/util/SearchContextContainer.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/TestModules.java d28956de 
  
repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
 5d5b043e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
8c5623fa 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ea550211 
  webapp/src/main/webapp/WEB-INF/web.xml 9b5c3b14 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
1fe31198 


Diff: https://reviews.apache.org/r/60159/diff/5/

Changes: https://reviews.apache.org/r/60159/diff/4-5/


Testing
---

1. Tested Json marshalling and unmarshalling via REST
2. Tested with the attached request JSONs 

In progress

UTs (coding)


File Attachments

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-21 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/#review178624
---




intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java
Lines 89 (patched)


Accidental change (will revert)



repository/src/main/java/org/apache/atlas/discovery/GremlinSearchStep.java
Lines 285 (patched)


Contains can be collapsed with LIKE and IN ???



repository/src/main/java/org/apache/atlas/discovery/SolrSearchStep.java
Lines 114 (patched)


Need better error handling here.



repository/src/main/java/org/apache/atlas/discovery/SolrSearchStep.java
Lines 118 (patched)


No need of these two if blocks



repository/src/main/java/org/apache/atlas/discovery/SolrSearchStep.java
Lines 126 (patched)


Might not be needed after latest nested query generation fix



webapp/src/main/webapp/WEB-INF/web.xml
Lines 36 (patched)


Accidental change


- Apoorv Naik


On June 22, 2017, 5:24 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60159/
> ---
> 
> (Updated June 22, 2017, 5:24 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1880
> https://issues.apache.org/jira/browse/ATLAS-1880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> See JIRA
> 
> 
> Sample Request structure
> 
> ```json
> {
>   "typeName": "hive_table",
>   "excludeDeletedEntities": false,
>   "limit": 25,
>   "offset": 0,
>   "entityFilters": {
>   "condition": "AND",
>   "criterion": [{
>   "attributeName": "retention",
>   "operator": "=",
>   "attributeValue": "10"
>   }, {
>   "condition": "OR",
>   "criterion": [{
>   "attributeName": "createTime",
>   "operator": ">",
>   "attributeValue": "11"
>   }, {
>   "attributeName": "lastAccessTime",
>   "operator": "<=",
>   "attributeValue": "22"
>   }]
>   }]
>   }
> }
> ```
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 
>   common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  841edf71 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  1ff9d5ed 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  53f490f5 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
>  0211ff05 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  0077a21f 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java
>  68f0eb28 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java
>  24e4f5bc 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
>  1ed1734f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
>  bd8b897f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
>  7ec6ffeb 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
>  4073dd2a 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
>  4452bcdd 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
>  1ca900d8 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> a402c628 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
> b19f7097 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  923a198b 
>   
>