Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

[Apoorv Naik]

> On July 19, 2017, 8:46 a.m., Graham Wallis wrote:
> > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java
> > Lines 29 (patched)
> > 
> >
> > Minor point but it would be nicer to name this parameter 'vertices' for 
> > consistency with other changes.

Will do.


> On July 19, 2017, 8:46 a.m., Graham Wallis wrote:
> > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0AtlasMultiVertexQuery.java
> > Lines 91 (patched)
> > 
> >
> > Trailing whitespace.

Will remove


> On July 19, 2017, 8:46 a.m., Graham Wallis wrote:
> > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java
> > Lines 80 (patched)
> > 
> >
> > I'm slightly worried because the multiQuery() method appears to be 
> > deprecated (in Titan 1.0.0). Presumably that suggests there is a better way 
> > to do this with Titan, although I'm not sure what. I suspect we need to 
> > construct the MVQ explicitly rather than pass the vertex or Collection to 
> > multiQuery().

I looked around for any updated document around the deprecation of this method 
but couldn't find one. Let's explore other options to ensure that we use the 
most up to date API.


> On July 19, 2017, 8:46 a.m., Graham Wallis wrote:
> > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java
> > Lines 396 (patched)
> > 
> >
> > Should this be accepting (and transforming) an edges parameter?

Good catch. I forgot to rename the parameter.


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60927/#review180908
---


On July 17, 2017, 10:31 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60927/
> ---
> 
> (Updated July 17, 2017, 10:31 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Initial draft for multi-vertex graph query in atlas
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> dded76f8 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanQueryFactory.java
>  ac7ff9e8 
>   graphdb/titan0/pom.xml ceda1bb2 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
>  2408287b 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
>  ffb6b37f 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  77b2c7c2 
> 
> 
> Diff: https://reviews.apache.org/r/60927/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

[Graham Wallis]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60927/#review180908
---




graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java
Lines 29 (patched)


Minor point but it would be nicer to name this parameter 'vertices' for 
consistency with other changes.



graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0AtlasMultiVertexQuery.java
Lines 91 (patched)


Trailing whitespace.



graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java
Lines 80 (patched)


I'm slightly worried because the multiQuery() method appears to be 
deprecated (in Titan 1.0.0). Presumably that suggests there is a better way to 
do this with Titan, although I'm not sure what. I suspect we need to construct 
the MVQ explicitly rather than pass the vertex or Collection to multiQuery().



graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java
Lines 396 (patched)


Should this be accepting (and transforming) an edges parameter?


- Graham Wallis


On July 17, 2017, 10:31 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60927/
> ---
> 
> (Updated July 17, 2017, 10:31 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Initial draft for multi-vertex graph query in atlas
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> dded76f8 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanQueryFactory.java
>  ac7ff9e8 
>   graphdb/titan0/pom.xml ceda1bb2 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
>  2408287b 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
>  ffb6b37f 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  77b2c7c2 
> 
> 
> Diff: https://reviews.apache.org/r/60927/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60927/#review180754
---




repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
Lines 184 (patched)


TODO: The multi-vertex query will be used here


- Apoorv Naik


On July 17, 2017, 10:31 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60927/
> ---
> 
> (Updated July 17, 2017, 10:31 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Initial draft for multi-vertex graph query in atlas
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> dded76f8 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanQueryFactory.java
>  ac7ff9e8 
>   graphdb/titan0/pom.xml ceda1bb2 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
>  2408287b 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
>  ffb6b37f 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  77b2c7c2 
> 
> 
> Diff: https://reviews.apache.org/r/60927/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60927/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Suma Shivaprasad.


Repository: atlas


Description
---

Initial draft for multi-vertex graph query in atlas


Diffs
-

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
dded76f8 
  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java
 PRE-CREATION 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanMultiVertexQuery.java
 PRE-CREATION 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanQueryFactory.java
 ac7ff9e8 
  graphdb/titan0/pom.xml ceda1bb2 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
 2408287b 
  
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0AtlasMultiVertexQuery.java
 PRE-CREATION 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
 ffb6b37f 
  
graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
 77b2c7c2 


Diff: https://reviews.apache.org/r/60927/diff/1/


Testing
---


Thanks,

Apoorv Naik