Re: Review Request 63502: Review request for the OMRS Connector API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- (Updated Nov. 2, 2017, 8:35 a.m.) Review request for atlas, David Radley and Madhan Neethiraj. Repository: atlas Description (updated) --- This is a request for review of the OMRS Connector API. The files of interest are: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/* omrs/src/main/java/org/apache/atlas/omrs/connectors/* omrs/src/main/java/org/apache/atlas/omrs/ffdc/* There is a patch connected to https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the code plus other code that is not ready for review. The OMRS Connector API depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095. There is some OMAS code in the patch that can be ignored. Diffs - om-fwk-gaf/pom.xml PRE-CREATION om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFCheckedException.java PRE-CREATION om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFErrorCode.java PRE-CREATION om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFRuntimeException.java PRE-CREATION om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md PRE-CREATION omas-assetconsumer/README.md PRE-CREATION omas-assetconsumer/pom.xml PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/AssetConsumerInterface.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerCheckedExceptionBase.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerErrorCode.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerRuntimeException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetNotReferenceableException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/ConnectionNameAmbiguousException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/README.md PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionGUIDException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionURLException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerREST.java PRE-CREATION omas-assetowner/pom.xml PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/ffdc/AssetOwnerErrorCode.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Endpoints.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Host.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Platform.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Server.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapabilities.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapability.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Servers.java PRE-CREATION omas-connectedasset/README.md PRE-CREATION omas-connectedasset/pom.xml PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ConnectedAssetInterface.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/client/ConnectedAsset.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetErrorCode.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetRuntimeException.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/README.md PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASConnectedAssetProperties.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAsset.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAssetProperties.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetREST.java PRE-CREATION omrs/README.md PRE-CREATION omrs/pom.xml PRE-CREATION
Review Request 63502: Review request for the OMRS Connector API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- Review request for atlas, David Radley and Madhan Neethiraj. Repository: atlas Description --- This is a request for review of the OMRS Connector API. The files of interest are: omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/* omrs/src/main/java/org/apache/atlas/omrs/connectors/* omrs/src/main/java/org/apache/atlas/omrs/ffdc/* There is a patch connected to https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the code plus other code that is not ready for review. The OMRS Connector API depends on the OCF. If the OCF is not included in the patch then see https://issues.apache.org/jira/browse/ATLAS-1095 Diffs - om-fwk-gaf/pom.xml PRE-CREATION om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFCheckedException.java PRE-CREATION om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFErrorCode.java PRE-CREATION om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFRuntimeException.java PRE-CREATION om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md PRE-CREATION omas-assetconsumer/README.md PRE-CREATION omas-assetconsumer/pom.xml PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/AssetConsumerInterface.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerCheckedExceptionBase.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerErrorCode.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerRuntimeException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetNotReferenceableException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/ConnectionNameAmbiguousException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/README.md PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionGUIDException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionURLException.java PRE-CREATION omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerREST.java PRE-CREATION omas-assetowner/pom.xml PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/ffdc/AssetOwnerErrorCode.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Endpoints.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Host.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Platform.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Server.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapabilities.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapability.java PRE-CREATION omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Servers.java PRE-CREATION omas-connectedasset/README.md PRE-CREATION omas-connectedasset/pom.xml PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ConnectedAssetInterface.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/client/ConnectedAsset.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetErrorCode.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetRuntimeException.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/README.md PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASConnectedAssetProperties.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAsset.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAssetProperties.java PRE-CREATION omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetREST.java PRE-CREATION omrs/README.md PRE-CREATION omrs/pom.xml PRE-CREATION omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnection.java PRE-CREATION
