Re: Review Request 68583: ATLAS-2844: added eventTime field in EntityNotificationV2

2018-08-31 Thread Apoorv Naik

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68583/#review208182
---


Ship it!




Ship It!

- Apoorv Naik


On Aug. 30, 2018, 10:52 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68583/
> ---
> 
> (Updated Aug. 30, 2018, 10:52 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Graham Wallis, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2844
> https://issues.apache.org/jira/browse/ATLAS-2844
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated EntityNotificationV2 with addition of 'eventTime' attribute. Here is 
> a sample notification message with this change:
> 
> {
>   "type":"ENTITY_NOTIFICATION_V2",
>   "entity": {"typeName":"hive_table",
>  "attributes":{"owner":"hive",
>"createTime":1535622192000,
>"qualifiedName":"test.testtbl2@cl1",
>"name":"testtbl2"},
>  "guid":"8bc1ba7b-3c76-4311-81ae-c05fd07d667b",
>  "status":"ACTIVE",
>  "displayText":"testtbl2"
>  },
>   "operationType":"ENTITY_CREATE",
>   "eventTime":1535622192647
> }
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/notification/EntityNotification.java
>  6cdae8925 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  c70011f24 
> 
> 
> Diff: https://reviews.apache.org/r/68583/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that the notification includes eventTime attribute - as shown above.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Review Request 68583: ATLAS-2844: added eventTime field in EntityNotificationV2

2018-08-30 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68583/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Graham Wallis, and 
Sarath Subramanian.


Bugs: ATLAS-2844
https://issues.apache.org/jira/browse/ATLAS-2844


Repository: atlas


Description
---

updated EntityNotificationV2 with addition of 'eventTime' attribute. Here is a 
sample notification message with this change:

{
  "type":"ENTITY_NOTIFICATION_V2",
  "entity": {"typeName":"hive_table",
 "attributes":{"owner":"hive",
   "createTime":1535622192000,
   "qualifiedName":"test.testtbl2@cl1",
   "name":"testtbl2"},
 "guid":"8bc1ba7b-3c76-4311-81ae-c05fd07d667b",
 "status":"ACTIVE",
 "displayText":"testtbl2"
 },
  "operationType":"ENTITY_CREATE",
  "eventTime":1535622192647
}


Diffs
-

  
intg/src/main/java/org/apache/atlas/model/notification/EntityNotification.java 
6cdae8925 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 c70011f24 


Diff: https://reviews.apache.org/r/68583/diff/1/


Testing
---

Verified that the notification includes eventTime attribute - as shown above.


Thanks,

Madhan Neethiraj