Re: Review Request 68743: ATLAS-2875: Implement clear attribute value transformer for Atlas Entity Transformer

2018-09-20 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68743/#review208806
---


Ship it!




There is a small change in sample JSON. I verified my scenarios. Looks good!

```
{
"options": {
"transformers": "[{\"conditions\":null, 
\"action\":{\"replicatedTo\":\"CLEAR:\",\"replicatedFrom\":\"CLEAR:\"}}, 
{\"conditions\":{\"__entity\":\"topLevel: \"}, 
\"action\":{\"__entity\":\"addClassification: replicated\"}}, 
{\"conditions\":{\"hdfs_path.clusterName\":\"EQUALS: 
cl1\"},\"action\":{\"hdfs_path.clusterName\":\"SET: clx\"}}]",
"replicatedFrom": "cl1"
}
}
```

- Ashutosh Mestry


On Sept. 20, 2018, 6:21 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68743/
> ---
> 
> (Updated Sept. 20, 2018, 6:21 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2875
> https://issues.apache.org/jira/browse/ATLAS-2875
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> curl -X POST -u admin:admin -H "Content-Type: multipart/form-data" -F 
> request=@importTransformer.json -F data=@/root/exportData.zip 
> http://localhost:21000/api/atlas/admin/import
> 
> 
> importTransformer1.json
> ---
> {
>   "options": {
> "transformers": "["{\"conditions\":null, 
> \"action\":{\"__entity.replicatedTo\":\"CLEAR:\",\"__entity.replicatedFrom\":\"CLEAR:\"}}"]",
>   }
> }
> 
> 
> importTransformer2.json
> ---
> {
>   "options": {
> "transformers": "["{\"conditions\":null, 
> \"action\":{\"replicatedTo\":\"CLEAR:\",\"replicatedFrom\":\"CLEAR:\"}}"]",
>   }
> }
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/entitytransform/Action.java ca5f3a8c8 
>   intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java 
> c1f286933 
>   intg/src/main/java/org/apache/atlas/entitytransform/Condition.java 
> d44f57509 
>   
> intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java
>  69fba1eaf 
> 
> 
> Diff: https://reviews.apache.org/r/68743/diff/2/
> 
> 
> Testing
> ---
> 
> TransformationHandlerTest.testEntityClearAttributesActionWithNoCondition()
> TransformationHandlerTest.testEntityClearAttributesActionWithNoTypeNameAndNoCondition()
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 68743: ATLAS-2875: Implement clear attribute value transformer for Atlas Entity Transformer

2018-09-20 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68743/
---

(Updated Sept. 20, 2018, 11:21 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Nixon Rodrigues.


Bugs: ATLAS-2875
https://issues.apache.org/jira/browse/ATLAS-2875


Repository: atlas


Description
---

curl -X POST -u admin:admin -H "Content-Type: multipart/form-data" -F 
request=@importTransformer.json -F data=@/root/exportData.zip 
http://localhost:21000/api/atlas/admin/import


importTransformer1.json
---
{
  "options": {
"transformers": "["{\"conditions\":null, 
\"action\":{\"__entity.replicatedTo\":\"CLEAR:\",\"__entity.replicatedFrom\":\"CLEAR:\"}}"]",
  }
}


importTransformer2.json
---
{
  "options": {
"transformers": "["{\"conditions\":null, 
\"action\":{\"replicatedTo\":\"CLEAR:\",\"replicatedFrom\":\"CLEAR:\"}}"]",
  }
}


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/entitytransform/Action.java ca5f3a8c8 
  intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java 
c1f286933 
  intg/src/main/java/org/apache/atlas/entitytransform/Condition.java d44f57509 
  
intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java
 69fba1eaf 


Diff: https://reviews.apache.org/r/68743/diff/2/

Changes: https://reviews.apache.org/r/68743/diff/1-2/


Testing
---

TransformationHandlerTest.testEntityClearAttributesActionWithNoCondition()
TransformationHandlerTest.testEntityClearAttributesActionWithNoTypeNameAndNoCondition()


Thanks,

Sarath Subramanian

Review Request 68743: ATLAS-2875: Implement clear attribute value transformer for Atlas Entity Transformer

2018-09-17 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68743/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Nixon Rodrigues.


Bugs: ATLAS-2875
https://issues.apache.org/jira/browse/ATLAS-2875


Repository: atlas


Description
---

Condition :  "hive_table.replicatedTo", "HAS_VALUE:"

Action   :  "hive_table.replicatedTo", "CLEAR:"

 

Condition :  null

Action   :  "hive_table.replicatedTo", "CLEAR:"


Diffs
-

  intg/src/main/java/org/apache/atlas/entitytransform/Action.java ca5f3a8c8 
  intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java 
c1f286933 
  intg/src/main/java/org/apache/atlas/entitytransform/Condition.java d44f57509 
  
intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java
 69fba1eaf 


Diff: https://reviews.apache.org/r/68743/diff/1/


Testing
---

TransformationHandlerTest.testHiveTableClearAttributeHandlerWithNoCondition()
TransformationHandlerTest.testHiveTableSetDeletedStatusHandler()


Thanks,

Sarath Subramanian