Re: Review Request 70575: ATLAS-3181 Corrected missing components in the example URLs in Swagger interactive API doc

2019-05-17 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70575/#review215333
---


Ship it!




Ship It!

- Sarath Subramanian


On May 1, 2019, 1:08 p.m., Carol Drummond wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70575/
> ---
> 
> (Updated May 1, 2019, 1:08 p.m.)
> 
> 
> Review request for atlas and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3181
> https://issues.apache.org/jira/browse/ATLAS-3181
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch inserts a prefix to the URL produced by enunciate for the Swagger 
> interactive API examples. Without the prefix, the example URLs do not work.
> 
> 
> Diffs
> -
> 
>   build-tools/src/main/resources/enunciate.xml e01d69680 
> 
> 
> Diff: https://reviews.apache.org/r/70575/diff/1/
> 
> 
> Testing
> ---
> 
> Validated that my prefix appears in the right place in the Swagger UI for a 
> selection of APIs.
> Validated that the interactivity works as expected (no regressions).
> Validated that the examples now produce URLs that work as expected.
> 
> 
> Thanks,
> 
> Carol Drummond
> 
>



Re: Review Request 70575: ATLAS-3181 Corrected missing components in the example URLs in Swagger interactive API doc

2019-05-01 Thread Carol Drummond via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70575/
---

(Updated May 1, 2019, 8:08 p.m.)


Review request for atlas and Sarath Subramanian.


Bugs: ATLAS-3181
https://issues.apache.org/jira/browse/ATLAS-3181


Repository: atlas


Description
---

This patch inserts a prefix to the URL produced by enunciate for the Swagger 
interactive API examples. Without the prefix, the example URLs do not work.


Diffs
-

  build-tools/src/main/resources/enunciate.xml e01d69680 


Diff: https://reviews.apache.org/r/70575/diff/1/


Testing
---

Validated that my prefix appears in the right place in the Swagger UI for a 
selection of APIs.
Validated that the interactivity works as expected (no regressions).
Validated that the examples now produce URLs that work as expected.


Thanks,

Carol Drummond