Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-23 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220444
---


Ship it!




Ship It!

- Nixon Rodrigues


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220442
---


Ship it!




Ship It!

- Madhan Neethiraj


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220441
---




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Line 207 (original), 206 (patched)


I have added delimeter '|' here , as _classificationNames can have multiple 
tag names


- Pinal Shah


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah 


> On April 22, 2020, 11:48 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
> > Lines 853 (patched)
> > 
> >
> > Is it necessary to add '.*' as prefix and suffix? Wouldn't this result 
> > in incorrect results, for example given seach string tag*a*b would match 
> > for tags: 'mytag_abcd' which is incorrect. Please review and update.

Yes Madhan you are correct.
To handle this scenario, i have added prefix and suffix with '|' to the 
classificationName


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220437
---


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220437
---




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 853 (patched)


Is it necessary to add '.*' as prefix and suffix? Wouldn't this result in 
incorrect results, for example given seach string tag*a*b would match for tags: 
'mytag_abcd' which is incorrect. Please review and update.


- Madhan Neethiraj


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3753
https://issues.apache.org/jira/browse/ATLAS-3753


Repository: atlas


Description
---

Tag `tag_abc_test` is created and associated to an entity.

Search with test or tag fetches the entity.

But Search with tag*test doesn't fetch the entity.


Diffs
-

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
5d7c50838 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
69770c3b4 


Diff: https://reviews.apache.org/r/72418/diff/1/


Testing
---

Manually tested below combinations for wildcard (CASE_INSENSITIVE)

'tag_abc_*'
'*_abc*'
'tag_*_*'
'tag*test'


Thanks,

Pinal Shah