Re: Review Request 72565: ATLAS-3825: updated import business-metadata to set business attribute values on appropriate entities

2020-06-03 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72565/#review220954
---


Ship it!




Ship It!

- Sarath Subramanian


On June 3, 2020, 5:45 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72565/
> ---
> 
> (Updated June 3, 2020, 5:45 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, 
> mayank jain, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth 
> Mishra.
> 
> 
> Bugs: ATLAS-3825
> https://issues.apache.org/jira/browse/ATLAS-3825
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - fixed incorrect attribute value assignements
> - updated to return all failures encountred during import
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/bulkimport/BulkImportResponse.java 
> 0ee54e996 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  89076c123 
> 
> 
> Diff: https://reviews.apache.org/r/72565/diff/1/
> 
> 
> Testing
> ---
> 
> - manually verified that business attributes are set to appropriate values on 
> all entities specified in import contents
> - pre-commit tests run - 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1949/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Review Request 72565: ATLAS-3825: updated import business-metadata to set business attribute values on appropriate entities

2020-06-03 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72565/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, keval bhatt, mayank 
jain, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3825
https://issues.apache.org/jira/browse/ATLAS-3825


Repository: atlas


Description
---

- fixed incorrect attribute value assignements
- updated to return all failures encountred during import


Diffs
-

  intg/src/main/java/org/apache/atlas/bulkimport/BulkImportResponse.java 
0ee54e996 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 89076c123 


Diff: https://reviews.apache.org/r/72565/diff/1/


Testing
---

- manually verified that business attributes are set to appropriate values on 
all entities specified in import contents
- pre-commit tests run - 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1949/


Thanks,

Madhan Neethiraj