Re: Review Request 73216: ATLAS-4188: Docker setup updated to run Atlas, HBase, Solr, Kafka, Zookeeper in seperate containers

2021-03-13 Thread Jayendra Parab 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73216/#review222680
---


Ship it!




Ship It!

- Jayendra Parab


On March 11, 2021, 4:29 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73216/
> ---
> 
> (Updated March 11, 2021, 4:29 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil 
> Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, 
> Sharmadha Sainath, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4188
> https://issues.apache.org/jira/browse/ATLAS-4188
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated Docker setup to run Atlas, HBase, Hadoop, Solr, Kafka, Zookeeper in 
> seperate containers
> 
> 
> Diffs
> -
> 
>   dev-support/atlas-docker/.dockerignore d6a848020 
>   dev-support/atlas-docker/.env 19443ad62 
>   dev-support/atlas-docker/Dockerfile.atlas 76e5c5967 
>   dev-support/atlas-docker/Dockerfile.atlas-base 36e8f0ff7 
>   dev-support/atlas-docker/Dockerfile.atlas-hadoop PRE-CREATION 
>   dev-support/atlas-docker/Dockerfile.atlas-hbase PRE-CREATION 
>   dev-support/atlas-docker/Dockerfile.atlas-kafka PRE-CREATION 
>   dev-support/atlas-docker/Dockerfile.atlas-solr PRE-CREATION 
>   dev-support/atlas-docker/Dockerfile.atlas-zk PRE-CREATION 
>   dev-support/atlas-docker/README.md 37caa3a76 
>   dev-support/atlas-docker/config/solr/currency.xml PRE-CREATION 
>   dev-support/atlas-docker/config/solr/lang/stopwords_en.txt PRE-CREATION 
>   dev-support/atlas-docker/config/solr/protwords.txt PRE-CREATION 
>   dev-support/atlas-docker/config/solr/schema.xml PRE-CREATION 
>   dev-support/atlas-docker/config/solr/solrconfig.xml PRE-CREATION 
>   dev-support/atlas-docker/config/solr/stopwords.txt PRE-CREATION 
>   dev-support/atlas-docker/config/solr/synonyms.txt PRE-CREATION 
>   dev-support/atlas-docker/docker-compose.atlas-build.yml c29588fe1 
>   dev-support/atlas-docker/docker-compose.atlas-hadoop.yml PRE-CREATION 
>   dev-support/atlas-docker/docker-compose.atlas-hbase.yml PRE-CREATION 
>   dev-support/atlas-docker/docker-compose.atlas-kafka.yml PRE-CREATION 
>   dev-support/atlas-docker/docker-compose.atlas.yml cfaf0d7b4 
>   dev-support/atlas-docker/download-archives.sh PRE-CREATION 
>   dev-support/atlas-docker/downloads/.gitignore PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hadoop-mkdir.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hadoop-setup.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hadoop.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hbase-setup.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hbase.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-kafka-setup.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-kafka.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-solr-create.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas.sh 7abb6f734 
>   dev-support/atlas-docker/scripts/hbase-site.xml PRE-CREATION 
>   distro/pom.xml c00de3990 
>   pom.xml df4dec5d4 
>   webapp/pom.xml 7d6173544 
> 
> 
> Diff: https://reviews.apache.org/r/73216/diff/4/
> 
> 
> Testing
> ---
> 
> - using docker-compose, verified that containers for Atlas and dependent 
> services are built and run successfully
> - ran quick_start.py successfully on Atlas instance running in a container
> - pre-commit tests run: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/431
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 73216: ATLAS-4188: Docker setup updated to run Atlas, HBase, Solr, Kafka, Zookeeper in seperate containers

2021-03-11 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73216/
---

(Updated March 11, 2021, 4:29 p.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil 
Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, 
Sharmadha Sainath, and Sidharth Mishra.


Changes
---

addressed review comments


Bugs: ATLAS-4188
https://issues.apache.org/jira/browse/ATLAS-4188


Repository: atlas


Description
---

updated Docker setup to run Atlas, HBase, Hadoop, Solr, Kafka, Zookeeper in 
seperate containers


Diffs (updated)
-

  dev-support/atlas-docker/.dockerignore d6a848020 
  dev-support/atlas-docker/.env 19443ad62 
  dev-support/atlas-docker/Dockerfile.atlas 76e5c5967 
  dev-support/atlas-docker/Dockerfile.atlas-base 36e8f0ff7 
  dev-support/atlas-docker/Dockerfile.atlas-hadoop PRE-CREATION 
  dev-support/atlas-docker/Dockerfile.atlas-hbase PRE-CREATION 
  dev-support/atlas-docker/Dockerfile.atlas-kafka PRE-CREATION 
  dev-support/atlas-docker/Dockerfile.atlas-solr PRE-CREATION 
  dev-support/atlas-docker/Dockerfile.atlas-zk PRE-CREATION 
  dev-support/atlas-docker/README.md 37caa3a76 
  dev-support/atlas-docker/config/solr/currency.xml PRE-CREATION 
  dev-support/atlas-docker/config/solr/lang/stopwords_en.txt PRE-CREATION 
  dev-support/atlas-docker/config/solr/protwords.txt PRE-CREATION 
  dev-support/atlas-docker/config/solr/schema.xml PRE-CREATION 
  dev-support/atlas-docker/config/solr/solrconfig.xml PRE-CREATION 
  dev-support/atlas-docker/config/solr/stopwords.txt PRE-CREATION 
  dev-support/atlas-docker/config/solr/synonyms.txt PRE-CREATION 
  dev-support/atlas-docker/docker-compose.atlas-build.yml c29588fe1 
  dev-support/atlas-docker/docker-compose.atlas-hadoop.yml PRE-CREATION 
  dev-support/atlas-docker/docker-compose.atlas-hbase.yml PRE-CREATION 
  dev-support/atlas-docker/docker-compose.atlas-kafka.yml PRE-CREATION 
  dev-support/atlas-docker/docker-compose.atlas.yml cfaf0d7b4 
  dev-support/atlas-docker/download-archives.sh PRE-CREATION 
  dev-support/atlas-docker/downloads/.gitignore PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-hadoop-mkdir.sh PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-hadoop-setup.sh PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-hadoop.sh PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-hbase-setup.sh PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-hbase.sh PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-kafka-setup.sh PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-kafka.sh PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-solr-create.sh PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas.sh 7abb6f734 
  dev-support/atlas-docker/scripts/hbase-site.xml PRE-CREATION 
  distro/pom.xml c00de3990 
  pom.xml df4dec5d4 
  webapp/pom.xml 7d6173544 


Diff: https://reviews.apache.org/r/73216/diff/4/

Changes: https://reviews.apache.org/r/73216/diff/3-4/


Testing
---

- using docker-compose, verified that containers for Atlas and dependent 
services are built and run successfully
- ran quick_start.py successfully on Atlas instance running in a container
- pre-commit tests run: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/431


Thanks,

Madhan Neethiraj

Re: Review Request 73216: ATLAS-4188: Docker setup updated to run Atlas, HBase, Solr, Kafka, Zookeeper in seperate containers

2021-03-11 Thread Jayendra Parab 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73216/#review222666
---




dev-support/atlas-docker/.env
Lines 10 (patched)


Can we also have solr and zookeeper version which can be used to pull the 
appropriate docker image?



dev-support/atlas-docker/README.md
Line 26 (original), 26 (patched)


Shall we also have the minimum memory allocation for docker as part of the 
README?


- Jayendra Parab


On March 7, 2021, 9:42 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73216/
> ---
> 
> (Updated March 7, 2021, 9:42 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil 
> Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, 
> Sharmadha Sainath, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4188
> https://issues.apache.org/jira/browse/ATLAS-4188
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated Docker setup to run Atlas, HBase, Hadoop, Solr, Kafka, Zookeeper in 
> seperate containers
> 
> 
> Diffs
> -
> 
>   dev-support/atlas-docker/.dockerignore d6a848020 
>   dev-support/atlas-docker/.env 19443ad62 
>   dev-support/atlas-docker/Dockerfile.atlas 76e5c5967 
>   dev-support/atlas-docker/Dockerfile.atlas-base 36e8f0ff7 
>   dev-support/atlas-docker/Dockerfile.atlas-hadoop PRE-CREATION 
>   dev-support/atlas-docker/Dockerfile.atlas-hbase PRE-CREATION 
>   dev-support/atlas-docker/Dockerfile.atlas-kafka PRE-CREATION 
>   dev-support/atlas-docker/Dockerfile.atlas-solr PRE-CREATION 
>   dev-support/atlas-docker/Dockerfile.atlas-zk PRE-CREATION 
>   dev-support/atlas-docker/README.md 37caa3a76 
>   dev-support/atlas-docker/config/solr/currency.xml PRE-CREATION 
>   dev-support/atlas-docker/config/solr/lang/stopwords_en.txt PRE-CREATION 
>   dev-support/atlas-docker/config/solr/protwords.txt PRE-CREATION 
>   dev-support/atlas-docker/config/solr/schema.xml PRE-CREATION 
>   dev-support/atlas-docker/config/solr/solrconfig.xml PRE-CREATION 
>   dev-support/atlas-docker/config/solr/stopwords.txt PRE-CREATION 
>   dev-support/atlas-docker/config/solr/synonyms.txt PRE-CREATION 
>   dev-support/atlas-docker/docker-compose.atlas-build.yml c29588fe1 
>   dev-support/atlas-docker/docker-compose.atlas-hadoop.yml PRE-CREATION 
>   dev-support/atlas-docker/docker-compose.atlas-hbase.yml PRE-CREATION 
>   dev-support/atlas-docker/docker-compose.atlas-kafka.yml PRE-CREATION 
>   dev-support/atlas-docker/docker-compose.atlas.yml cfaf0d7b4 
>   dev-support/atlas-docker/download-archives.sh PRE-CREATION 
>   dev-support/atlas-docker/downloads/.gitignore PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hadoop-mkdir.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hadoop-setup.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hadoop.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hbase-setup.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-hbase.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-kafka-setup.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-kafka.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas-solr-create.sh PRE-CREATION 
>   dev-support/atlas-docker/scripts/atlas.sh 7abb6f734 
>   dev-support/atlas-docker/scripts/hbase-site.xml PRE-CREATION 
>   distro/pom.xml c00de3990 
>   pom.xml df4dec5d4 
>   webapp/pom.xml 7d6173544 
> 
> 
> Diff: https://reviews.apache.org/r/73216/diff/3/
> 
> 
> Testing
> ---
> 
> - using docker-compose, verified that containers for Atlas and dependent 
> services are built and run successfully
> - ran quick_start.py successfully on Atlas instance running in a container
> - pre-commit tests run: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/431
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>