Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-17 Thread Nikhil Bonte 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/#review223344
---


Fix it, then Ship it!




Fix it, then Ship it!


repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
Line 273 (original), 273 (patched)


move #273 inside if condition (#274), so that name will be fetched only 
when exception is to be thrown.


- Nikhil Bonte


On Aug. 5, 2021, 12:46 p.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73502/
> ---
> 
> (Updated Aug. 5, 2021, 12:46 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-3917
> https://issues.apache.org/jira/browse/ATLAS-3917
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> -Actual Behaviour : While deleting parent tag if the tag is not associated 
> with any entity shows this message- "Given type {0} has reference."
> -Expected Result: There should be tag name instead of {0}
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  b9d41bbba 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
>  3242a33ad 
> 
> 
> Diff: https://reviews.apache.org/r/73502/diff/2/
> 
> 
> Testing
> ---
> 
> -Manual testing done on local server
> 
> -Test case added.
> 
> PC - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-09 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/#review223327
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 5, 2021, 7:16 a.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73502/
> ---
> 
> (Updated Aug. 5, 2021, 7:16 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-3917
> https://issues.apache.org/jira/browse/ATLAS-3917
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> -Actual Behaviour : While deleting parent tag if the tag is not associated 
> with any entity shows this message- "Given type {0} has reference."
> -Expected Result: There should be tag name instead of {0}
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  b9d41bbba 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
>  3242a33ad 
> 
> 
> Diff: https://reviews.apache.org/r/73502/diff/2/
> 
> 
> Testing
> ---
> 
> -Manual testing done on local server
> 
> -Test case added.
> 
> PC - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-05 Thread Shraddha Pardeshi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/
---

(Updated Aug. 5, 2021, 7:16 a.m.)


Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
Pinal Shah.


Bugs: ATLAS-3917
https://issues.apache.org/jira/browse/ATLAS-3917


Repository: atlas


Description
---

-Actual Behaviour : While deleting parent tag if the tag is not associated with 
any entity shows this message- "Given type {0} has reference."
-Expected Result: There should be tag name instead of {0}


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
 b9d41bbba 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
 3242a33ad 


Diff: https://reviews.apache.org/r/73502/diff/2/

Changes: https://reviews.apache.org/r/73502/diff/1-2/


Testing
---

-Manual testing done on local server

-Test case added.

PC - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console


Thanks,

Shraddha Pardeshi

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-04 Thread Nikhil Bonte 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/#review223311
---




repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
Lines 80 (patched)


Suggestion - Rename: 
testErrorMessage() -> testDeleteReferencedTraitFail()


- Nikhil Bonte


On Aug. 4, 2021, 7:41 p.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73502/
> ---
> 
> (Updated Aug. 4, 2021, 7:41 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-3917
> https://issues.apache.org/jira/browse/ATLAS-3917
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> -Actual Behaviour : While deleting parent tag if the tag is not associated 
> with any entity shows this message- "Given type {0} has reference."
> -Expected Result: There should be tag name instead of {0}
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  b9d41bbba 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
>  3242a33ad 
> 
> 
> Diff: https://reviews.apache.org/r/73502/diff/1/
> 
> 
> Testing
> ---
> 
> -Manual testing done on local server
> 
> -Test case added.
> 
> PC - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-04 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/#review223307
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
Line 47 (original), 47 (patched)


Retain imports. (If using IntelliJ, change default setting.)



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
Line 56 (original), 51 (patched)


nit: Retain individual imports.



repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
Lines 82 (patched)


Good!



repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
Lines 91 (patched)


Consider replacing string with the error message mentioned in the 
AtlasErrorCode.


- Ashutosh Mestry


On Aug. 4, 2021, 2:11 p.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73502/
> ---
> 
> (Updated Aug. 4, 2021, 2:11 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-3917
> https://issues.apache.org/jira/browse/ATLAS-3917
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> -Actual Behaviour : While deleting parent tag if the tag is not associated 
> with any entity shows this message- "Given type {0} has reference."
> -Expected Result: There should be tag name instead of {0}
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  b9d41bbba 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
>  3242a33ad 
> 
> 
> Diff: https://reviews.apache.org/r/73502/diff/1/
> 
> 
> Testing
> ---
> 
> -Manual testing done on local server
> 
> -Test case added.
> 
> PC - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-04 Thread Shraddha Pardeshi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/
---

Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
Pinal Shah.


Bugs: ATLAS-3917
https://issues.apache.org/jira/browse/ATLAS-3917


Repository: atlas


Description
---

-Actual Behaviour : While deleting parent tag if the tag is not associated with 
any entity shows this message- "Given type {0} has reference."
-Expected Result: There should be tag name instead of {0}


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
 b9d41bbba 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
 3242a33ad 


Diff: https://reviews.apache.org/r/73502/diff/1/


Testing
---

-Manual testing done on local server

-Test case added.

PC - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console


Thanks,

Shraddha Pardeshi