Re: Review Request 73641: Repair Composite indexes

2021-10-11 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
---

(Updated Oct. 11, 2021, 8 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-4447
https://issues.apache.org/jira/browse/ATLAS-4447


Repository: atlas


Description
---

If by any chance, commposite index are not enabled, this patch fixes the 
composite index from REGISTERED state to ENABLED state


Diffs (updated)
-

  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 7e3b2f440 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
 1cc7f8b55 
  
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
 d30971afc 
  
repository/src/main/java/org/apache/atlas/repository/patches/UpdateCompositeIndexStatusPatch.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/2/

Changes: https://reviews.apache.org/r/73641/diff/1-2/


Testing
---

manually tested


Thanks,

Pinal Shah

Re: Review Request 73641: Repair Composite indexes

2021-10-10 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/#review223595
---


Fix it, then Ship it!





graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 38 (patched)


nit: unused import; consider removing



graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 324 (patched)


nit: add import statement for SchemaStatus and SchemaAction.



graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 329 (patched)


Add more detail to log statement:

LOG.info("Index schema status updated for index: {}, from {} to {}.", 
index.name(), SchemaStatus.REGISTERED, SchemaStatus.ENABLED);



graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
Lines 332 (patched)


consider adding else if block to handle WARN logging for "INSTALLED" schema 
status



repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java
Lines 27 (patched)


consider renaming class to "UpdateCompositeIndexStatusPatch", since this 
JAVA patch deals with UPDATING the schema status of certain composite indexes.


- Sarath Subramanian


On Oct. 8, 2021, 9:05 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73641/
> ---
> 
> (Updated Oct. 8, 2021, 9:05 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4447
> https://issues.apache.org/jira/browse/ATLAS-4447
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> If by any chance, commposite index are not enabled, this patch fixes the 
> composite index from REGISTERED state to ENABLED state
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  7e3b2f440 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
>  1cc7f8b55 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  d30971afc 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73641/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73641: Repair Composite indexes

2021-10-08 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
---

(Updated Oct. 8, 2021, 4:05 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
Subramanian.


Bugs: ATLAS-4447
https://issues.apache.org/jira/browse/ATLAS-4447


Repository: atlas


Description
---

If by any chance, commposite index are not enabled, this patch fixes the 
composite index from REGISTERED state to ENABLED state


Diffs
-

  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 7e3b2f440 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
 1cc7f8b55 
  
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
 d30971afc 
  
repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/1/


Testing
---

manually tested


Thanks,

Pinal Shah

Re: Review Request 73641: Repair Composite indexes

2021-10-08 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/#review223593
---


Ship it!




Ship It!

- Ashutosh Mestry


On Oct. 8, 2021, 1:38 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73641/
> ---
> 
> (Updated Oct. 8, 2021, 1:38 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> If by any chance, commposite index are not enabled, this patch fixes the 
> composite index from REGISTERED state to ENABLED state
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  7e3b2f440 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
>  1cc7f8b55 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  d30971afc 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73641/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Review Request 73641: Repair Composite indexes

2021-10-08 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73641/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
Subramanian.


Repository: atlas


Description
---

If by any chance, commposite index are not enabled, this patch fixes the 
composite index from REGISTERED state to ENABLED state


Diffs
-

  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 7e3b2f440 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
 1cc7f8b55 
  
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
 d30971afc 
  
repository/src/main/java/org/apache/atlas/repository/patches/RepairCompositeIndexPatch.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/73641/diff/1/


Testing
---

manually tested


Thanks,

Pinal Shah