Re: Review Request 73747: ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas

2021-12-08 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73747/#review223826
---


Ship it!




Ship It!

- Nixon Rodrigues


On Dec. 9, 2021, 12:26 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73747/
> ---
> 
> (Updated Dec. 9, 2021, 12:26 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4502
> https://issues.apache.org/jira/browse/ATLAS-4502
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 950a79c85 
>   pom.xml 4c92a09ad 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  fb890fc5d 
>   webapp/pom.xml 858ab9aaf 
> 
> 
> Diff: https://reviews.apache.org/r/73747/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested locally with local Cassandra ans embedded elastic search
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73747: ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas

2021-12-08 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73747/#review223825
---


Ship it!




Ship It!

- Sarath Subramanian


On Dec. 8, 2021, 4:26 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73747/
> ---
> 
> (Updated Dec. 8, 2021, 4:26 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4502
> https://issues.apache.org/jira/browse/ATLAS-4502
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 950a79c85 
>   pom.xml 4c92a09ad 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  fb890fc5d 
>   webapp/pom.xml 858ab9aaf 
> 
> 
> Diff: https://reviews.apache.org/r/73747/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested locally with local Cassandra ans embedded elastic search
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73747: ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas

2021-12-08 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73747/
---

(Updated Dec. 9, 2021, 12:26 a.m.)


Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4502
https://issues.apache.org/jira/browse/ATLAS-4502


Repository: atlas


Description
---

ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas


Diffs (updated)
-

  distro/pom.xml 950a79c85 
  pom.xml 4c92a09ad 
  
repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 fb890fc5d 
  webapp/pom.xml 858ab9aaf 


Diff: https://reviews.apache.org/r/73747/diff/2/

Changes: https://reviews.apache.org/r/73747/diff/1-2/


Testing
---

Manually tested locally with local Cassandra ans embedded elastic search


Thanks,

Sidharth Mishra

Re: Review Request 73747: ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas

2021-12-08 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73747/#review223817
---


Fix it, then Ship it!





pom.xml
Line 586 (original), 586 (patched)


consider using variable here ${guava.version}


- Sarath Subramanian


On Dec. 7, 2021, 12:21 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73747/
> ---
> 
> (Updated Dec. 7, 2021, 12:21 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4502
> https://issues.apache.org/jira/browse/ATLAS-4502
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 950a79c85 
>   pom.xml 4c92a09ad 
>   webapp/pom.xml 858ab9aaf 
> 
> 
> Diff: https://reviews.apache.org/r/73747/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested locally with local Cassandra ans embedded elastic search
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Review Request 73747: ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas

2021-12-07 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73747/
---

Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4502
https://issues.apache.org/jira/browse/ATLAS-4502


Repository: atlas


Description
---

ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas


Diffs
-

  distro/pom.xml 950a79c85 
  pom.xml 4c92a09ad 
  webapp/pom.xml 858ab9aaf 


Diff: https://reviews.apache.org/r/73747/diff/1/


Testing
---

Manually tested locally with local Cassandra ans embedded elastic search


Thanks,

Sidharth Mishra