Re: Review Request 74027: ATLAS-4622: import fix to handle invalid zip entry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74027/#review224513 --- Ship it! Ship It! - Nixon Rodrigues On June 16, 2022, 12:11 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74027/ > --- > > (Updated June 16, 2022, 12:11 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nikhil Bonte, > Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sharmadha > Sainath, and Sidharth Mishra. > > > Bugs: ATLAS-4622 > https://issues.apache.org/jira/browse/ATLAS-4622 > > > Repository: atlas > > > Description > --- > > updated to fail import operation when invalid zip entries were found > > > Diffs > - > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ca933ff9 > > repository/src/main/java/org/apache/atlas/repository/impexp/ZipSourceWithBackingDirectory.java > 79638009d > > > Diff: https://reviews.apache.org/r/74027/diff/1/ > > > Testing > --- > > - verified that import fails on detecting entries with names having relative > path to parent directory > - pre-commit tests run > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1122/ > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 74027: ATLAS-4622: import fix to handle invalid zip entry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74027/#review224512 --- Ship it! Ship It! - Nikhil Bonte On June 16, 2022, 5:41 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74027/ > --- > > (Updated June 16, 2022, 5:41 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nikhil Bonte, > Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sharmadha > Sainath, and Sidharth Mishra. > > > Bugs: ATLAS-4622 > https://issues.apache.org/jira/browse/ATLAS-4622 > > > Repository: atlas > > > Description > --- > > updated to fail import operation when invalid zip entries were found > > > Diffs > - > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ca933ff9 > > repository/src/main/java/org/apache/atlas/repository/impexp/ZipSourceWithBackingDirectory.java > 79638009d > > > Diff: https://reviews.apache.org/r/74027/diff/1/ > > > Testing > --- > > - verified that import fails on detecting entries with names having relative > path to parent directory > - pre-commit tests run > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1122/ > > > Thanks, > > Madhan Neethiraj > >
Review Request 74027: ATLAS-4622: import fix to handle invalid zip entry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74027/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sharmadha Sainath, and Sidharth Mishra. Bugs: ATLAS-4622 https://issues.apache.org/jira/browse/ATLAS-4622 Repository: atlas Description --- updated to fail import operation when invalid zip entries were found Diffs - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ca933ff9 repository/src/main/java/org/apache/atlas/repository/impexp/ZipSourceWithBackingDirectory.java 79638009d Diff: https://reviews.apache.org/r/74027/diff/1/ Testing --- - verified that import fails on detecting entries with names having relative path to parent directory - pre-commit tests run https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1122/ Thanks, Madhan Neethiraj
