Re: Review Request 74063: ATLAS-4642: updated plugin classloader to remove use of non-final static class member

2022-07-21 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74063/#review224572
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 21, 2022, 1:06 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74063/
> ---
> 
> (Updated July 21, 2022, 1:06 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, 
> Radhika Kundam, Sarath Subramanian, Sharmadha Sainath, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4642
> https://issues.apache.org/jira/browse/ATLAS-4642
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> replaced use of a volatile static with a final static map, which would enable 
> multiple plugin-classloader instances to co-exist in a JVM
> 
> 
> Diffs
> -
> 
>   
> plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoader.java
>  fc75a7ebc 
>   
> plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java
>  f44603b84 
>   
> plugin-classloader/src/test/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderTest.java
>  6139a0032 
> 
> 
> Diff: https://reviews.apache.org/r/74063/diff/1/
> 
> 
> Testing
> ---
> 
> - verified Atlas hooks in Hive/HBase work correctly with this patch
> - pre-commit tests run 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1133/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Review Request 74063: ATLAS-4642: updated plugin classloader to remove use of non-final static class member

2022-07-20 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74063/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, Radhika 
Kundam, Sarath Subramanian, Sharmadha Sainath, and Sidharth Mishra.


Bugs: ATLAS-4642
https://issues.apache.org/jira/browse/ATLAS-4642


Repository: atlas


Description
---

replaced use of a volatile static with a final static map, which would enable 
multiple plugin-classloader instances to co-exist in a JVM


Diffs
-

  
plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoader.java
 fc75a7ebc 
  
plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java
 f44603b84 
  
plugin-classloader/src/test/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderTest.java
 6139a0032 


Diff: https://reviews.apache.org/r/74063/diff/1/


Testing
---

- verified Atlas hooks in Hive/HBase work correctly with this patch
- pre-commit tests run 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1133/


Thanks,

Madhan Neethiraj