Re: Review Request 74162: ATLAS-4610, ATLAS-4655: Classification/ Term: Add parent name for classification & term
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74162/#review224822 --- Ship it! Ship It! - Mandar Ambawane On Oct. 20, 2022, 10:30 a.m., Prasad Pawar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74162/ > --- > > (Updated Oct. 20, 2022, 10:30 a.m.) > > > Review request for atlas, Farhan Khan, Jayendra Parab, Mandar Ambawane, Pinal > Shah, Sharmadha Sainath, and Sheetal Shah. > > > Bugs: https://issues.apache.org/jira/browse/ATLAS-4610 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-4610 > > > Repository: atlas > > > Description > --- > > Backend: > Modified AtlasTermAssignmentHeader, AtlasRelatedObjectId and > AtlasRelatedTermHeader to display glossary details on entity search, dsl > search, basic search and term details pages. > > UI: > The classification and term assignment section should display their parents > if present, on the detail page. > > 1) Classification name will be displayed as "name"/ "name@parent"/ > "name@(parent1,parent2,...)", on search result page, entity detail page, > classification/term detail page (search result). > > 2)Term name will be displayed as "term@glossary", on search result page, > entity detail page, classification/term detail page (search result). > Same will be display on tooltip of classification and term. > > 3) Button Text on view related attribute change from "ok" to "Close" on term > detail page . fixed > > 4) Button Text while removing term from related terms columns is change from > "Ok" to "Cancle" on term detail page . fixed > > 5) New-ui, redirection to tag detail page from search result page & entity > detail page, fixed > > > Diffs > - > > dashboardv2/public/css/scss/common.scss 60b272214 > dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > ee4b9431f > dashboardv2/public/js/utils/CommonViewFunction.js f93b1788a > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 73293507c > dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 02606067b > dashboardv2/public/js/views/glossary/TermRelationAttributeLayoutView.js > ded1ab943 > dashboardv2/public/js/views/schema/SchemaLayoutView.js efc8e9356 > dashboardv2/public/js/views/search/SearchResultLayoutView.js 66466e21d > dashboardv2/public/js/views/tag/TagLayoutView.js 7de7aea14 > dashboardv3/public/css/scss/common.scss c0f65fdab > dashboardv3/public/js/router/Router.js a48b4cc78 > dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > b209a49e4 > dashboardv3/public/js/utils/CommonViewFunction.js 5b2b0c2dc > dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js a64032278 > dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 019cd9d3f > dashboardv3/public/js/views/glossary/TermRelationAttributeLayoutView.js > ded1ab943 > dashboardv3/public/js/views/schema/SchemaLayoutView.js 1ae75d922 > dashboardv3/public/js/views/search/SearchResultLayoutView.js d9d238353 > dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js > 13a5a899d > > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java > f16cf25ed > > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java > c7de0638a > > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java > ae6932de5 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 110c447ad > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 0ee86735d > > > Diff: https://reviews.apache.org/r/74162/diff/2/ > > > Testing > --- > > On search result page: > > 1) Assigned classifications and terms are displayed as per requirement. > 2) Tooltip for assigned classifications and terms are displayed as per > requirement. > 3) Redirection to classification detail page & term detail page > > On entity detail page: > 1) Assigned classifications and terms are displayed as per requirement. > 2) Propagated classifications are displayed as per requirement. > 3) Tooltip for assigned classifications, terms and Propagated classifications > are displayed as per requirement. > 4) Redirection to classification detail page & term detail page. > > On Term detail page: > 1) Search resut displays classification and term as per requirement, also for > tooltip. > 2) Redirection to classification detail page & term detail page. > 3) Button text is changes to "Close", on view window of Related Terms > Attributes. > 4) Button text is changes to "Cancle",
Re: Review Request 74162: ATLAS-4610, ATLAS-4655: Classification/ Term: Add parent name for classification & term
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74162/#review224821 --- Ship it! Ship It! - Farhan Khan On Oct. 20, 2022, 10:30 a.m., Prasad Pawar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74162/ > --- > > (Updated Oct. 20, 2022, 10:30 a.m.) > > > Review request for atlas, Farhan Khan, Jayendra Parab, Mandar Ambawane, Pinal > Shah, Sharmadha Sainath, and Sheetal Shah. > > > Bugs: https://issues.apache.org/jira/browse/ATLAS-4610 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-4610 > > > Repository: atlas > > > Description > --- > > Backend: > Modified AtlasTermAssignmentHeader, AtlasRelatedObjectId and > AtlasRelatedTermHeader to display glossary details on entity search, dsl > search, basic search and term details pages. > > UI: > The classification and term assignment section should display their parents > if present, on the detail page. > > 1) Classification name will be displayed as "name"/ "name@parent"/ > "name@(parent1,parent2,...)", on search result page, entity detail page, > classification/term detail page (search result). > > 2)Term name will be displayed as "term@glossary", on search result page, > entity detail page, classification/term detail page (search result). > Same will be display on tooltip of classification and term. > > 3) Button Text on view related attribute change from "ok" to "Close" on term > detail page . fixed > > 4) Button Text while removing term from related terms columns is change from > "Ok" to "Cancle" on term detail page . fixed > > 5) New-ui, redirection to tag detail page from search result page & entity > detail page, fixed > > > Diffs > - > > dashboardv2/public/css/scss/common.scss 60b272214 > dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > ee4b9431f > dashboardv2/public/js/utils/CommonViewFunction.js f93b1788a > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 73293507c > dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 02606067b > dashboardv2/public/js/views/glossary/TermRelationAttributeLayoutView.js > ded1ab943 > dashboardv2/public/js/views/schema/SchemaLayoutView.js efc8e9356 > dashboardv2/public/js/views/search/SearchResultLayoutView.js 66466e21d > dashboardv2/public/js/views/tag/TagLayoutView.js 7de7aea14 > dashboardv3/public/css/scss/common.scss c0f65fdab > dashboardv3/public/js/router/Router.js a48b4cc78 > dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > b209a49e4 > dashboardv3/public/js/utils/CommonViewFunction.js 5b2b0c2dc > dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js a64032278 > dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 019cd9d3f > dashboardv3/public/js/views/glossary/TermRelationAttributeLayoutView.js > ded1ab943 > dashboardv3/public/js/views/schema/SchemaLayoutView.js 1ae75d922 > dashboardv3/public/js/views/search/SearchResultLayoutView.js d9d238353 > dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js > 13a5a899d > > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java > f16cf25ed > > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java > c7de0638a > > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java > ae6932de5 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 110c447ad > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 0ee86735d > > > Diff: https://reviews.apache.org/r/74162/diff/2/ > > > Testing > --- > > On search result page: > > 1) Assigned classifications and terms are displayed as per requirement. > 2) Tooltip for assigned classifications and terms are displayed as per > requirement. > 3) Redirection to classification detail page & term detail page > > On entity detail page: > 1) Assigned classifications and terms are displayed as per requirement. > 2) Propagated classifications are displayed as per requirement. > 3) Tooltip for assigned classifications, terms and Propagated classifications > are displayed as per requirement. > 4) Redirection to classification detail page & term detail page. > > On Term detail page: > 1) Search resut displays classification and term as per requirement, also for > tooltip. > 2) Redirection to classification detail page & term detail page. > 3) Button text is changes to "Close", on view window of Related Terms > Attributes. > 4) Button text is changes to "Cancle", when
Re: Review Request 74162: ATLAS-4610, ATLAS-4655: Classification/ Term: Add parent name for classification & term
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74162/ --- (Updated Oct. 20, 2022, 10:30 a.m.) Review request for atlas, Farhan Khan, Jayendra Parab, Mandar Ambawane, Pinal Shah, Sharmadha Sainath, and Sheetal Shah. Changes --- added fix for-> when user doesnt have CRUD permission on tags, search page is not loading. Bugs: https://issues.apache.org/jira/browse/ATLAS-4610 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-4610 Repository: atlas Description --- Backend: Modified AtlasTermAssignmentHeader, AtlasRelatedObjectId and AtlasRelatedTermHeader to display glossary details on entity search, dsl search, basic search and term details pages. UI: The classification and term assignment section should display their parents if present, on the detail page. 1) Classification name will be displayed as "name"/ "name@parent"/ "name@(parent1,parent2,...)", on search result page, entity detail page, classification/term detail page (search result). 2)Term name will be displayed as "term@glossary", on search result page, entity detail page, classification/term detail page (search result). Same will be display on tooltip of classification and term. 3) Button Text on view related attribute change from "ok" to "Close" on term detail page . fixed 4) Button Text while removing term from related terms columns is change from "Ok" to "Cancle" on term detail page . fixed 5) New-ui, redirection to tag detail page from search result page & entity detail page, fixed Diffs (updated) - dashboardv2/public/css/scss/common.scss 60b272214 dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html ee4b9431f dashboardv2/public/js/utils/CommonViewFunction.js f93b1788a dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 73293507c dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 02606067b dashboardv2/public/js/views/glossary/TermRelationAttributeLayoutView.js ded1ab943 dashboardv2/public/js/views/schema/SchemaLayoutView.js efc8e9356 dashboardv2/public/js/views/search/SearchResultLayoutView.js 66466e21d dashboardv2/public/js/views/tag/TagLayoutView.js 7de7aea14 dashboardv3/public/css/scss/common.scss c0f65fdab dashboardv3/public/js/router/Router.js a48b4cc78 dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html b209a49e4 dashboardv3/public/js/utils/CommonViewFunction.js 5b2b0c2dc dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js a64032278 dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 019cd9d3f dashboardv3/public/js/views/glossary/TermRelationAttributeLayoutView.js ded1ab943 dashboardv3/public/js/views/schema/SchemaLayoutView.js 1ae75d922 dashboardv3/public/js/views/search/SearchResultLayoutView.js d9d238353 dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 13a5a899d intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java f16cf25ed intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java c7de0638a intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java ae6932de5 repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 110c447ad repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 0ee86735d Diff: https://reviews.apache.org/r/74162/diff/2/ Changes: https://reviews.apache.org/r/74162/diff/1-2/ Testing --- On search result page: 1) Assigned classifications and terms are displayed as per requirement. 2) Tooltip for assigned classifications and terms are displayed as per requirement. 3) Redirection to classification detail page & term detail page On entity detail page: 1) Assigned classifications and terms are displayed as per requirement. 2) Propagated classifications are displayed as per requirement. 3) Tooltip for assigned classifications, terms and Propagated classifications are displayed as per requirement. 4) Redirection to classification detail page & term detail page. On Term detail page: 1) Search resut displays classification and term as per requirement, also for tooltip. 2) Redirection to classification detail page & term detail page. 3) Button text is changes to "Close", on view window of Related Terms Attributes. 4) Button text is changes to "Cancle", when we remove the assigned term on Related Terms column. 5) Glossary name is displayed as "term@glossary", on Related Terms column of Related terms tab. On Classification detail page: 1) Search resut displays classification and term as per requirement, also for tooltip. 2) Redirection to classification detail page & term detail page 1) New-ui, redirection to tag detail page from
Re: Review Request 74162: ATLAS-4610, ATLAS-4655: Classification/ Term: Add parent name for classification & term
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74162/ --- (Updated Oct. 11, 2022, 5:04 p.m.) Review request for atlas, Farhan Khan, Jayendra Parab, Mandar Ambawane, Pinal Shah, Sharmadha Sainath, and Sheetal Shah. Bugs: https://issues.apache.org/jira/browse/ATLAS-4610 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-4610 Repository: atlas Description (updated) --- Backend: Modified AtlasTermAssignmentHeader, AtlasRelatedObjectId and AtlasRelatedTermHeader to display glossary details on entity search, dsl search, basic search and term details pages. UI: The classification and term assignment section should display their parents if present, on the detail page. 1) Classification name will be displayed as "name"/ "name@parent"/ "name@(parent1,parent2,...)", on search result page, entity detail page, classification/term detail page (search result). 2)Term name will be displayed as "term@glossary", on search result page, entity detail page, classification/term detail page (search result). Same will be display on tooltip of classification and term. 3) Button Text on view related attribute change from "ok" to "Close" on term detail page . fixed 4) Button Text while removing term from related terms columns is change from "Ok" to "Cancle" on term detail page . fixed 5) New-ui, redirection to tag detail page from search result page & entity detail page, fixed Diffs - dashboardv2/public/css/scss/common.scss 2fb6a3a79 dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html ee4b9431f dashboardv2/public/js/utils/CommonViewFunction.js 4ce47a13d dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js bb629b4e4 dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 02606067b dashboardv2/public/js/views/glossary/TermRelationAttributeLayoutView.js ded1ab943 dashboardv2/public/js/views/schema/SchemaLayoutView.js efc8e9356 dashboardv2/public/js/views/search/SearchResultLayoutView.js 66466e21d dashboardv2/public/js/views/tag/TagLayoutView.js 7de7aea14 dashboardv3/public/css/scss/common.scss 036d2cfcc dashboardv3/public/js/router/Router.js 8e8cf1557 dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html b209a49e4 dashboardv3/public/js/utils/CommonViewFunction.js 7d8f03d2e dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 471be3bd7 dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 019cd9d3f dashboardv3/public/js/views/glossary/TermRelationAttributeLayoutView.js ded1ab943 dashboardv3/public/js/views/schema/SchemaLayoutView.js 1ae75d922 dashboardv3/public/js/views/search/SearchResultLayoutView.js d9d238353 dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 1883dfbd7 intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java f16cf25ed intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java c7de0638a intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java ae6932de5 repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 110c447ad repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 0ee86735d Diff: https://reviews.apache.org/r/74162/diff/1/ Testing --- On search result page: 1) Assigned classifications and terms are displayed as per requirement. 2) Tooltip for assigned classifications and terms are displayed as per requirement. 3) Redirection to classification detail page & term detail page On entity detail page: 1) Assigned classifications and terms are displayed as per requirement. 2) Propagated classifications are displayed as per requirement. 3) Tooltip for assigned classifications, terms and Propagated classifications are displayed as per requirement. 4) Redirection to classification detail page & term detail page. On Term detail page: 1) Search resut displays classification and term as per requirement, also for tooltip. 2) Redirection to classification detail page & term detail page. 3) Button text is changes to "Close", on view window of Related Terms Attributes. 4) Button text is changes to "Cancle", when we remove the assigned term on Related Terms column. 5) Glossary name is displayed as "term@glossary", on Related Terms column of Related terms tab. On Classification detail page: 1) Search resut displays classification and term as per requirement, also for tooltip. 2) Redirection to classification detail page & term detail page 1) New-ui, redirection to tag detail page from Search result page & Entity detail page Thanks, Prasad Pawar
Review Request 74162: ATLAS-4610, ATLAS-4655: Classification/ Term: Add parent name for classification & term
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74162/ --- Review request for atlas, Farhan Khan, Jayendra Parab, Mandar Ambawane, Pinal Shah, Sharmadha Sainath, and Sheetal Shah. Bugs: https://issues.apache.org/jira/browse/ATLAS-4610 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-4610 Repository: atlas Description --- Backend: Add "glossaryDetails" attribute in RelationshipTypeDef "AtlasGlossarySemanticAssignment". This will help in showing the Glossary details of the associated Term in the Entity details page on UI. UI: The classification and term assignment section should display their parents if present, on the detail page. 1) Classification name will be displayed as "name"/ "name@parent"/ "name@(parent1,parent2,...)", on search result page, entity detail page, classification/term detail page (search result). 2)Term name will be displayed as "term@glossary", on search result page, entity detail page, classification/term detail page (search result). Same will be display on tooltip of classification and term. 3) Button Text on view related attribute change from "ok" to "Close" on term detail page . fixed 4) Button Text while removing term from related terms columns is change from "Ok" to "Cancle" on term detail page . fixed 5) New-ui, redirection to tag detail page from search result page & entity detail page, fixed Diffs - dashboardv2/public/css/scss/common.scss 2fb6a3a79 dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html ee4b9431f dashboardv2/public/js/utils/CommonViewFunction.js 4ce47a13d dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js bb629b4e4 dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 02606067b dashboardv2/public/js/views/glossary/TermRelationAttributeLayoutView.js ded1ab943 dashboardv2/public/js/views/schema/SchemaLayoutView.js efc8e9356 dashboardv2/public/js/views/search/SearchResultLayoutView.js 66466e21d dashboardv2/public/js/views/tag/TagLayoutView.js 7de7aea14 dashboardv3/public/css/scss/common.scss 036d2cfcc dashboardv3/public/js/router/Router.js 8e8cf1557 dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html b209a49e4 dashboardv3/public/js/utils/CommonViewFunction.js 7d8f03d2e dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 471be3bd7 dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 019cd9d3f dashboardv3/public/js/views/glossary/TermRelationAttributeLayoutView.js ded1ab943 dashboardv3/public/js/views/schema/SchemaLayoutView.js 1ae75d922 dashboardv3/public/js/views/search/SearchResultLayoutView.js d9d238353 dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 1883dfbd7 intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java f16cf25ed intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java c7de0638a intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java ae6932de5 repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 110c447ad repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 0ee86735d Diff: https://reviews.apache.org/r/74162/diff/1/ Testing --- On search result page: 1) Assigned classifications and terms are displayed as per requirement. 2) Tooltip for assigned classifications and terms are displayed as per requirement. 3) Redirection to classification detail page & term detail page On entity detail page: 1) Assigned classifications and terms are displayed as per requirement. 2) Propagated classifications are displayed as per requirement. 3) Tooltip for assigned classifications, terms and Propagated classifications are displayed as per requirement. 4) Redirection to classification detail page & term detail page. On Term detail page: 1) Search resut displays classification and term as per requirement, also for tooltip. 2) Redirection to classification detail page & term detail page. 3) Button text is changes to "Close", on view window of Related Terms Attributes. 4) Button text is changes to "Cancle", when we remove the assigned term on Related Terms column. 5) Glossary name is displayed as "term@glossary", on Related Terms column of Related terms tab. On Classification detail page: 1) Search resut displays classification and term as per requirement, also for tooltip. 2) Redirection to classification detail page & term detail page 1) New-ui, redirection to tag detail page from Search result page & Entity detail page Thanks, Prasad Pawar
