Re: Review Request 74163: ATLAS-4681: Relationship Search : SortBy is not working

2022-10-14 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74163/#review224793
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 12, 2022, 11:27 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74163/
> ---
> 
> (Updated Oct. 12, 2022, 11:27 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Nixon 
> Rodrigues.
> 
> 
> Bugs: ATLAS-4681
> https://issues.apache.org/jira/browse/ATLAS-4681
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:** Currently Relationship Search supports filtering results. There is 
> a sortBy and sortOrder param that is supposed to sort according to the 
> arguments provided.
> However currently it is return a random order of results even though the 
> filter is applied.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/RelationshipSearchProcessor.java
>  e4c07988d 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 7b36c6c75 
>   
> repository/src/test/java/org/apache/atlas/discovery/RelationshipSearchProcessorTest.java
>  3b2b59863 
> 
> 
> Diff: https://reviews.apache.org/r/74163/diff/1/
> 
> 
> Testing
> ---
> 
> Testcase added
> Precommit : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1253/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



Re: Review Request 74163: ATLAS-4681: Relationship Search : SortBy is not working

2022-10-12 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74163/
---

(Updated Oct. 12, 2022, 11:27 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Nixon Rodrigues.


Bugs: ATLAS-4681
https://issues.apache.org/jira/browse/ATLAS-4681


Repository: atlas


Description
---

**Issue:** Currently Relationship Search supports filtering results. There is a 
sortBy and sortOrder param that is supposed to sort according to the arguments 
provided.
However currently it is return a random order of results even though the filter 
is applied.


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/RelationshipSearchProcessor.java
 e4c07988d 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
7b36c6c75 
  
repository/src/test/java/org/apache/atlas/discovery/RelationshipSearchProcessorTest.java
 3b2b59863 


Diff: https://reviews.apache.org/r/74163/diff/1/


Testing (updated)
---

Testcase added
Precommit : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1253/console


Thanks,

Pinal Shah



Review Request 74163: ATLAS-4681: Relationship Search : SortBy is not working

2022-10-12 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74163/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Nixon Rodrigues.


Bugs: ATLAS-4681
https://issues.apache.org/jira/browse/ATLAS-4681


Repository: atlas


Description
---

**Issue:** Currently Relationship Search supports filtering results. There is a 
sortBy and sortOrder param that is supposed to sort according to the arguments 
provided.
However currently it is return a random order of results even though the filter 
is applied.


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/RelationshipSearchProcessor.java
 e4c07988d 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
7b36c6c75 
  
repository/src/test/java/org/apache/atlas/discovery/RelationshipSearchProcessorTest.java
 3b2b59863 


Diff: https://reviews.apache.org/r/74163/diff/1/


Testing
---

Testcase added


Thanks,

Pinal Shah