Re: Review Request 74562: ATLAS-4788 : Kafka password is in clear text in application.properties

2023-11-06 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74562/#review225936
---


Ship it!




Ship It!

- Mandar Ambawane


On Nov. 6, 2023, 11:13 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74562/
> ---
> 
> (Updated Nov. 6, 2023, 11:13 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Paresh Devalia, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4788
> https://issues.apache.org/jira/browse/ATLAS-4788
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> atlas.jaas.KafkaClient.option.username=username
> atlas.jaas.KafkaClient.option.password=
> 
> We have to encrypt this passsword using jceks file
> 
> ./cputil.py  -k atlas.jaas.KafkaClient.option.password -p P@$$w0rd -r 
> jceks://file/home/project/atlas/kafka.jceks
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/utils/KafkaUtils.java 167442259 
>   common/src/test/java/org/apache/atlas/utils/KafkaUtilsTest.java 562e28ae1 
> 
> 
> Diff: https://reviews.apache.org/r/74562/diff/10/
> 
> 
> Testing
> ---
> 
> test case added
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1498/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 74562: ATLAS-4788 : Kafka password is in clear text in application.properties

2023-11-06 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74562/
---

(Updated Nov. 6, 2023, 11:13 a.m.)


Review request for atlas, Jayendra Parab, Paresh Devalia, and Sheetal Shah.


Bugs: ATLAS-4788
https://issues.apache.org/jira/browse/ATLAS-4788


Repository: atlas


Description
---

atlas.jaas.KafkaClient.option.username=username
atlas.jaas.KafkaClient.option.password=

We have to encrypt this passsword using jceks file

./cputil.py  -k atlas.jaas.KafkaClient.option.password -p P@$$w0rd -r 
jceks://file/home/project/atlas/kafka.jceks


Diffs
-

  common/src/main/java/org/apache/atlas/utils/KafkaUtils.java 167442259 
  common/src/test/java/org/apache/atlas/utils/KafkaUtilsTest.java 562e28ae1 


Diff: https://reviews.apache.org/r/74562/diff/10/


Testing
---

test case added
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1498/consoleFull


Thanks,

chaitali