[jira] [Resolved] (ATLAS-4151) FixedBufferList: Change Log Level to Debug
[ https://issues.apache.org/jira/browse/ATLAS-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Mestry resolved ATLAS-4151. Resolution: Fixed > FixedBufferList: Change Log Level to Debug > -- > > Key: ATLAS-4151 > URL: https://issues.apache.org/jira/browse/ATLAS-4151 > Project: Atlas > Issue Type: Bug >Affects Versions: trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Trivial > Fix For: trunk > > Attachments: > ATLAS-4151-FixedBufferList-Change-Log-Level-to-Debug.patch > > > *Background* > Existing implementation emits updates from _FixedBufferList_ indicating inner > working. This fills logs with lot of entries that are not useful for > debugging. > *Solution* > Change the log level to _debug_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4151) FixedBufferList: Change Log Level to Debug
[ https://issues.apache.org/jira/browse/ATLAS-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281963#comment-17281963 ] ASF subversion and git services commented on ATLAS-4151: Commit 73c9a2700a39fb8a3a749b4a3c046fb3caf7b035 in atlas's branch refs/heads/branch-2.0 from Ashutosh Mestry [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=73c9a27 ] ATLAS-4151: FixedBufferList: Change Log Level to Debug > FixedBufferList: Change Log Level to Debug > -- > > Key: ATLAS-4151 > URL: https://issues.apache.org/jira/browse/ATLAS-4151 > Project: Atlas > Issue Type: Bug >Affects Versions: trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Trivial > Fix For: trunk > > Attachments: > ATLAS-4151-FixedBufferList-Change-Log-Level-to-Debug.patch > > > *Background* > Existing implementation emits updates from _FixedBufferList_ indicating inner > working. This fills logs with lot of entries that are not useful for > debugging. > *Solution* > Change the log level to _debug_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4151) FixedBufferList: Change Log Level to Debug
[ https://issues.apache.org/jira/browse/ATLAS-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281917#comment-17281917 ] Ashutosh Mestry commented on ATLAS-4151: PC: Build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/385/ > FixedBufferList: Change Log Level to Debug > -- > > Key: ATLAS-4151 > URL: https://issues.apache.org/jira/browse/ATLAS-4151 > Project: Atlas > Issue Type: Bug >Affects Versions: trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Trivial > Fix For: trunk > > Attachments: > ATLAS-4151-FixedBufferList-Change-Log-Level-to-Debug.patch > > > *Background* > Existing implementation emits updates from _FixedBufferList_ indicating inner > working. This fills logs with lot of entries that are not useful for > debugging. > *Solution* > Change the log level to _debug_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4151) FixedBufferList: Change Log Level to Debug
[ https://issues.apache.org/jira/browse/ATLAS-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281959#comment-17281959 ] ASF subversion and git services commented on ATLAS-4151: Commit 2105d5a2d15502e00eda8b1c657952f5ee96cb94 in atlas's branch refs/heads/master from Ashutosh Mestry [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=2105d5a ] ATLAS-4151: FixedBufferList: Change Log Level to Debug > FixedBufferList: Change Log Level to Debug > -- > > Key: ATLAS-4151 > URL: https://issues.apache.org/jira/browse/ATLAS-4151 > Project: Atlas > Issue Type: Bug >Affects Versions: trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Trivial > Fix For: trunk > > Attachments: > ATLAS-4151-FixedBufferList-Change-Log-Level-to-Debug.patch > > > *Background* > Existing implementation emits updates from _FixedBufferList_ indicating inner > working. This fills logs with lot of entries that are not useful for > debugging. > *Solution* > Change the log level to _debug_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4113) Atlas UI: Entity Lineage Details Box layout rendering and centring issue.
[ https://issues.apache.org/jira/browse/ATLAS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nixon Rodrigues updated ATLAS-4113: --- Fix Version/s: 2.2.0 > Atlas UI: Entity Lineage Details Box layout rendering and centring issue. > - > > Key: ATLAS-4113 > URL: https://issues.apache.org/jira/browse/ATLAS-4113 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Nixon Rodrigues >Assignee: Prasad P. Pawar >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: > 0001-Atlas-4113-UI-Entity-Lineage-Details-Box-layout-rend.patch, > Atlas-4113_1.png, Atlas-4113_2.png, entity-detailpage.png > > > The lineage layout doesn't seem to be centred on the page, also there is an > effect where the lineage appears from top-right. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4133) [Atlas: Glossary Term Bulk Import] Disable the option to download upload template when category is chosen in glossary page
[ https://issues.apache.org/jira/browse/ATLAS-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prasad P. Pawar updated ATLAS-4133: --- Attachment: Atlas-4133_1.png Atlas-4133_2.png > [Atlas: Glossary Term Bulk Import] Disable the option to download upload > template when category is chosen in glossary page > -- > > Key: ATLAS-4133 > URL: https://issues.apache.org/jira/browse/ATLAS-4133 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Reporter: Dharshana M Krishnamoorthy >Assignee: Prasad P. Pawar >Priority: Major > Attachments: > 0001-Atlas-4133-UI-Glossary-Term-Bulk-Import-Disable-the-.patch, > Atlas-4133_1.png, Atlas-4133_2.png, Screenshot 2021-02-03 at 5.27.03 PM.png > > > Since we support only bulk import of glossary-terms, it will be good to > disable the option to download and import template in UI > !Screenshot 2021-02-03 at 5.27.03 PM.png|width=389,height=225! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ATLAS-4135) [Atlas: Glossary Term Bulk Import] It will be good to ignore the glossaries and terms that are already present instead of failing the bulk import
[
https://issues.apache.org/jira/browse/ATLAS-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mandar Ambawane reassigned ATLAS-4135:
--
Assignee: Mandar Ambawane
> [Atlas: Glossary Term Bulk Import] It will be good to ignore the glossaries
> and terms that are already present instead of failing the bulk import
> -
>
> Key: ATLAS-4135
> URL: https://issues.apache.org/jira/browse/ATLAS-4135
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: Screenshot 2021-02-04 at 7.06.56 PM.png
>
>
> Consider the following scenario:
> Already available glossaries and terms:
> glossary_1 ==> term_1
> glossary_1 ==> term_2
> glossary_2 ==> term_1
> glossary_2 ==> term_2
>
> Now if the user is performing a bulk import and if glossary_1 ==> term_1 is
> part of the input, currently the call fails.
> {code:java}
> {errorCode: "ATLAS-500-00-016", errorMessage: "Error occurred while creating
> glossary term: {0}",…}errorCause: "Glossary term with qualifiedName
> term_1@aglossary_01 already exists"errorCode: "ATLAS-500-00-016"errorMessage:
> "Error occurred while creating glossary term: {0}" {code}
> Expectation:
> If it already exists, then just update the other field values eg, long
> description and the linked terms and do not fail
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-4113) Atlas UI: Entity Lineage Details Box layout rendering and centring issue.
[ https://issues.apache.org/jira/browse/ATLAS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281772#comment-17281772 ] Durga Kadam commented on ATLAS-4113: +1 patch is working fine. > Atlas UI: Entity Lineage Details Box layout rendering and centring issue. > - > > Key: ATLAS-4113 > URL: https://issues.apache.org/jira/browse/ATLAS-4113 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Nixon Rodrigues >Assignee: Prasad P. Pawar >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: > 0001-Atlas-4113-UI-Entity-Lineage-Details-Box-layout-rend.patch, > Atlas-4113_1.png, Atlas-4113_2.png, entity-detailpage.png > > > The lineage layout doesn't seem to be centred on the page, also there is an > effect where the lineage appears from top-right. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4133) [Atlas: Glossary Term Bulk Import] Disable the option to download upload template when category is chosen in glossary page
[ https://issues.apache.org/jira/browse/ATLAS-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281767#comment-17281767 ] Prasad P. Pawar commented on ATLAS-4133: Hi, The fix is provided in the available patch. > [Atlas: Glossary Term Bulk Import] Disable the option to download upload > template when category is chosen in glossary page > -- > > Key: ATLAS-4133 > URL: https://issues.apache.org/jira/browse/ATLAS-4133 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Reporter: Dharshana M Krishnamoorthy >Assignee: Prasad P. Pawar >Priority: Major > Attachments: > 0001-Atlas-4133-UI-Glossary-Term-Bulk-Import-Disable-the-.patch, Screenshot > 2021-02-03 at 5.27.03 PM.png > > > Since we support only bulk import of glossary-terms, it will be good to > disable the option to download and import template in UI > !Screenshot 2021-02-03 at 5.27.03 PM.png|width=389,height=225! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4133) [Atlas: Glossary Term Bulk Import] Disable the option to download upload template when category is chosen in glossary page
[ https://issues.apache.org/jira/browse/ATLAS-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281780#comment-17281780 ] Durga Kadam commented on ATLAS-4133: +1 patch is working fine. > [Atlas: Glossary Term Bulk Import] Disable the option to download upload > template when category is chosen in glossary page > -- > > Key: ATLAS-4133 > URL: https://issues.apache.org/jira/browse/ATLAS-4133 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Reporter: Dharshana M Krishnamoorthy >Assignee: Prasad P. Pawar >Priority: Major > Attachments: > 0001-Atlas-4133-UI-Glossary-Term-Bulk-Import-Disable-the-.patch, > Atlas-4133_1.png, Atlas-4133_2.png, Screenshot 2021-02-03 at 5.27.03 PM.png > > > Since we support only bulk import of glossary-terms, it will be good to > disable the option to download and import template in UI > !Screenshot 2021-02-03 at 5.27.03 PM.png|width=389,height=225! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-4151) FixedBufferList: Change Log Level to Debug
Ashutosh Mestry created ATLAS-4151: -- Summary: FixedBufferList: Change Log Level to Debug Key: ATLAS-4151 URL: https://issues.apache.org/jira/browse/ATLAS-4151 Project: Atlas Issue Type: Bug Affects Versions: trunk Reporter: Ashutosh Mestry Assignee: Ashutosh Mestry Fix For: trunk *Background* Existing implementation emits updates from _FixedBufferList_ indicating inner working. This fills logs with lot of entries that are not useful for debugging. *Solution* Change the log level to _debug_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4151) FixedBufferList: Change Log Level to Debug
[ https://issues.apache.org/jira/browse/ATLAS-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281889#comment-17281889 ] Sarath Subramanian commented on ATLAS-4151: --- Thanks [~amestry]. +1 > FixedBufferList: Change Log Level to Debug > -- > > Key: ATLAS-4151 > URL: https://issues.apache.org/jira/browse/ATLAS-4151 > Project: Atlas > Issue Type: Bug >Affects Versions: trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Trivial > Fix For: trunk > > Attachments: > ATLAS-4151-FixedBufferList-Change-Log-Level-to-Debug.patch > > > *Background* > Existing implementation emits updates from _FixedBufferList_ indicating inner > working. This fills logs with lot of entries that are not useful for > debugging. > *Solution* > Change the log level to _debug_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4151) FixedBufferList: Change Log Level to Debug
[ https://issues.apache.org/jira/browse/ATLAS-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Mestry updated ATLAS-4151: --- Attachment: ATLAS-4151-FixedBufferList-Change-Log-Level-to-Debug.patch > FixedBufferList: Change Log Level to Debug > -- > > Key: ATLAS-4151 > URL: https://issues.apache.org/jira/browse/ATLAS-4151 > Project: Atlas > Issue Type: Bug >Affects Versions: trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Trivial > Fix For: trunk > > Attachments: > ATLAS-4151-FixedBufferList-Change-Log-Level-to-Debug.patch > > > *Background* > Existing implementation emits updates from _FixedBufferList_ indicating inner > working. This fills logs with lot of entries that are not useful for > debugging. > *Solution* > Change the log level to _debug_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook
[ https://issues.apache.org/jira/browse/ATLAS-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282237#comment-17282237 ] ASF subversion and git services commented on ATLAS-4127: Commit f848c9761bd340c9cbb790254420506d97c8e6b4 in atlas's branch refs/heads/master from Deep Singh [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f848c97 ] ATLAS-4127: Optimize Hive table calls in Atlas Hook Signed-off-by: Sarath Subramanian > Reduce number of Hive table calls in Atlas Hook > --- > > Key: ATLAS-4127 > URL: https://issues.apache.org/jira/browse/ATLAS-4127 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Deep Singh >Assignee: Deep Singh >Priority: Major > Labels: hive-hooks > > In Atlas Hive bridge, while calculating processQualifiedName, all partitions > are processed. > For each partition, a hive call is made to get table details. Since multiple > partitions can belong to the same table, there is a scope for improvement by > avoiding repeated hive calls for the same table information. > This improvement becomes crucial particularly in the case where there are > several partitions for a single table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4138) While adding Classification to an entity, if user select and deselect the 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with text "Please fil
[ https://issues.apache.org/jira/browse/ATLAS-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282232#comment-17282232 ] ASF subversion and git services commented on ATLAS-4138: Commit e616779727e64d632b1414ecea08de3239ac3bac in atlas's branch refs/heads/master from prasad pawar [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e616779 ] ATLAS-4138:UI:While adding Classification to an entity, if user select and deselect the 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with text 'Please fill the details' Fixed Signed-off-by: Nikhil Bonte > While adding Classification to an entity, if user select and deselect the > 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with > text "Please fill the details" > -- > > Key: ATLAS-4138 > URL: https://issues.apache.org/jira/browse/ATLAS-4138 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Durga Kadam >Assignee: Prasad P. Pawar >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: > 0001-ATLAS-4138-UI-While-adding-Classification-to-an-enti.patch, > Validation_required_on_Add_button.webm > > > Steps to Reproduce the bugs:: > # Go to any entity detail page > # Click on Add Classification > # Click the checkbox - Add Validity Period (do not add any timestamp) > # Remove/Deselect the checkbox- Add Validity Period > # Click on Add button > Expected:: Classification should get added > Actual:: Keeps on showing the message "Please fill the details" > NOTE:: Until and unless user removes the validity input boxes it keeps on > showing the same message. We need to put a validation on Add button. > PFA evidence files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4138) While adding Classification to an entity, if user select and deselect the 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with text "Please fil
[ https://issues.apache.org/jira/browse/ATLAS-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282230#comment-17282230 ] Nikhil P Bonte commented on ATLAS-4138: --- +1 for the patch, thanks [~prasadpp13] . > While adding Classification to an entity, if user select and deselect the > 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with > text "Please fill the details" > -- > > Key: ATLAS-4138 > URL: https://issues.apache.org/jira/browse/ATLAS-4138 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Durga Kadam >Assignee: Prasad P. Pawar >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: > 0001-ATLAS-4138-UI-While-adding-Classification-to-an-enti.patch, > Validation_required_on_Add_button.webm > > > Steps to Reproduce the bugs:: > # Go to any entity detail page > # Click on Add Classification > # Click the checkbox - Add Validity Period (do not add any timestamp) > # Remove/Deselect the checkbox- Add Validity Period > # Click on Add button > Expected:: Classification should get added > Actual:: Keeps on showing the message "Please fill the details" > NOTE:: Until and unless user removes the validity input boxes it keeps on > showing the same message. We need to put a validation on Add button. > PFA evidence files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook
[ https://issues.apache.org/jira/browse/ATLAS-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282238#comment-17282238 ] ASF subversion and git services commented on ATLAS-4127: Commit 5b3b0da9e95830c8cf6330bb218993717de9e0ff in atlas's branch refs/heads/branch-2.0 from Deep Singh [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5b3b0da ] ATLAS-4127: Optimize Hive table calls in Atlas Hook Signed-off-by: Sarath Subramanian (cherry picked from commit f848c9761bd340c9cbb790254420506d97c8e6b4) > Reduce number of Hive table calls in Atlas Hook > --- > > Key: ATLAS-4127 > URL: https://issues.apache.org/jira/browse/ATLAS-4127 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Deep Singh >Assignee: Deep Singh >Priority: Major > Labels: hive-hooks > > In Atlas Hive bridge, while calculating processQualifiedName, all partitions > are processed. > For each partition, a hive call is made to get table details. Since multiple > partitions can belong to the same table, there is a scope for improvement by > avoiding repeated hive calls for the same table information. > This improvement becomes crucial particularly in the case where there are > several partitions for a single table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook
[ https://issues.apache.org/jira/browse/ATLAS-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-4127. --- Resolution: Fixed > Reduce number of Hive table calls in Atlas Hook > --- > > Key: ATLAS-4127 > URL: https://issues.apache.org/jira/browse/ATLAS-4127 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Deep Singh >Assignee: Deep Singh >Priority: Major > Labels: hive-hooks > Fix For: 3.0.0, 2.2.0 > > > In Atlas Hive bridge, while calculating processQualifiedName, all partitions > are processed. > For each partition, a hive call is made to get table details. Since multiple > partitions can belong to the same table, there is a scope for improvement by > avoiding repeated hive calls for the same table information. > This improvement becomes crucial particularly in the case where there are > several partitions for a single table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook
[ https://issues.apache.org/jira/browse/ATLAS-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4127: -- Fix Version/s: 2.2.0 3.0.0 > Reduce number of Hive table calls in Atlas Hook > --- > > Key: ATLAS-4127 > URL: https://issues.apache.org/jira/browse/ATLAS-4127 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Deep Singh >Assignee: Deep Singh >Priority: Major > Labels: hive-hooks > Fix For: 3.0.0, 2.2.0 > > > In Atlas Hive bridge, while calculating processQualifiedName, all partitions > are processed. > For each partition, a hive call is made to get table details. Since multiple > partitions can belong to the same table, there is a scope for improvement by > avoiding repeated hive calls for the same table information. > This improvement becomes crucial particularly in the case where there are > several partitions for a single table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 73076: Deferred Actions Implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 10, 2021, 6:40 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian. Changes --- Updated decription to include improvements with latest patch. Bugs: ATLAS-3919 https://issues.apache.org/jira/browse/ATLAS-3919 Repository: atlas Description (updated) --- **Approach** Model: _TaskDef_ - Definition of task. - Contains status of the task for querying. _AbstractTask_ - Takes TaskDef as input and calls run. - The concrete tasks has logic for doing real work. _TaskFactory_ - Creates tasks given task type. - Enumerates all the tasks that are supported. _TaskManagement_ - Component/Service. Constructed after all existing components are constructed. - Provides a simple interface for adding tasks. - Processes tasks that are in pending state. - Supports HA mode, where the tasks are not executed on passive instance. _TaskManagement.Registry_ - CRUD operations with TaskDef vertex. _TaskManagement.Processor_ - Provides mechanism for provides single queue for processing tasks in a way that is non-blocking. - Uses task type and the associated TaskFactory to construct concrete task. Changes to _EntityGraphMapper_ There are 3 new methods added that use portion of existing classification propagation logic and create a separate method. New class _EntityGraphMapperWithTasks_ acts as a proxy for EntityGraphMapper. All calls that operate without tasks get channeled to the existing implementation. The ones involving tasks are modified to use the new task framework. **Concurrent Changes to Classifications** Via REST APIs and operations from web UI, it is possible to make changes to the same entity. This situation will be more pronounced in the new setup. The existing framework has _GraphTransactionInterceptor.lockObjectAndReleasePostCommit_. This provides ReentrantLock on an entity that is identified by the supplied GUID. This will cause a lock on the entity and all the impacted vertices. This has potential for adversely impacting scalability. **New Updates** - Separate log file for tasks. - TaskDef now has _startTime_ and _endTime_ to indicating start and end of task. - Refactored parameter passing during task creation. It now accepts Map instead of Object array. Each task creates its own set of parameters. - Reduced use of TASKS_ENABLE flag checks. Diffs - common/src/main/java/org/apache/atlas/repository/Constants.java 61abfcaca distro/src/conf/atlas-log4j.xml 7df963eb2 intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a intg/src/main/java/org/apache/atlas/model/tasks/TaskDef.java PRE-CREATION intg/src/main/java/org/apache/atlas/type/AtlasType.java b30b483e0 intg/src/main/java/org/apache/atlas/utils/AtlasJson.java abeddf640 intg/src/test/resources/atlas-application.properties 7e74d5107 repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 86b369fc9 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java ce58e9aa4 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2cfcc0bc1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapperWithTasks.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagateTaskFactory.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagationTasks.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/AbstractTask.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskExecutor.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskFactory.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskLogger.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskManagement.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java PRE-CREATION repository/src/main/java/org/apache/atlas/util/BeanUtilRepo.java PRE-CREATION repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java 84e9bfa04 repository/src/test/java/org/apache/atlas/tasks/TaskExecutorTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/tasks/TaskManagementTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/tasks/TaskRegistryTest.java PRE-CREATION server-api/src/main/java/org/apache/atlas/RequestContext.java 7de3536f4
[jira] [Commented] (ATLAS-4109) Advanced Search: Glossary Clause: More Efficient Structure
[ https://issues.apache.org/jira/browse/ATLAS-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282257#comment-17282257 ] ASF subversion and git services commented on ATLAS-4109: Commit ed2926ece4d1ba7a3fa773f527853253bd3352ba in atlas's branch refs/heads/master from Ashutosh Mestry [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ed2926e ] ATLAS-4109: Advanced Search: Glossary: More Efficient Structure > Advanced Search: Glossary Clause: More Efficient Structure > -- > > Key: ATLAS-4109 > URL: https://issues.apache.org/jira/browse/ATLAS-4109 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Major > Attachments: > ATLAS-4109-Advanced-Search-Glossary-terms-clause-cha.patch > > > *Background* > Glossary support was added to Atlas recently. Existing clause for fetching > entities linked to a glossary could be improved. > ***Solution* > * Use edge traversal instead of vertex. > * Remove dedup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 73179: ATLAS-4113: Atlas UI: Entity Lineage Details Box layout rendering and centring issue.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73179/#review222580 --- Ship it! Ship It! - Sarath Subramanian On Feb. 8, 2021, 11:02 p.m., Prasad Pawar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73179/ > --- > > (Updated Feb. 8, 2021, 11:02 p.m.) > > > Review request for atlas, Jayendra Parab, keval bhatt, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-4113 > https://issues.apache.org/jira/browse/ATLAS-4113 > > > Repository: atlas > > > Description > --- > > The lineage layout doesn't seem to be centred on the page, also there is an > effect where the lineage appears from top-right. > > This patch has the following fix: > 1) Entity Lineage Detail box layout position fix. > 2) White space from Detail box removed. > 3) Add option Display full name in the Lineage settings panel. > 4) https://issues.apache.org/jira/browse/ATLAS-4074 > > > Diffs > - > > dashboardv2/public/css/scss/graph.scss 19636c5 > dashboardv2/public/js/external_lib/atlas-lineage/dist/index.js e82cb48 > dashboardv2/public/js/external_lib/atlas-lineage/dist/styles.css 2cd29ed > dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html f6f61e2 > dashboardv2/public/js/templates/graph/TypeSystemTreeView_tmpl.html 005c061 > dashboardv2/public/js/views/graph/LineageLayoutView.js aa26580 > dashboardv2/public/js/views/graph/TypeSystemTreeView.js 90734a4 > dashboardv3/public/css/scss/graph.scss ee774ce > dashboardv3/public/js/external_lib/atlas-lineage/dist/index.js e82cb48 > dashboardv3/public/js/external_lib/atlas-lineage/dist/styles.css 2cd29ed > dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html f6f61e2 > dashboardv3/public/js/templates/graph/TypeSystemTreeView_tmpl.html 005c061 > dashboardv3/public/js/views/graph/LineageLayoutView.js aa26580 > dashboardv3/public/js/views/graph/TypeSystemTreeView.js 90734a4 > > > Diff: https://reviews.apache.org/r/73179/diff/1/ > > > Testing > --- > > Tested Lineage View, Entity details panel layout position change to right, > Entity details panel remove white space, Display full name option in lineage > setting panel shows label in full name or trunc name, Export image selected > node color fix. > > > Thanks, > > Prasad Pawar > >
[jira] [Commented] (ATLAS-4138) While adding Classification to an entity, if user select and deselect the 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with text "Please fil
[ https://issues.apache.org/jira/browse/ATLAS-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282233#comment-17282233 ] ASF subversion and git services commented on ATLAS-4138: Commit de82208bf630d9e7ed8d02ccf8ddc8d6a47d46ec in atlas's branch refs/heads/branch-2.0 from prasad pawar [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=de82208 ] ATLAS-4138:UI:While adding Classification to an entity, if user select and deselect the 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with text 'Please fill the details' Fixed Signed-off-by: Nikhil Bonte (cherry picked from commit e616779727e64d632b1414ecea08de3239ac3bac) > While adding Classification to an entity, if user select and deselect the > 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with > text "Please fill the details" > -- > > Key: ATLAS-4138 > URL: https://issues.apache.org/jira/browse/ATLAS-4138 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Durga Kadam >Assignee: Prasad P. Pawar >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: > 0001-ATLAS-4138-UI-While-adding-Classification-to-an-enti.patch, > Validation_required_on_Add_button.webm > > > Steps to Reproduce the bugs:: > # Go to any entity detail page > # Click on Add Classification > # Click the checkbox - Add Validity Period (do not add any timestamp) > # Remove/Deselect the checkbox- Add Validity Period > # Click on Add button > Expected:: Classification should get added > Actual:: Keeps on showing the message "Please fill the details" > NOTE:: Until and unless user removes the validity input boxes it keeps on > showing the same message. We need to put a validation on Add button. > PFA evidence files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4125) Create JavaPatch to add new supertypes to existing entities
[ https://issues.apache.org/jira/browse/ATLAS-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282235#comment-17282235 ] ASF subversion and git services commented on ATLAS-4125: Commit f32f7352f9b1c5871f48e9ff91af4db61872f055 in atlas's branch refs/heads/branch-2.0 from Radhika Kundam [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f32f735 ] ATLAS-4125: JavaPatch to add new supertypes to existing entities #2 fix Unit tests Signed-off-by: Sarath Subramanian (cherry picked from commit a531e8c685a0758e13d2862a98284110bc8faf22) > Create JavaPatch to add new supertypes to existing entities > --- > > Key: ATLAS-4125 > URL: https://issues.apache.org/jira/browse/ATLAS-4125 > Project: Atlas > Issue Type: Task > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Radhika Kundam >Assignee: Radhika Kundam >Priority: Major > Fix For: 3.0.0, 2.2.0 > > > As part of ATLAS-4098 introduced adding new super type for existing entity > type which is done by new action type "ADD_SUPER_TYPES" for Typedef patches. > With this patch, it will update entityType's definition with new superTypes. > To provide backward compatibility for the above feature, we need to update > __superTypes for below. > 1. All vertices with type of updated entityDef > 2. All vertices of all sub-types of updated entityDef -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4125) Create JavaPatch to add new supertypes to existing entities
[ https://issues.apache.org/jira/browse/ATLAS-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282234#comment-17282234 ] ASF subversion and git services commented on ATLAS-4125: Commit a531e8c685a0758e13d2862a98284110bc8faf22 in atlas's branch refs/heads/master from Radhika Kundam [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=a531e8c ] ATLAS-4125: JavaPatch to add new supertypes to existing entities #2 fix Unit tests Signed-off-by: Sarath Subramanian > Create JavaPatch to add new supertypes to existing entities > --- > > Key: ATLAS-4125 > URL: https://issues.apache.org/jira/browse/ATLAS-4125 > Project: Atlas > Issue Type: Task > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Radhika Kundam >Assignee: Radhika Kundam >Priority: Major > Fix For: 3.0.0, 2.2.0 > > > As part of ATLAS-4098 introduced adding new super type for existing entity > type which is done by new action type "ADD_SUPER_TYPES" for Typedef patches. > With this patch, it will update entityType's definition with new superTypes. > To provide backward compatibility for the above feature, we need to update > __superTypes for below. > 1. All vertices with type of updated entityDef > 2. All vertices of all sub-types of updated entityDef -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4109) Advanced Search: Glossary Clause: More Efficient Structure
[ https://issues.apache.org/jira/browse/ATLAS-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282262#comment-17282262 ] ASF subversion and git services commented on ATLAS-4109: Commit 47a2bb86fdb2d7207feee04fd9d0abb82fa1b46c in atlas's branch refs/heads/branch-2.0 from Ashutosh Mestry [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=47a2bb8 ] ATLAS-4109: Advanced Search: Glossary: More Efficient Structure > Advanced Search: Glossary Clause: More Efficient Structure > -- > > Key: ATLAS-4109 > URL: https://issues.apache.org/jira/browse/ATLAS-4109 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Major > Attachments: > ATLAS-4109-Advanced-Search-Glossary-terms-clause-cha.patch > > > *Background* > Glossary support was added to Atlas recently. Existing clause for fetching > entities linked to a glossary could be improved. > ***Solution* > * Use edge traversal instead of vertex. > * Remove dedup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 73076: Deferred Actions Implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 10, 2021, 6:25 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian. Changes --- Updates include: - Addressed review comments. - Rebased. - Manual tests. Bugs: ATLAS-3919 https://issues.apache.org/jira/browse/ATLAS-3919 Repository: atlas Description --- **Approach** Model: _TaskDef_ - Definition of task. - Contains status of the task for querying. _AbstractTask_ - Takes TaskDef as input and calls run. - The concrete tasks has logic for doing real work. _TaskFactory_ - Creates tasks given task type. - Enumerates all the tasks that are supported. _TaskManagement_ - Component/Service. Constructed after all existing components are constructed. - Provides a simple interface for adding tasks. - Processes tasks that are in pending state. - Supports HA mode, where the tasks are not executed on passive instance. _TaskManagement.Registry_ - CRUD operations with TaskDef vertex. _TaskManagement.Processor_ - Provides mechanism for provides single queue for processing tasks in a way that is non-blocking. - Uses task type and the associated TaskFactory to construct concrete task. Changes to _EntityGraphMapper_ There are 3 new methods added that use portion of existing classification propagation logic and create a separate method. New class _EntityGraphMapperWithTasks_ acts as a proxy for EntityGraphMapper. All calls that operate without tasks get channeled to the existing implementation. The ones involving tasks are modified to use the new task framework. **Concurrent Changes to Classifications** Via REST APIs and operations from web UI, it is possible to make changes to the same entity. This situation will be more pronounced in the new setup. The existing framework has _GraphTransactionInterceptor.lockObjectAndReleasePostCommit_. This provides ReentrantLock on an entity that is identified by the supplied GUID. This will cause a lock on the entity and all the impacted vertices. This has potential for adversely impacting scalability. Diffs (updated) - common/src/main/java/org/apache/atlas/repository/Constants.java 61abfcaca distro/src/conf/atlas-log4j.xml 7df963eb2 intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a intg/src/main/java/org/apache/atlas/model/tasks/TaskDef.java PRE-CREATION intg/src/main/java/org/apache/atlas/type/AtlasType.java b30b483e0 intg/src/main/java/org/apache/atlas/utils/AtlasJson.java abeddf640 intg/src/test/resources/atlas-application.properties 7e74d5107 repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 86b369fc9 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java ce58e9aa4 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2cfcc0bc1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapperWithTasks.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagateTaskFactory.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagationTasks.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/AbstractTask.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskExecutor.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskFactory.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskLogger.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskManagement.java PRE-CREATION repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java PRE-CREATION repository/src/main/java/org/apache/atlas/util/BeanUtilRepo.java PRE-CREATION repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java 84e9bfa04 repository/src/test/java/org/apache/atlas/tasks/TaskExecutorTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/tasks/TaskManagementTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/tasks/TaskRegistryTest.java PRE-CREATION server-api/src/main/java/org/apache/atlas/RequestContext.java 7de3536f4 server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java bb7f8fcc4 test-tools/src/main/resources/log4j.properties 4db0598ad webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java e8fc111a6 webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 77422b2a5 Diff:
