[jira] [Updated] (ATLAS-1199) Atlas UI not loading after fresh build due to jquery-asBreadcrumbs plugin upgrade.

[Keval Bhatt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-1199:
---
Summary: Atlas UI not loading after fresh build due to jquery-asBreadcrumbs 
plugin upgrade.  (was: Atlas UI not loading after fresh build due to 
jquery-asBreadcrumbs plugin changes.)

> Atlas UI not loading after fresh build due to jquery-asBreadcrumbs plugin 
> upgrade.
> --
>
> Key: ATLAS-1199
> URL: https://issues.apache.org/jira/browse/ATLAS-1199
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Keval Bhatt
>Priority: Blocker
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1199.patch
>
>
> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> Found following error in browser console
> Overrides.js:22 Uncaught TypeError: Cannot set property 
> 'generateChildrenInfo' of undefined
> GET http://localhost:21000/js/libs/jquery-asBreadcrumbs/css/asBreadcrumbs.css 
> 404



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1199) Atlas UI not loading after fresh build due to jquery-asBreadcrumbs plugin changes.

[Keval Bhatt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-1199:
---
Attachment: ATLAS-1199.patch

> Atlas UI not loading after fresh build due to jquery-asBreadcrumbs plugin 
> changes.
> --
>
> Key: ATLAS-1199
> URL: https://issues.apache.org/jira/browse/ATLAS-1199
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Keval Bhatt
>Priority: Blocker
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-1199.patch
>
>
> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> Found following error in browser console
> Overrides.js:22 Uncaught TypeError: Cannot set property 
> 'generateChildrenInfo' of undefined
> GET http://localhost:21000/js/libs/jquery-asBreadcrumbs/css/asBreadcrumbs.css 
> 404



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Sarath Kumar Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150812
---




common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 
243)


In current design, Multiplicity attribute is overloaded to determine if an 
attribute can be optional, required, collection or set. These are broken down 
into granular attributes in this design. If the plan is to continue supporting 
existing REST APIs, what will be the mapping from this granular attributes to 
current one? 
eg. Required Collection or Optional Set. Which one takes precedence?


- Sarath Kumar Subramanian


On Sept. 28, 2016, 9:08 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 9:08 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   

[jira] [Resolved] (ATLAS-1201) using progaurd in android for cordova plugin

[Hemanth Yamijala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hemanth Yamijala resolved ATLAS-1201.
-
Resolution: Invalid

This is unlikely to be an Apache Atlas project issue. Could you please open 
this against the right project?

> using progaurd in android for cordova plugin
> 
>
> Key: ATLAS-1201
> URL: https://issues.apache.org/jira/browse/ATLAS-1201
> Project: Atlas
>  Issue Type: Bug
>Reporter: lokesh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1201) using progaurd in android for cordova plugin

[lokesh (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531731#comment-15531731
 ] 

lokesh commented on ATLAS-1201:
---

Hi,
Is there any way to apply the progaurd to the cordova plugins ?

> using progaurd in android for cordova plugin
> 
>
> Key: ATLAS-1201
> URL: https://issues.apache.org/jira/browse/ATLAS-1201
> Project: Atlas
>  Issue Type: Bug
>Reporter: lokesh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1201) using progaurd in android for cordova plugin

[lokesh (JIRA)]

lokesh created ATLAS-1201:
-

 Summary: using progaurd in android for cordova plugin
 Key: ATLAS-1201
 URL: https://issues.apache.org/jira/browse/ATLAS-1201
 Project: Atlas
  Issue Type: Bug
Reporter: lokesh






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

> On Sept. 29, 2016, 2:38 a.m., Madhan Neethiraj wrote:
> > common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java, line 35
> > 
> >
> > All type definitions, including AtlasEnumDef, have few common 
> > attributes - guid is one of them. Use of guids for objects can be helpful 
> > in many cases - like import/export; hence I included it for type-objects.

This is the response to earlier review comment by Suma.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150795
---


On Sept. 29, 2016, 4:08 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 4:08 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

> On Sept. 29, 2016, 3:46 a.m., Madhan Neethiraj wrote:
> > common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java, 
> > line 40
> > 
> >
> > version would be part of the object and not the object-id. Most APIs 
> > would deal with the current version of an object. A separate set of APIs 
> > would be required to retrieve earlier version(s) of an object.

This is the response to earlier review comment by Suma.


> On Sept. 29, 2016, 3:46 a.m., Madhan Neethiraj wrote:
> > common/src/main/java/org/apache/atlas/type/AtlasType.java, line 66
> > 
> >
> > AtlasBaseTypeDef sounds like a good to place to keep all type-related 
> > constants and utility methods. Will move in the next patch.

This is the response to earlier review comment by Suma.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150799
---


On Sept. 29, 2016, 4:08 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 29, 2016, 4:08 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/
---

(Updated Sept. 29, 2016, 4:08 a.m.)


Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.


Changes
---

Suma - thanks for the review comments. This patch addresses the comments.


Bugs: ATLAS-1171
https://issues.apache.org/jira/browse/ATLAS-1171


Repository: atlas


Description
---

ATLAS-1171: structured, high-level APIs - phase #1
- define data-strctures for use in the interface (REST, ..) to describe types 
and instances: in package org.apache.atlas.model
- implementation of runtime behaviour of types - create/validate/normalize 
instances (i.e. from values in REST to typed-values): in package 
org.apache.atlas.type

I think phase #1 in providing high-level APIs is now ready to review and 
commit. Please note this patch only includes new files and there are no changes 
to any existing code. Please review.

Next steps:
- Phase #2 will include the REST API and the modules that deal with persistence 
of type and instance objects (defined in phase #1) in Tital Graph database.
- Phase #3 will replace current REST API implementation to use the new APIs, 
while continuing to provide the current REST API.
- GUI updates to use the new API can  begin once phase #2 goes in.


Diffs (updated)
-

  common/pom.xml e3b6465 
  common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
PRE-CREATION 
  
common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEntityType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasStructType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDateType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasIntType.java PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasLongType.java 
PRE-CREATION 
  

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150799
---




common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java (line 
40)


version would be part of the object and not the object-id. Most APIs would 
deal with the current version of an object. A separate set of APIs would be 
required to retrieve earlier version(s) of an object.



common/src/main/java/org/apache/atlas/type/AtlasType.java (line 49)


AtlasType implementations return typed values - like:

Boolean AtlasBooleanType.createDefaultValue();
Integer AtlasIntType.createDefaultValue();



common/src/main/java/org/apache/atlas/type/AtlasType.java (line 66)


AtlasBaseTypeDef sounds like a good to place to keep all type-related 
constants and utility methods. Will move in the next patch.


- Madhan Neethiraj


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   

[jira] [Created] (ATLAS-1200) Enhance the Exception mechanism

[Apoorv Naik (JIRA)]

Apoorv Naik created ATLAS-1200:
--

 Summary: Enhance the Exception mechanism
 Key: ATLAS-1200
 URL: https://issues.apache.org/jira/browse/ATLAS-1200
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 0.7-incubating, 0.8-incubating
Reporter: Apoorv Naik
Assignee: Apoorv Naik


Currently the error/exception messages are hand constructed all over the Atlas 
code base, making it hard to understand the origin of the problem. Also since 
Atlas is moving towards a more RESTful nature it's better to create a catalog 
for the error message with support for localization

Proposal:

Format: internal_error_code=http_status_code|error_description

e.g.
entity_not_found=404|Given entity doesn't exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ATLAS-1198) Move from Guice + Spring to only Spring

[Apoorv Naik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik reassigned ATLAS-1198:
--

Assignee: Apoorv Naik

> Move from Guice + Spring to only Spring
> ---
>
> Key: ATLAS-1198
> URL: https://issues.apache.org/jira/browse/ATLAS-1198
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating, 0.8-incubating
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>
> Right now we're using both Guice and Spring and dependency injection which is 
> not a ideal combination. As Atlas evolves as a product we can leverage the 
> spring framework to avoid re-inventing the wheel like caching, transaction 
> management etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Apoorv Naik]

> On Sept. 29, 2016, 2:38 a.m., Madhan Neethiraj wrote:
> > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 35
> > 
> >
> > updateEntity() is for full-update of an entity. A new API would be 
> > needed to support partial update. How about the following API?
> > 
> > AtlasEntity updateEntityAttributes(AtlasObjectId objId, Map > Object> atributes) throws AtlasException;
> > 
> > This API will only update the attributes given in the argument.

Can we introduce a HTTP PATCH API that takes in a JsonPatch for the 
corresponding type/entity ? Signature will be similar


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150795
---


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150795
---




common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java (line 35)


All type definitions, including AtlasEnumDef, have few common attributes - 
guid is one of them. Use of guids for objects can be helpful in many cases - 
like import/export; hence I included it for type-objects.



common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java (line 35)


updateEntity() is for full-update of an entity. A new API would be needed 
to support partial update. How about the following API?

AtlasEntity updateEntityAttributes(AtlasObjectId objId, Map 
atributes) throws AtlasException;

This API will only update the attributes given in the argument.



common/src/main/java/org/apache/atlas/api/PList.java (line 45)


Yes. I will update shortly.



common/src/main/java/org/apache/atlas/api/PList.java (line 48)


it is the number of records in the result. Given that this can be obtained 
from getList().size(), resultSize is not needed. I will remove this.



common/src/main/java/org/apache/atlas/api/PList.java (line 49)


I agree. I will change this to an enum shortly.


- Madhan Neethiraj


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java 

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150786
---




common/src/main/java/org/apache/atlas/type/AtlasType.java (line 49)


can use generics instead of Object


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150784
---




common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java (line 
40)


why is version removed?


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
> 

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150782
---




common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java (line 35)


why do we need GUIDs for types?


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150780
---




common/src/main/java/org/apache/atlas/type/AtlasType.java (line 66)


could be moved to ArrayType


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150778
---




common/src/main/java/org/apache/atlas/api/PList.java (line 48)


is resultSize = limit ?


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150777
---




common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java (line 35)


How are we differentiating between Partial updates  vs fullupdates?


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150775
---




common/src/main/java/org/apache/atlas/api/PList.java (line 45)


startIndex should be long


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150774
---




common/src/main/java/org/apache/atlas/api/PList.java (line 49)


sortType can be an enum.


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Suma Shivaprasad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150772
---




common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java (line 35)


Enums dont have a GUID.


- Suma Shivaprasad


On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> ---
> 
> (Updated Sept. 28, 2016, 6:43 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
> https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types 
> and instances: in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize 
> instances (i.e. from values in REST to typed-values): in package 
> org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and 
> commit. Please note this patch only includes new files and there are no 
> changes to any existing code. Please review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with 
> persistence of type and instance objects (defined in phase #1) in Tital Graph 
> database.
> - Phase #3 will replace current REST API implementation to use the new APIs, 
> while continuing to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
> PRE-CREATION 
>   
> common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
>  PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
> PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
> PRE-CREATION 
>   

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/
---

(Updated Sept. 28, 2016, 6:43 p.m.)


Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.


Changes
---

ATLAS-1171: structured, high-level APIs - phase #1
 - updated to handle multi-valued attributes: default-value, validation


Bugs: ATLAS-1171
https://issues.apache.org/jira/browse/ATLAS-1171


Repository: atlas


Description (updated)
---

ATLAS-1171: structured, high-level APIs - phase #1
- define data-strctures for use in the interface (REST, ..) to describe types 
and instances: in package org.apache.atlas.model
- implementation of runtime behaviour of types - create/validate/normalize 
instances (i.e. from values in REST to typed-values): in package 
org.apache.atlas.type

I think phase #1 in providing high-level APIs is now ready to review and 
commit. Please note this patch only includes new files and there are no changes 
to any existing code. Please review.

Next steps:
- Phase #2 will include the REST API and the modules that deal with persistence 
of type and instance objects (defined in phase #1) in Tital Graph database.
- Phase #3 will replace current REST API implementation to use the new APIs, 
while continuing to provide the current REST API.
- GUI updates to use the new API can  begin once phase #2 goes in.


Diffs (updated)
-

  common/pom.xml e3b6465 
  common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
PRE-CREATION 
  
common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEntityType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasStructType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDateType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasIntType.java PRE-CREATION 
  

Re: Rename trait to classification

[Mandy Chessell]

Hello Suma,
I like that idea.   How would glossary terms fit into this scheme?  Are 
they also a subclass of annotation?  We link terms to assets to indicate 
the semantic meaning of a data item.  However, we may also link a 
classification to a term to say any data item linked to this term is also 
linked to this classification.  This pattern is used by organizations that 
want consistent treatment of data across all data sets/repositories.  It 
is particularly useful when supporting a specific regulation that requires 
a particular type of data to be governed in a particular way.

This picture shows an example of a classification of "Sensitive" linked to 
a glossary term "Compensation Plan".  There are two specialisations of 
compensation plan in the glossary called "Annual Salary" and "Hourly Pay 
Rate".  These glossary terms are then linked to the schema of the data to 
identify that 45324 is a salary that should be considered sensitive.



All the best
Mandy
___
Mandy Chessell CBE FREng CEng FBCS
IBM Distinguished Engineer
IBM Analytics Group CTO Office

Master Inventor
Member of the IBM Academy of Technology
Visiting Professor, Department of Computer Science, University of 
Sheffield

Email: mandy_chess...@uk.ibm.com
LinkedIn: http://www.linkedin.com/pub/mandy-chessell/22/897/a49

Assistant: Janet Brooks - jsbrook...@uk.ibm.com



From:   Suma Shivaprasad 
To: dev@atlas.incubator.apache.org
Date:   27/09/2016 16:19
Subject:Re: Rename trait to classification



Thanks Mandy for the detailed explanation. To add to what David has 
already
stated,

We could expose two higher level ATLAS types/concepts which are based on
current Traits.

1. Classification - that are locked down and that have a classification
scheme to group together a set of classification concepts
2. Annotation - that are free form and are not locked down

So Traits could be renamed as Annotation and Classification is a
specialization of an Annotation with an additional classification scheme
associated with it.

Thoughts?

Suma





On Mon, Sep 26, 2016 at 5:48 AM, David Radley 
wrote:

> Hi Hermanth,
> I appreciate your feedback and openness. It was an interesting point you
> made about which roles were authoring traits and terms. I guess this is
> not something Atlas would police.
>
> The current traits could be :
> 1) locked down so only the governance team could update them; in that 
case
> they would be classifications that governance rules could act on.
>  or
> 2) Not locked down so a wider audience (business personas) could create
> them.
>
> I am suggesting:
> - renaming traits to classifications for use by the governance team.
> - using terms as glossary terms for use more widely by business users.
>
> Does this work - or am I missing something ?
>   all the best, David.
>
>
>
>
>
>
> From:   Hemanth Yamijala 
> To: dev@atlas.incubator.apache.org
> Date:   26/09/2016 13:09
> Subject:Re: Rename trait to classification
>
>
>
> Hi David,
>
> Reg. the point I made about sharing traits - I don't want to give an
> impression that this as an agreed upon point. Apologize if I conveyed
> that sense.
>
> It is a fact that Atlas today has two concepts that are slightly
> related: Traits (aka Tags) and Business Terms. The latter was new in
> 0.7. IMO, it is important that the Atlas community tries to converge
> on an unambiguous definition of these concepts as the product would be
> driven around these.
>
> With respect to this thread, I am trying to fit in whether
> "classification" is a new concept. Or it overlaps with one of the two
> existing ones (which we are trying to rename).
>
> I am certainly not a domain expert on this in any sense :-) - so
> hoping that others who are would provide guidance (@aahn - ping?).
>
> Thanks
> hemanth
>
> On Mon, Sep 26, 2016 at 2:59 PM, David Radley 
> wrote:
> > Hi Hermanth and Mandy ,
> > Thanks for your feedback.
> >
> > It does seem like these are de-facto industry terms in the governance
> > industry; the reason I say this is that looking around the web I see
> quite
> > a few uses of the words governance classification in different domains
> > (including in the Atlas documentation!).
> >
> > I was not aware of the idea that traits and terms would be authored by
> > different roles - thanks for your explanation. What is coming up for 
me
> is
> > :
> >
> > I think business users should be able to add new business terms (maybe
> > going through a workflow and a governance curator then sorting out
> > inconsistencies), as they are the most expert as the language they 
use.
> > Classifications could be authored by different teams, for example 
levels
> > of confidentiality (in Mandy's example) would be dictated by the
> > governance team. Governance rules would run on these classifications.
> >
> > You say "So, it is hard to use 

[jira] [Issue Comment Deleted] (ATLAS-916) Return system attributes in get entity definition

[David Kantor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Kantor updated ATLAS-916:
---
Comment: was deleted

(was: [~svimal2106] You've attached a patch but the item is still marked open.  
Is your fix ready for review?  If so, please change the status of this item to 
Patch Available, and create a review board request with your changes so they 
can be reviewed by the community.  Thanks...)

> Return system attributes in get entity definition
> -
>
> Key: ATLAS-916
> URL: https://issues.apache.org/jira/browse/ATLAS-916
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Shwetha G S
>Assignee: Vimal Sharma
> Attachments: ATLAS-916.patch
>
>
> Atlas should maintain system attributes created time, last modified time, 
> created by user and last modified by user for every entity. This information 
> should be returned in get entity definition



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-916) Return system attributes in get entity definition

[David Kantor (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529590#comment-15529590
 ] 

David Kantor commented on ATLAS-916:


[~svimal2106] You've attached a patch but the item is still marked open.  Is 
your fix ready for review?  If so, please change the status of this item to 
Patch Available, and create a review board request with your changes so they 
can be reviewed by the community.  Thanks...

> Return system attributes in get entity definition
> -
>
> Key: ATLAS-916
> URL: https://issues.apache.org/jira/browse/ATLAS-916
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Shwetha G S
>Assignee: Vimal Sharma
> Attachments: ATLAS-916.patch
>
>
> Atlas should maintain system attributes created time, last modified time, 
> created by user and last modified by user for every entity. This information 
> should be returned in get entity definition



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: apache-atlas-nightly #429

[Apache Jenkins Server]

See 

Changes:

[sshivalingamurthy] ATLAS-1174 Framework to apply updates to types in the 
type-system

--
[...truncated 9236 lines...]
127.0.0.1 - - [28/Sep/2016:12:48:00 +] "GET 
/api/atlas/lineage/hive/table/default.tableouhrksvk7z@primary/inputs/graph 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:04 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewzy5sy6ws0@primary:1475066883000-%3E:PATH_WRITE
 HTTP/1.1" 404 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewzy5sy6ws0@primary:1475066883000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewzy5sy6ws0@primary:1475066883000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities/c1c782b9-3c2e-4eb6-8093-eece670da0ef HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities/07e05279-6ef6-40a9-bdc2-9ef663e42388 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities/ecc79a11-fa3b-4140-acdf-69a921f37055 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities/ecc79a11-fa3b-4140-acdf-69a921f37055 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewzy5sy6ws0@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewzy5sy6ws0@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:09 +] "GET 
/api/atlas/entities/07e05279-6ef6-40a9-bdc2-9ef663e42388 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewzy5sy6ws0@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewzy5sy6ws0@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewzy5sy6ws0@primary:1475066883000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewzy5sy6ws0@primary:1475066883000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities/c1c782b9-3c2e-4eb6-8093-eece670da0ef HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities/07e05279-6ef6-40a9-bdc2-9ef663e42388 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities/ecc79a11-fa3b-4140-acdf-69a921f37055 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities?type=hdfs_path=qualifiedName=p
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:12 +] "GET 
/api/atlas/entities/ecc79a11-fa3b-4140-acdf-69a921f37055 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:15 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewzy5sy6ws0@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:15 +] "GET 
/api/atlas/entities?type=hive_table=qualifiedName=default.tablewzy5sy6ws0@primary
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:15 +] "GET 
/api/atlas/entities?type=hive_process=qualifiedName=QUERY:default.tablewzy5sy6ws0@primary:1475066883000-%3E:PATH_WRITE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [28/Sep/2016:12:48:15 +] "GET 

[jira] [Comment Edited] (ATLAS-1199) Atlas UI not loading after fresh build due to jquery-asBreadcrumbs plugin changes.

[Keval Bhatt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529324#comment-15529324
 ] 

Keval Bhatt edited comment on ATLAS-1199 at 9/28/16 11:29 AM:
--

[~shwethags] No its not because of any previous commit. it's breaking up 
because of NPM plugin upgrade 
(https://github.com/amazingSurge/jquery-asBreadcrumbs) so it caused issue in 
atlas code which I will fix in this patch.


was (Author: kevalbhatt18):
[~shwethags] No its not because of any previous commit. it's breaking up 
because of NPM plugin upgrade 
(https://github.com/amazingSurge/jquery-asBreadcrumbs) so it caused issue in 
atlas code which I have fixed in this patch.

> Atlas UI not loading after fresh build due to jquery-asBreadcrumbs plugin 
> changes.
> --
>
> Key: ATLAS-1199
> URL: https://issues.apache.org/jira/browse/ATLAS-1199
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Keval Bhatt
>Priority: Blocker
> Fix For: 0.7-incubating
>
>
> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> Found following error in browser console
> Overrides.js:22 Uncaught TypeError: Cannot set property 
> 'generateChildrenInfo' of undefined
> GET http://localhost:21000/js/libs/jquery-asBreadcrumbs/css/asBreadcrumbs.css 
> 404



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1199) Atlas UI not loading after fresh build due to jquery-asBreadcrumbs plugin changes.

[Keval Bhatt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-1199:
---
Summary: Atlas UI not loading after fresh build due to jquery-asBreadcrumbs 
plugin changes.  (was: Atlas UI not loading after fresh build due 
jquery-asBreadcrumbs plugin changes.)

> Atlas UI not loading after fresh build due to jquery-asBreadcrumbs plugin 
> changes.
> --
>
> Key: ATLAS-1199
> URL: https://issues.apache.org/jira/browse/ATLAS-1199
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Keval Bhatt
>Priority: Blocker
> Fix For: 0.7-incubating
>
>
> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> Found following error in browser console
> Overrides.js:22 Uncaught TypeError: Cannot set property 
> 'generateChildrenInfo' of undefined
> GET http://localhost:21000/js/libs/jquery-asBreadcrumbs/css/asBreadcrumbs.css 
> 404



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1199) Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin changes.

[Keval Bhatt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529324#comment-15529324
 ] 

Keval Bhatt commented on ATLAS-1199:


[~shwethags] No its not because of any previous commit. it's breaking up 
because of NPM plugin upgrade 
(https://github.com/amazingSurge/jquery-asBreadcrumbs) so it caused issue in 
atlas code which I have fixed in this patch.

> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> ---
>
> Key: ATLAS-1199
> URL: https://issues.apache.org/jira/browse/ATLAS-1199
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Keval Bhatt
>Priority: Blocker
> Fix For: 0.7-incubating
>
>
> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> Found following error in browser console
> Overrides.js:22 Uncaught TypeError: Cannot set property 
> 'generateChildrenInfo' of undefined
> GET http://localhost:21000/js/libs/jquery-asBreadcrumbs/css/asBreadcrumbs.css 
> 404



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1183) UI: help link should point to atlas website

[Shwetha G S (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529316#comment-15529316
 ] 

Shwetha G S commented on ATLAS-1183:


Couldn't verify because of issue detailed ATLAS-1199. Will commit post 
ATLAS-1199 fix

> UI: help link should point to atlas website
> ---
>
> Key: ATLAS-1183
> URL: https://issues.apache.org/jira/browse/ATLAS-1183
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Keval Bhatt
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1183.patch
>
>
> Help link points to 
> https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=ATLAS=Atlas+Home
>  which requires login. Instead, link to http://atlas.incubator.apache.org/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1199) Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin changes.

[Shwetha G S (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529300#comment-15529300
 ] 

Shwetha G S commented on ATLAS-1199:


Is this issue after ATLAS-1142 commit?

> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> ---
>
> Key: ATLAS-1199
> URL: https://issues.apache.org/jira/browse/ATLAS-1199
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Keval Bhatt
>Priority: Blocker
> Fix For: 0.7-incubating
>
>
> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> Found following error in browser console
> Overrides.js:22 Uncaught TypeError: Cannot set property 
> 'generateChildrenInfo' of undefined
> GET http://localhost:21000/js/libs/jquery-asBreadcrumbs/css/asBreadcrumbs.css 
> 404



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1199) Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin changes.

[Keval Bhatt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-1199:
---
Priority: Blocker  (was: Major)

> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> ---
>
> Key: ATLAS-1199
> URL: https://issues.apache.org/jira/browse/ATLAS-1199
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Keval Bhatt
>Priority: Blocker
> Fix For: 0.7-incubating
>
>
> Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin 
> changes.
> Found following error in browser console
> Overrides.js:22 Uncaught TypeError: Cannot set property 
> 'generateChildrenInfo' of undefined
> GET http://localhost:21000/js/libs/jquery-asBreadcrumbs/css/asBreadcrumbs.css 
> 404



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52336: ReservedTypesRegistrar checks for existence of 1st class type

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52336/
---

(Updated Sept. 28, 2016, 9:10 a.m.)


Review request for atlas.


Changes
---

Updated patch to only create new types from the model.json file


Bugs: ATLAS-1184
https://issues.apache.org/jira/browse/ATLAS-1184


Repository: atlas


Description
---

ReservedTypesRegistrar registers the models for supported integrations like 
hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files and 
registers the types defined in the model file. The check thats done to verify 
if the model is already registered - checks for existence of first class type. 
This will not work if we add more class types to the existing model or modify 
the existing type to add optional attributes.
ReservedTypesRegistrar should check for every type in the model file. Also, 
ReservedTypesRegistrar should do type update which does create if not exists, 
and update if exists


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
41c0155 
  repository/src/test/java/org/apache/atlas/TestUtils.java bd9df62 
  
repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java
 d602bd8 

Diff: https://reviews.apache.org/r/52336/diff/


Testing
---


Thanks,

Vimal Sharma

[jira] [Commented] (ATLAS-640) HiveLineageJerseyResourceIT fails during instance creation

[Nigel Jones (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528934#comment-15528934
 ] 

Nigel Jones commented on ATLAS-640:
---

In my case I can see the failure to find the datatype"fact" in the application 
log - this is repeated for multiple entities which fail to persist due to this 
error

org.apache.atlas.typesystem.exception.TypeNotFoundException: Unknown datatype: 
Fact
at 
org.apache.atlas.typesystem.types.TypeSystem.getDataType(TypeSystem.java:190)
at 
org.apache.atlas.typesystem.types.TypeSystem$TransientTypeSystem.getDataType(TypeSystem.java:667)
at 
org.apache.atlas.typesystem.types.ClassType.createInstanceWithTraits(ClassType.java:182)
at 
org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:125)
at 
org.apache.atlas.services.DefaultMetadataService.getTypedReferenceableInstance(DefaultMetadataService.java:366)
at 
org.apache.atlas.services.DefaultMetadataService.deserializeClassInstances(DefaultMetadataService.java:343)
at 
org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:324)
at 
org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:134)



> HiveLineageJerseyResourceIT fails during instance creation
> --
>
> Key: ATLAS-640
> URL: https://issues.apache.org/jira/browse/ATLAS-640
> Project: Atlas
>  Issue Type: Bug
>Reporter: Jean-Baptiste Onofré
>
> The webapp module build fails due to the HiveLineageJerseyResourceIT.
> The utests work fine, but this itest (when the war is deployed in Jersey and 
> tested) fail.
> It's due to:
> {code}
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 1.845 sec <<< 
> FAILURE! - in org.apache.atlas.web.resources.HiveLineageJerseyResourceIT
> setUp(org.apache.atlas.web.resources.HiveLineageJerseyResourceIT)  Time 
> elapsed: 1.807 sec  <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API CREATE_ENTITY 
> failed with status 400(Bad Request) Response Body ({"error":"Unknown 
> datatype: 
> Fact","stackTrace":"org.apache.atlas.typesystem.exception.TypeNotFoundException:
>  Unknown datatype: Fact\n\tat 
> org.apache.atlas.typesystem.types.TypeSystem.getDataType(TypeSystem.java:168)\n\tat
>  
> org.apache.atlas.typesystem.types.TypeSystem$TransientTypeSystem.getDataType(TypeSystem.java:641)\n\tat
>  
> org.apache.atlas.typesystem.types.ClassType.createInstanceWithTraits(ClassType.java:181)\n\tat
>  
> org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:124)\n\tat 
> org.apache.atlas.services.DefaultMetadataService.deserializeClassInstances(DefaultMetadataService.java:330)\n\tat
>  
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:304)\n\tat
>  
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:116)\n\tat
>  sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat
>  
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
>  java.lang.reflect.Method.invoke(Method.java:497)\n\tat 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>  
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>  
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>  
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>  
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>  
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
>  

[jira] [Created] (ATLAS-1199) Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin changes.

[Nixon Rodrigues (JIRA)]

Nixon Rodrigues created ATLAS-1199:
--

 Summary: Atlas UI not loading after fresh build due 
jquery-asBreadcrumbs plugin changes.
 Key: ATLAS-1199
 URL: https://issues.apache.org/jira/browse/ATLAS-1199
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues
Assignee: Keval Bhatt
 Fix For: 0.7-incubating


Atlas UI not loading after fresh build due jquery-asBreadcrumbs plugin changes.

Found following error in browser console

Overrides.js:22 Uncaught TypeError: Cannot set property 'generateChildrenInfo' 
of undefined

GET http://localhost:21000/js/libs/jquery-asBreadcrumbs/css/asBreadcrumbs.css   
404




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-961) DataSetLineageJerseyResourceIT.setUp fails

[Nigel Jones (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528894#comment-15528894
 ] 

Nigel Jones commented on ATLAS-961:
---

May be the same as ATLAS-640

> DataSetLineageJerseyResourceIT.setUp fails
> --
>
> Key: ATLAS-961
> URL: https://issues.apache.org/jira/browse/ATLAS-961
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Shwetha G S
>
> mvn clean install -rf :atlas-webapp -Dit.test=DataSetLineageJerseyResourceIT 
> -DskipUTs
> {noformat}
> Tests run: 9, Failures: 1, Errors: 0, Skipped: 8, Time elapsed: 3.716 sec <<< 
> FAILURE! - in org.apache.atlas.web.resources.DataSetLineageJerseyResourceIT
> setUp(org.apache.atlas.web.resources.DataSetLineageJerseyResourceIT)  Time 
> elapsed: 3.666 sec  <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API CREATE_ENTITY 
> failed with status 400(Bad Request) Response Body ({"error":"Unknown 
> datatype: 
> Fact","stackTrace":"org.apache.atlas.typesystem.exception.TypeNotFoundException:
>  Unknown datatype: Fact\n\tat 
> org.apache.atlas.typesystem.types.TypeSystem.getDataType(TypeSystem.java:178)\n\tat
>  
> org.apache.atlas.typesystem.types.TypeSystem$TransientTypeSystem.getDataType(TypeSystem.java:649)\n\tat
>  
> org.apache.atlas.typesystem.types.ClassType.createInstanceWithTraits(ClassType.java:182)\n\tat
>  
> org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:125)\n\tat 
> org.apache.atlas.services.DefaultMetadataService.getTypedReferenceableInstance(DefaultMetadataService.java:374)\n\tat
>  
> org.apache.atlas.services.DefaultMetadataService.deserializeClassInstances(DefaultMetadataService.java:350)\n\tat
>  
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:331)\n\tat
>  
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:125)\n\tat
>  sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)\n\tat
>  
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
>  java.lang.reflect.Method.invoke(Method.java:606)\n\tat 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>  
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>  
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>  
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>  
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>  
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
>  javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat 
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
>  
> com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:277)\n\tat
>  
> com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:182)\n\tat
>  
> com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)\n\tat
>  
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)\n\tat
>  org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:71)\n\tat 
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)\n\tat
>  
> com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:119)\n\tat
>  com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:133)\n\tat 
> com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:130)\n\tat 
> 

[jira] [Commented] (ATLAS-640) HiveLineageJerseyResourceIT fails during instance creation

[Nigel Jones (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528892#comment-15528892
 ] 

Nigel Jones commented on ATLAS-640:
---

I'm hitting the same problem, and in fact just added my log to ATLAS-961 which 
seems to refer to the same issue?

> HiveLineageJerseyResourceIT fails during instance creation
> --
>
> Key: ATLAS-640
> URL: https://issues.apache.org/jira/browse/ATLAS-640
> Project: Atlas
>  Issue Type: Bug
>Reporter: Jean-Baptiste Onofré
>
> The webapp module build fails due to the HiveLineageJerseyResourceIT.
> The utests work fine, but this itest (when the war is deployed in Jersey and 
> tested) fail.
> It's due to:
> {code}
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 1.845 sec <<< 
> FAILURE! - in org.apache.atlas.web.resources.HiveLineageJerseyResourceIT
> setUp(org.apache.atlas.web.resources.HiveLineageJerseyResourceIT)  Time 
> elapsed: 1.807 sec  <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API CREATE_ENTITY 
> failed with status 400(Bad Request) Response Body ({"error":"Unknown 
> datatype: 
> Fact","stackTrace":"org.apache.atlas.typesystem.exception.TypeNotFoundException:
>  Unknown datatype: Fact\n\tat 
> org.apache.atlas.typesystem.types.TypeSystem.getDataType(TypeSystem.java:168)\n\tat
>  
> org.apache.atlas.typesystem.types.TypeSystem$TransientTypeSystem.getDataType(TypeSystem.java:641)\n\tat
>  
> org.apache.atlas.typesystem.types.ClassType.createInstanceWithTraits(ClassType.java:181)\n\tat
>  
> org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:124)\n\tat 
> org.apache.atlas.services.DefaultMetadataService.deserializeClassInstances(DefaultMetadataService.java:330)\n\tat
>  
> org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:304)\n\tat
>  
> org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:116)\n\tat
>  sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat
>  
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
>  java.lang.reflect.Method.invoke(Method.java:497)\n\tat 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
>  
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
>  
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
>  
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
>  
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
>  
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
>  
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
>  
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
>  javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat 
> com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
>  
> com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:277)\n\tat
>  
> com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:182)\n\tat
>  
> com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)\n\tat
>  
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)\n\tat
>  org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:71)\n\tat 
> com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)\n\tat
>  
> com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:119)\n\tat
>  com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:133)\n\tat 
> com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:130)\n\tat 
> 

[jira] [Commented] (ATLAS-961) DataSetLineageJerseyResourceIT.setUp fails

[Nigel Jones (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528886#comment-15528886
 ] 

Nigel Jones commented on ATLAS-961:
---

I've hit the same test failure . Here's a more complete log:

The error appears to be an unknown datatype "Fact"

Running org.apache.atlas.web.resources.DataSetLineageJerseyResourceIT
127.0.0.1 - - [28/Sep/2016:08:21:01 +] "GET /api/atlas/types/hive_db 
HTTP/1.1" 200 - "-" "Java/1.8.0_102"
127.0.0.1 - - [28/Sep/2016:08:21:02 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_102"
127.0.0.1 - - [28/Sep/2016:08:21:02 +] "POST /api/atlas/entities HTTP/1.1" 
400 - "-" "Java/1.8.0_102"
Tests run: 10, Failures: 1, Errors: 0, Skipped: 9, Time elapsed: 2.607 sec <<< 
FAILURE! - in org.apache.atlas.web.resources.DataSetLineageJerseyResourceIT
setUp(org.apache.atlas.web.resources.DataSetLineageJerseyResourceIT)  Time 
elapsed: 2.491 sec  <<< FAILURE!
org.apache.atlas.AtlasServiceException: Metadata service API CREATE_ENTITY 
failed with status 400 (Bad Request) Response Body ({"error":"Unknown datatype: 
Fact","stackTrace":"org.apache.atlas.typesystem.exception.TypeNotFoundException:
 Unknown datatype: Fact\n\tat 
org.apache.atlas.typesystem.types.TypeSystem.getDataType(TypeSystem.java:190)\n\tat
 
org.apache.atlas.typesystem.types.TypeSystem$TransientTypeSystem.getDataType(TypeSystem.java:667)\n\tat
 
org.apache.atlas.typesystem.types.ClassType.createInstanceWithTraits(ClassType.java:182)\n\tat
 org.apache.atlas.typesystem.types.ClassType.convert(ClassType.java:125)\n\tat 
org.apache.atlas.services.DefaultMetadataService.getTypedReferenceableInstance(DefaultMetadataService.java:366)\n\tat
 
org.apache.atlas.services.DefaultMetadataService.deserializeClassInstances(DefaultMetadataService.java:343)\n\tat
 
org.apache.atlas.services.DefaultMetadataService.createEntities(DefaultMetadataService.java:324)\n\tat
 
org.apache.atlas.web.resources.EntityResource.submit(EntityResource.java:134)\n\tat
 sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n\tat 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\n\tat
 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\n\tat
 java.lang.reflect.Method.invoke(Method.java:498)\n\tat 
com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)\n\tat
 
com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)\n\tat
 
com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)\n\tat
 
com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)\n\tat
 
com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)\n\tat
 
com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)\n\tat
 
com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)\n\tat
 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)\n\tat
 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)\n\tat
 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\n\tat
 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\n\tat
 
com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\n\tat
 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\n\tat
 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\n\tat
 javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\n\tat 
com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:287)\n\tat
 
com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:277)\n\tat
 
com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:182)\n\tat
 
com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)\n\tat
 
com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)\n\tat
 org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:71)\n\tat 
com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)\n\tat
 
com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:119)\n\tat
 com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:133)\n\tat 
com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:130)\n\tat 
com.google.inject.servlet.GuiceFilter$Context.call(GuiceFilter.java:203)\n\tat 

[jira] [Assigned] (ATLAS-1102) DefaultMetadataServiceTest can fail in json string comparison

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma reassigned ATLAS-1102:
---

Assignee: Vimal Sharma

> DefaultMetadataServiceTest can fail in json string comparison
> -
>
> Key: ATLAS-1102
> URL: https://issues.apache.org/jira/browse/ATLAS-1102
> Project: Atlas
>  Issue Type: Bug
>Reporter: David Kantor
>Assignee: Vimal Sharma
>Priority: Minor
>
> When running build on a Linux VM, I observed DefaultMetadataServiceTest 
> failing when doing a comparison of json strings serialized from Reference 
> instances.  The objects are equivalent but the attributes are serialized in a 
> different order.
> {noformat}
> DefaultMetadataServiceTest.testSpecialCharacters:231->assertReferenceableEquals:251
>  expected:<{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
>   "id":{
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id":"-3902865145221408",
> "version":0,
> "typeName":"C23uFuNbhg\"${}%",
> "state":"ACTIVE"
>   },
>   "typeName":"C23uFuNbhg\"${}%",
>   "values":{
> "pSXqnaPYeh\"${}%":"DYm4diYqog\"${}%",
> "ectzWlqBQt\"${}%":[
>   "rxstQGf9Ym\"${}%"
> ],
> "D9fOcAp4M5\"${}%":{
>   "sNZLOZhnno\"${}%":"aqhsYeSqwn\"${}%"
> }
>   },
>   "traitNames":[
>   ],
>   "traits":{
>   }
> }> but was:<{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
>   "id":{
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id":"-3902865145221408",
> "version":0,
> "typeName":"C23uFuNbhg\"${}%",
> "state":"ACTIVE"
>   },
>   "typeName":"C23uFuNbhg\"${}%",
>   "values":{
> "ectzWlqBQt\"${}%":[
>   "rxstQGf9Ym\"${}%"
> ],
> "pSXqnaPYeh\"${}%":"DYm4diYqog\"${}%",
> "D9fOcAp4M5\"${}%":{
>   "sNZLOZhnno\"${}%":"aqhsYeSqwn\"${}%"
> }
>   },
>   "traitNames":[
>   ],
>   "traits":{
>   }
> }>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1102) DefaultMetadataServiceTest can fail in json string comparison

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528869#comment-15528869
 ] 

Vimal Sharma commented on ATLAS-1102:
-

The same issue occurred with me as well. Serialization is not consistent.

> DefaultMetadataServiceTest can fail in json string comparison
> -
>
> Key: ATLAS-1102
> URL: https://issues.apache.org/jira/browse/ATLAS-1102
> Project: Atlas
>  Issue Type: Bug
>Reporter: David Kantor
>Priority: Minor
>
> When running build on a Linux VM, I observed DefaultMetadataServiceTest 
> failing when doing a comparison of json strings serialized from Reference 
> instances.  The objects are equivalent but the attributes are serialized in a 
> different order.
> {noformat}
> DefaultMetadataServiceTest.testSpecialCharacters:231->assertReferenceableEquals:251
>  expected:<{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
>   "id":{
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id":"-3902865145221408",
> "version":0,
> "typeName":"C23uFuNbhg\"${}%",
> "state":"ACTIVE"
>   },
>   "typeName":"C23uFuNbhg\"${}%",
>   "values":{
> "pSXqnaPYeh\"${}%":"DYm4diYqog\"${}%",
> "ectzWlqBQt\"${}%":[
>   "rxstQGf9Ym\"${}%"
> ],
> "D9fOcAp4M5\"${}%":{
>   "sNZLOZhnno\"${}%":"aqhsYeSqwn\"${}%"
> }
>   },
>   "traitNames":[
>   ],
>   "traits":{
>   }
> }> but was:<{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
>   "id":{
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id":"-3902865145221408",
> "version":0,
> "typeName":"C23uFuNbhg\"${}%",
> "state":"ACTIVE"
>   },
>   "typeName":"C23uFuNbhg\"${}%",
>   "values":{
> "ectzWlqBQt\"${}%":[
>   "rxstQGf9Ym\"${}%"
> ],
> "pSXqnaPYeh\"${}%":"DYm4diYqog\"${}%",
> "D9fOcAp4M5\"${}%":{
>   "sNZLOZhnno\"${}%":"aqhsYeSqwn\"${}%"
> }
>   },
>   "traitNames":[
>   ],
>   "traits":{
>   }
> }>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1184) ReservedTypesRegistrar checks for existence of 1st class type

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1184:

Description: 
ReservedTypesRegistrar registers the models for supported integrations like 
hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files and 
registers the types defined in the model file. The check thats done to verify 
if the model is already registered - checks for existence of first class type. 
This will not work if we add more types to the existing model. 

ReservedTypesRegistrar should check for every type in the model file and create 
the type if doesn't exist in typesystem

  was:
ReservedTypesRegistrar registers the models for supported integrations like 
hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files and 
registers the types defined in the model file. The check thats done to verify 
if the model is already registered - checks for existence of first class type. 
This will not work if we add more class types to the existing model or modify 
the existing type to add optional attributes. 

ReservedTypesRegistrar should check for every type in the model file. Also, 
ReservedTypesRegistrar should do type update which does create if not exists, 
and update if exists


> ReservedTypesRegistrar checks for existence of 1st class type
> -
>
> Key: ATLAS-1184
> URL: https://issues.apache.org/jira/browse/ATLAS-1184
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Vimal Sharma
> Attachments: ATLAS-1184.patch
>
>
> ReservedTypesRegistrar registers the models for supported integrations like 
> hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files 
> and registers the types defined in the model file. The check thats done to 
> verify if the model is already registered - checks for existence of first 
> class type. This will not work if we add more types to the existing model. 
> ReservedTypesRegistrar should check for every type in the model file and 
> create the type if doesn't exist in typesystem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Rename trait to classification

[David Radley]

Hi Suma,
I agree that it is important to split out these different types of 
metadata.

One way we can split metadata types at a high level is:
1) Physical assets
2) Glossary
3) Governance Definitions
4) Collaboration and contributions
5) Models and schemas

I would see the annotations as existing in area 4 and the classifications 
in area 3. As they are used for different purposes, I would be 
uncomfortable having one inherit from the other in any way that would be 
exposed at the API as this could blur the definitions. But we could do 
this internally to have code re-use. 

It seems to me that the most important use case for Atlas would be the 
governance one - in which classification is a key concept.

I wonder how important the free-form feedback orientated metadata use case 
is  (feedback tagging -annotations, comments , ratings could sit in this 
space too)? I know that collaboration features often are a big wow for 
users. 

  all the best, David. 




From:   Suma Shivaprasad 
To: dev@atlas.incubator.apache.org
Date:   27/09/2016 21:19
Subject:Re: Rename trait to classification



Thanks Mandy for the detailed explanation. To add to what David has 
already
stated,

We could expose two higher level ATLAS types/concepts which are based on
current Traits.

1. Classification - that are locked down and that have a classification
scheme to group together a set of classification concepts
2. Annotation - that are free form and are not locked down

So Traits could be renamed as Annotation and Classification is a
specialization of an Annotation with an additional classification scheme
associated with it.

Thoughts?

Suma





On Mon, Sep 26, 2016 at 5:48 AM, David Radley 
wrote:

> Hi Hermanth,
> I appreciate your feedback and openness. It was an interesting point you
> made about which roles were authoring traits and terms. I guess this is
> not something Atlas would police.
>
> The current traits could be :
> 1) locked down so only the governance team could update them; in that 
case
> they would be classifications that governance rules could act on.
>  or
> 2) Not locked down so a wider audience (business personas) could create
> them.
>
> I am suggesting:
> - renaming traits to classifications for use by the governance team.
> - using terms as glossary terms for use more widely by business users.
>
> Does this work - or am I missing something ?
>   all the best, David.
>
>
>
>
>
>
> From:   Hemanth Yamijala 
> To: dev@atlas.incubator.apache.org
> Date:   26/09/2016 13:09
> Subject:Re: Rename trait to classification
>
>
>
> Hi David,
>
> Reg. the point I made about sharing traits - I don't want to give an
> impression that this as an agreed upon point. Apologize if I conveyed
> that sense.
>
> It is a fact that Atlas today has two concepts that are slightly
> related: Traits (aka Tags) and Business Terms. The latter was new in
> 0.7. IMO, it is important that the Atlas community tries to converge
> on an unambiguous definition of these concepts as the product would be
> driven around these.
>
> With respect to this thread, I am trying to fit in whether
> "classification" is a new concept. Or it overlaps with one of the two
> existing ones (which we are trying to rename).
>
> I am certainly not a domain expert on this in any sense :-) - so
> hoping that others who are would provide guidance (@aahn - ping?).
>
> Thanks
> hemanth
>
> On Mon, Sep 26, 2016 at 2:59 PM, David Radley 
> wrote:
> > Hi Hermanth and Mandy ,
> > Thanks for your feedback.
> >
> > It does seem like these are de-facto industry terms in the governance
> > industry; the reason I say this is that looking around the web I see
> quite
> > a few uses of the words governance classification in different domains
> > (including in the Atlas documentation!).
> >
> > I was not aware of the idea that traits and terms would be authored by
> > different roles - thanks for your explanation. What is coming up for 
me
> is
> > :
> >
> > I think business users should be able to add new business terms (maybe
> > going through a workflow and a governance curator then sorting out
> > inconsistencies), as they are the most expert as the language they 
use.
> > Classifications could be authored by different teams, for example 
levels
> > of confidentiality (in Mandy's example) would be dictated by the
> > governance team. Governance rules would run on these classifications.
> >
> > You say "So, it is hard to use traits in a shared sense or expect to
> have
> > conventional usage" . I notice the Atlas tutorial did not give me this
> > impression, as the example of a trait/tag is PII.
> > Your description of traits implies they are more like free form labels 
.
> > If this is the intent for traits, then it does not make sense to 
rename
> > them to classification. Maybe traits should be called labels; so their
> > name is more in line 

[jira] [Commented] (ATLAS-1102) DefaultMetadataServiceTest can fail in json string comparison

[Nigel Jones (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528767#comment-15528767
 ] 

Nigel Jones commented on ATLAS-1102:


I just hit this same issue -- with the values for the type reversed

> DefaultMetadataServiceTest can fail in json string comparison
> -
>
> Key: ATLAS-1102
> URL: https://issues.apache.org/jira/browse/ATLAS-1102
> Project: Atlas
>  Issue Type: Bug
>Reporter: David Kantor
>Priority: Minor
>
> When running build on a Linux VM, I observed DefaultMetadataServiceTest 
> failing when doing a comparison of json strings serialized from Reference 
> instances.  The objects are equivalent but the attributes are serialized in a 
> different order.
> {noformat}
> DefaultMetadataServiceTest.testSpecialCharacters:231->assertReferenceableEquals:251
>  expected:<{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
>   "id":{
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id":"-3902865145221408",
> "version":0,
> "typeName":"C23uFuNbhg\"${}%",
> "state":"ACTIVE"
>   },
>   "typeName":"C23uFuNbhg\"${}%",
>   "values":{
> "pSXqnaPYeh\"${}%":"DYm4diYqog\"${}%",
> "ectzWlqBQt\"${}%":[
>   "rxstQGf9Ym\"${}%"
> ],
> "D9fOcAp4M5\"${}%":{
>   "sNZLOZhnno\"${}%":"aqhsYeSqwn\"${}%"
> }
>   },
>   "traitNames":[
>   ],
>   "traits":{
>   }
> }> but was:<{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
>   "id":{
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
> "id":"-3902865145221408",
> "version":0,
> "typeName":"C23uFuNbhg\"${}%",
> "state":"ACTIVE"
>   },
>   "typeName":"C23uFuNbhg\"${}%",
>   "values":{
> "ectzWlqBQt\"${}%":[
>   "rxstQGf9Ym\"${}%"
> ],
> "pSXqnaPYeh\"${}%":"DYm4diYqog\"${}%",
> "D9fOcAp4M5\"${}%":{
>   "sNZLOZhnno\"${}%":"aqhsYeSqwn\"${}%"
> }
>   },
>   "traitNames":[
>   ],
>   "traits":{
>   }
> }>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/
---

(Updated Sept. 28, 2016, 7:20 a.m.)


Review request for atlas.


Changes
---

Updates to resolve style violations


Bugs: ATLAS-1171
https://issues.apache.org/jira/browse/ATLAS-1171


Repository: atlas


Description
---

first-cut API for review


Diffs (updated)
-

  common/pom.xml e3b6465 
  common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java 
PRE-CREATION 
  
common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEntityType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasStructType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
  common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java 
PRE-CREATION 
  
common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
 PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDateType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasIntType.java PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasLongType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasMapType.java PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasShortType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasStringType.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/type/TestAtlasStructType.java 
PRE-CREATION 
  pom.xml ac5b042 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java PRE-CREATION 

Diff: https://reviews.apache.org/r/51896/diff/


Testing
---


Thanks,

Madhan Neethiraj

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47810/#review150691
---




repository/src/test/resources/hive-instances.json (line 2)


Modifying this json because of changes in model, 
serialisation/deserialisation is tough. Can we just generate the entities from 
test code?


- Shwetha GS


On Sept. 23, 2016, 3:29 a.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47810/
> ---
> 
> (Updated Sept. 23, 2016, 3:29 a.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-694
> https://issues.apache.org/jira/browse/ATLAS-694
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-694: Update Atlas to use abstraction layer.  All of the Atlas code 
> (with the exception of the catalog, which was only updated minimally) has 
> been updated to use the graph database abstraction layer.  In addition, there 
> is now an optional Atlas configuration property that specifies the class of 
> the abstraction layer database to use.  I basically put all of the changes in 
> here with the exception of the actual Titan 1 implementation of code.  This 
> includes the changes to support Tinkerpop 3 syntax.  This is mostly to 
> expedite getting the changes into Atlas.  Originally the TP3 changes were 
> going to be brought in as part of the Titan 1 implementation task.
> 
> Change Summary:
> 
>- change Atlas classes to use AtlasGraph,AtlasVertex,AtlasEdge, etc 
> instead of TitanGraph/Vertex/Edge, etc
>- compile time dependency on titan 0.5.4/TP 2 removed (except in Catalog, 
> which was only changed to use AtlasGraphProvider/AtlasGraph) - see 
> repository\pom.xml, other pom.xmls
>- updated DSL translation to generate Gremlin that is compliant with TP3 
> when TP3 is being used.  See GremlinQuery.scala, 
> GraphPersistenceStrategies.scala
>- TitanGraphProvider replaced by AtlasGraphProvider.  Graph database 
> implementation is determined from a new optional configuration property
>- HiveTitanSample is no longer used by tests.  It has been replaced by 
> hive-instances.json (which uses normal Atlas json syntax).  The data is saved 
> with a new JSONImporter class.  This was needed because the graphson syntax 
> used by HiveTitanSample is not compatible with TP3.  
> 
> Last rebase: 9/22/2016
> 
> 
> Diffs
> -
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   addons/falcon-bridge/pom.xml 1365bd05a388dc92f7a56c7f7427b5b85f97c7da 
>   addons/hdfs-model/pom.xml 492f39cea085c6e69781e17bcbdbc3a231806df3 
>   
> addons/hdfs-model/src/test/java/org/apache/atlas/fs/model/HDFSModelTest.java 
> ac60294e328835ba0340e150799ddfb348ccdb52 
>   addons/hive-bridge/pom.xml 6993bdb938a6095ca24482e290393eeeb3911bcb 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  ad7a4a5d09d8542a841701dfe04981f65f767c14 
>   addons/sqoop-bridge/pom.xml 8c9d278d43b5979ea1743d10845905c13249f8a6 
>   addons/storm-bridge/pom.xml 12c1208b448d456a923bd7309601174ddb561ba5 
>   catalog/pom.xml 2f58a8f0748de65ab78eab35df6abd2fe7c336af 
>   catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java 
> e7bb505075983371ca12d9bc1d8c6eb240c3d134 
>   distro/src/conf/atlas-application.properties 
> d334600dc5534840409b586157799ef3abf9abf2 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java 
> dd4b7e614cdd9bf30f957fb6a839d8c60f3e1701 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java
>  1bc0fc38c0802897f32260520770a16795474d04 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> 995c5457ac7f807172f367cc8e3348b3a98dd6f3 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
>  41194d34f079842db0d95c73a8b099459f76ff2f 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  c8cd2842ca3090b6bbd384c773b4eb45aff149ce 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  93447495bcf18e9f19df9df68fd1cbe1427fc462 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  e719d306ffe9f68e3ac6f7406baaf60a12390c34 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
>  315ecddb861e1a1be6e0ab9b36fe4c0a52486ae8 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java
>  fff6fb79247e7d0615ce83c4cbbd93d1bf8cf29c 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  

[jira] [Commented] (ATLAS-1183) UI: help link should point to atlas website

[Shwetha G S (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528663#comment-15528663
 ] 

Shwetha G S commented on ATLAS-1183:


+1

> UI: help link should point to atlas website
> ---
>
> Key: ATLAS-1183
> URL: https://issues.apache.org/jira/browse/ATLAS-1183
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Keval Bhatt
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1183.patch
>
>
> Help link points to 
> https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=ATLAS=Atlas+Home
>  which requires login. Instead, link to http://atlas.incubator.apache.org/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1174) Framework to apply updates to types in the type-system

[Shwetha G S (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528662#comment-15528662
 ] 

Shwetha G S commented on ATLAS-1174:


Committing this now, don't see the patch file for position attribute that you 
added earlier. You can file a jira for it

> Framework to apply updates to types in the type-system
> --
>
> Key: ATLAS-1174
> URL: https://issues.apache.org/jira/browse/ATLAS-1174
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>  Labels: feature, patch
> Attachments: ATLAS-1174.patch
>
>
> 1. Introduce "version" attribute to all types in the type-system, this helps 
> to track changes made to the default types (hive, sqoop, falcon and storm 
> types) and user created types. If version is not mentioned during creation of 
> a type, default version "1.0" is assigned (optional attribute).
> 2. Using the version attributed for types, introduce a patch framework for 
> type system. This framework applies patches to a type using its version 
> number and can be used during upgrade - add new attributes to an existing 
> types and it will be run during atlas startup. 
> The sequence of steps:
> a. During atlas startup, check $ATLAS_HOME/models/patches directory for 
> any available patch files (json files). If there any patch files handle them.
> b. Sample patch json file looks like:
> {
>   "patches": [
> { 
>   "action": "ADD_ATTRIBUTE",
>   "typeName": "hive_column",
>   "applyToVersion": "1.0",
>   "updateToVersion": "2.0",
>   "actionParams": [
> { "name": "position",
>   "dataTypeName": "int",
>   "multiplicity": "optional",
>   "isComposite": false,
>   "isUnique": false,
>   "isIndexable": false,
>   "reverseAttributeName": null
> } ]
> } ]
> }
> c. The framework updates the type in "typeName" for the matching version 
> number and after applying the patch, update the version to the one mentioned 
> in "updateToVersion"
> d. The json file can have more than one action (array of actions).
> e. There can be multiple patch json files in the directory and are 
> applied in the sort order of the filename. eg:
> 001-hive_column_add_position.json
> 002-hive_column_add_anotherattribute.json



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52336: ReservedTypesRegistrar checks for existence of 1st class type

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52336/#review150690
---




repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
(line 150)


We shouldn't do any updates as part of this, as it might override any type 
updates from user. Let the patch framework take care of updates. Lets just 
create new types as part of this


- Shwetha GS


On Sept. 28, 2016, 6:27 a.m., Vimal Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52336/
> ---
> 
> (Updated Sept. 28, 2016, 6:27 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1184
> https://issues.apache.org/jira/browse/ATLAS-1184
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ReservedTypesRegistrar registers the models for supported integrations like 
> hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files 
> and registers the types defined in the model file. The check thats done to 
> verify if the model is already registered - checks for existence of first 
> class type. This will not work if we add more class types to the existing 
> model or modify the existing type to add optional attributes.
> ReservedTypesRegistrar should check for every type in the model file. Also, 
> ReservedTypesRegistrar should do type update which does create if not exists, 
> and update if exists
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
>  41c0155 
>   repository/src/test/java/org/apache/atlas/TestUtils.java bd9df62 
>   
> repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java
>  d602bd8 
> 
> Diff: https://reviews.apache.org/r/52336/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>

Re: Review Request 52166: Allow optional attributes to be removed when updating type

[Shwetha GS]

> On Sept. 23, 2016, 6:19 a.m., Shwetha GS wrote:
> > In case the attribute is added again, the data will be wrong. We can't 
> > discount that as an edge case, as it causes data inconsistency. Follow up 
> > jiras will hardly be taken up. Its fine even if we decide that we don't 
> > allow adding the attribute again(the deleted attribute). But we should 
> > address the issue completely
> > 
> > Add UTs in all your patches. Just an end to end test for this patch now 
> > will not ensure that this functionality won't be broken in further commits
> 
> Suma Shivaprasad wrote:
> One sugestion to resolve this case would be
> 
> 1. Add a isDeleted flag to the attribute. It may be useful to know that 
> this atribute was deleted and in case of upgrade/rollbacks , we could 
> potentially use this flag to resurface it back again and roll back the type 
> update.
> 2. Rename the existing property key - 
> http://s3.thinkaurelius.com/docs/titan/0.5.1/schema.html#_changing_schema_elements.
>  Not sure how much time this operation would take. If its an expensive 
> operation, we would need to run this as an asynchronous thread.

We can add the isDeleted flag for now and can cleanup the deleted attributes 
during maintenance windows like upgrades


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52166/#review150154
---


On Sept. 22, 2016, 6:22 p.m., Sarath Kumar Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52166/
> ---
> 
> (Updated Sept. 22, 2016, 6:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1175
> https://issues.apache.org/jira/browse/ATLAS-1175
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> we restrict optional attributes to be removed from the type system. This 
> needs to be allowed
> 
> 
> Diffs
> -
> 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java 
> f5c2ce9 
> 
> Diff: https://reviews.apache.org/r/52166/diff/
> 
> 
> Testing
> ---
> 
> tested using REST calls to delete optional and required attributes and only 
> optional attributes were removed.
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>

Review Request 52336: ReservedTypesRegistrar checks for existence of 1st class type

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52336/
---

Review request for atlas.


Bugs: ATLAS-1184
https://issues.apache.org/jira/browse/ATLAS-1184


Repository: atlas


Description
---

ReservedTypesRegistrar registers the models for supported integrations like 
hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files and 
registers the types defined in the model file. The check thats done to verify 
if the model is already registered - checks for existence of first class type. 
This will not work if we add more class types to the existing model or modify 
the existing type to add optional attributes.
ReservedTypesRegistrar should check for every type in the model file. Also, 
ReservedTypesRegistrar should do type update which does create if not exists, 
and update if exists


Diffs
-

  
repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 
41c0155 
  repository/src/test/java/org/apache/atlas/TestUtils.java bd9df62 
  
repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java
 d602bd8 

Diff: https://reviews.apache.org/r/52336/diff/


Testing
---


Thanks,

Vimal Sharma

[jira] [Updated] (ATLAS-1184) ReservedTypesRegistrar checks for existence of 1st class type

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1184:

Attachment: ATLAS-1184.patch

> ReservedTypesRegistrar checks for existence of 1st class type
> -
>
> Key: ATLAS-1184
> URL: https://issues.apache.org/jira/browse/ATLAS-1184
> Project: Atlas
>  Issue Type: Bug
>Reporter: Shwetha G S
>Assignee: Vimal Sharma
> Attachments: ATLAS-1184.patch
>
>
> ReservedTypesRegistrar registers the models for supported integrations like 
> hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files 
> and registers the types defined in the model file. The check thats done to 
> verify if the model is already registered - checks for existence of first 
> class type. This will not work if we add more class types to the existing 
> model or modify the existing type to add optional attributes. 
> ReservedTypesRegistrar should check for every type in the model file. Also, 
> ReservedTypesRegistrar should do type update which does create if not exists, 
> and update if exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)