date:20170219

[jira] [Created] (ATLAS-1571) null value is set for ownerType field in the GET response of hive_db entity

2017-02-19 Thread Ayub Khan (JIRA)

Ayub Khan created ATLAS-1571:


 Summary: null value is set for ownerType field in the GET response 
of hive_db entity
 Key: ATLAS-1571
 URL: https://issues.apache.org/jira/browse/ATLAS-1571
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: trunk, 0.8-incubating
Reporter: Ayub Khan
Priority: Critical
 Fix For: trunk, 0.8-incubating


Get entity response of hive_db
{noformat}
{  
   "requestId":"pool-2-thread-9 - 88f870a2-dbde-4d08-b1d3-c40680bbe499",
   "definition":{  
  
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
  "id":{  
 
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
 "id":"dd4f77af-d5d7-45e5-a0e9-8316237c95fd",
 "version":0,
 "typeName":"hive_db",
 "state":"ACTIVE"
  },
  "typeName":"hive_db",
  "values":{  
 "name":"diffuserup0qul3ggf",
 
"location":"hdfs:\/\/ctr-e129-1487033772569-11555-01-03.hwx.site:8020\/apps\/hive\/warehouse\/diffuserup0qul3ggf.db",
 "description":null,
 "ownerType":null,
 "qualifiedName":"diffuserup0qul3ggf@cl1",
 "owner":"hrt_1",
 "clusterName":"cl1",
 "parameters":null
  },
  "traitNames":[  

  ],
  "traits":{  

  },
  "systemAttributes":{  
 "createdBy":null,
 "modifiedBy":null,
 "createdTime":"2017-02-20T04:30:33.922Z",
 "modifiedTime":"2017-02-20T04:30:33.922Z"
  }
   }
}
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: V2 REST Api documentation (first-cut)

2017-02-19 Thread Keval Bhatt

Hi Apoorv,

API Doc is very simplified and UI is also looks good and clear. It will be
really helpful to developers.
Integration with swagger  in API documentation is
awesome.

Thanks,
Keval

On Sat, Feb 18, 2017 at 9:07 AM, Apoorv Naik  wrote:

> Hi Atlas community,
>
> The REST API docs (first-cut) for the new V2 endpoints and data models are
> now available at http://atlas.incubator.apache.org/api/v2/index.html.
> It’d be great if we can gather some feedback on the docs, the existing docs
> have been moved under Legacy API section now. Looking forward to the
> community feedback.
>

Build failed in Jenkins: apache-atlas-nightly #631

2017-02-19 Thread Apache Jenkins Server

See 


Changes:

[madhan] ATLAS-1569: cleared contents of RequestContextV1 at the end of the

--
[...truncated 489.20 KB...]
127.0.0.1 - - [20/Feb/2017:05:29:29 +] "GET 
/api/atlas/lineage/874f33ac-2e68-4086-b0d3-7b322aa2d2c1/inputs/graph HTTP/1.1" 
200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:30 +] "GET 
/api/atlas/lineage/hive/table/sales_factKWyakJPG51/outputs/graph HTTP/1.1" 200 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:32 +] "GET 
/api/atlas/entities?type=hive_table_v1=qualifiedName=sales_factKWyakJPG51
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:32 +] "GET 
/api/atlas/lineage/237e77c8-bb3c-48ff-a5dc-11310e8da2ab/outputs/graph HTTP/1.1" 
200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:33 +] "GET 
/api/atlas/lineage/hive/table/sales_factKWyakJPG51/schema HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:34 +] "GET 
/api/atlas/lineage/hive/table/Saleshb1bf61be7/schema HTTP/1.1" 404 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:34 +] "GET 
/api/atlas/entities?type=hive_table_v1=qualifiedName=sales_factKWyakJPG51
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:34 +] "GET 
/api/atlas/lineage/237e77c8-bb3c-48ff-a5dc-11310e8da2ab/schema HTTP/1.1" 200 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:35 +] "GET 
/api/atlas/lineage/hive/table/blah/schema HTTP/1.1" 404 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:35 +] "GET 
/api/atlas/entities?type=hive_table_v1=qualifiedName=sales_fact_monthly_mvaGhKLQfc1h
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:35 +] "GET 
/api/atlas/v2/lineage/6895ef23-f773-460c-ad85-04e4e21db603?direction=INPUT=5
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:36 +] "GET 
/api/atlas/entities?type=hive_table_v1=qualifiedName=sales_fact_monthly_mvaGhKLQfc1h
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:36 +] "GET 
/api/atlas/v2/lineage/6895ef23-f773-460c-ad85-04e4e21db603?direction=BOTH=5
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:38 +] "GET 
/api/atlas/entities?type=hive_table_v1=qualifiedName=sales_factYquPb6MOLn
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:38 +] "GET 
/api/atlas/v2/lineage/a17ba0f5-cac0-47e6-9e53-27f8b24e24ff?direction=OUTPUT=5
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.436 sec - 
in org.apache.atlas.web.resources.EntityLineageJerseyResourceIT
Running org.apache.atlas.CredentialProviderUtilityIT
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.592 sec - in 
org.apache.atlas.CredentialProviderUtilityIT
Running org.apache.atlas.notification.EntityNotificationIT
127.0.0.1 - - [20/Feb/2017:05:29:45 +] "GET /api/atlas/types/tableType 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:45 +] "GET /api/atlas/types/serdeType 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:45 +] "GET /api/atlas/types/classification 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:45 +] "GET /api/atlas/types/hive_db_v1 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:46 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:47 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:48 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:48 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:48 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:49 +] "POST 
/api/atlas/entities/c4056cf7-8907-4861-a0b4-1989f25256fc/traits HTTP/1.1" 201 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:49 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:49 +] "POST 
/api/atlas/entities/c4056cf7-8907-4861-a0b4-1989f25256fc/traits HTTP/1.1" 201 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:49 +] "DELETE 
/api/atlas/entities/c4056cf7-8907-4861-a0b4-1989f25256fc/traits/TraitzAZo7OhkvE 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:49 +] "POST 
/api/atlas/entities/c4056cf7-8907-4861-a0b4-1989f25256fc?property=description 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:49 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:49 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [20/Feb/2017:05:29:49 +] "DELETE

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

2017-02-19 Thread Apoorv Naik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56818/#review166048
---


Ship it!




Ship It!

- Apoorv Naik


On Feb. 19, 2017, 7:09 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56818/
> ---
> 
> (Updated Feb. 19, 2017, 7:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1569
> https://issues.apache.org/jira/browse/ATLAS-1569
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - cleared the contents of RequestContextV2 at the end of each servlet request 
> and notification processing
> - updated notification processing to generate audit log only on the first 
> attempt (and not during retries)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 9ad9c16 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  c16fd66 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 030788a 
> 
> Diff: https://reviews.apache.org/r/56818/diff/
> 
> 
> Testing
> ---
> 
> Verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Build failed in Jenkins: apache-atlas-nightly #630

2017-02-19 Thread Apache Jenkins Server

See 


Changes:

[madhan] ATLAS-1570: Taxonomy test failure fix

--
[...truncated 494.14 KB...]
127.0.0.1 - - [19/Feb/2017:23:33:59 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:00 +] "POST 
/api/atlas/entities/72d276f8-2c1f-4cef-bdc7-8a89826357c2/traits HTTP/1.1" 201 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:00 +] "DELETE 
/api/atlas/entities/72d276f8-2c1f-4cef-bdc7-8a89826357c2/traits/Traitri5FhQcVYt 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:00 +] "POST 
/api/atlas/entities/72d276f8-2c1f-4cef-bdc7-8a89826357c2?property=description 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:00 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:00 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:00 +] "DELETE 
/api/atlas/entities?type=hive_table=qualifiedName=table-vo9Tc6S6LE
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.17 sec - in 
org.apache.atlas.notification.EntityNotificationIT
Running org.apache.atlas.notification.NotificationHookConsumerIT
127.0.0.1 - - [19/Feb/2017:23:34:04 +] "GET /api/atlas/types/tableType 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:05 +] "GET /api/atlas/types/serdeType 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:05 +] "GET /api/atlas/types/classification 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:05 +] "GET /api/atlas/types/hive_db_v1 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:06 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db+where+qualifiedName%3D'dbZRCEesmCjS'=10=0
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:07 +] "GET 
/api/atlas/entities?type=hive_db=qualifiedName=dbZRCEesmCjS 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:07 +] "GET 
/api/atlas/entities/fd05d7a4-bed6-4cb0-86ba-12e3e3a51945/audit?count=1 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:07 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:07 +] "GET 
/api/atlas/entities/b3d58ce6-0572-4bd0-8cd8-580f97edc5f5 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:07 +] "GET 
/api/atlas/entities/b3d58ce6-0572-4bd0-8cd8-580f97edc5f5 HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:07 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db+where+name%3D'dbSFRrbENYx8'=10=0
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:09 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db+where+name%3D'dbSFRrbENYx8'=10=0
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:09 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:10 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db+where+qualifiedName%3D'dbEbSKUVHFuO'=10=0
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:11 +] "GET 
/api/atlas/entities?type=hive_db=qualifiedName=dbEbSKUVHFuO 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:11 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:11 +] "GET 
/api/atlas/entities?type=hive_db=qualifiedName=dbFj3kUD15bZ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:11 +] "GET 
/api/atlas/entities?type=hive_db=qualifiedName=dbFj3kUD15bZ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:11 +] "GET 
/api/atlas/entities?type=hive_db=qualifiedName=dbFj3kUD15bZ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:11 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:11 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db+where+qualifiedName%3D'dbMx6D2Qb4go'=10=0
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [19/Feb/2017:23:34:12 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db+where+qualifiedName%3D'dbs6WAbKgpzy'=10=0
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 11.98 sec <<< 
FAILURE! - in org.apache.atlas.notification.NotificationHookConsumerIT
testCreateEntity(org.apache.atlas.notification.NotificationHookConsumerIT)  
Time elapsed: 2.09 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at 
org.apache.atlas.notification.NotificationHookConsumerIT.testCreateEntity(NotificationHookConsumerIT.java:112)

testUpdatePartialUpdatingQualifiedName(org.apache.atlas.notification.NotificationHookConsumerIT)
  Time elapsed:

Re: Review Request 56825: Taxonomy test failure fixes

2017-02-19 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56825/#review166042
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 19, 2017, 7:26 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56825/
> ---
> 
> (Updated Feb. 19, 2017, 7:26 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1570
> https://issues.apache.org/jira/browse/ATLAS-1570
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Introduction of the StateTransactionCleanupFilter caused a side-effect that 
> led to test failures
> 
> 
> Diffs
> -
> 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 
> 45df9c7c 
> 
> Diff: https://reviews.apache.org/r/56825/diff/
> 
> 
> Testing
> ---
> 
> mvn clean install executes successfully with some regular IT failures
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Review Request 56825: Taxonomy test failure fixes

2017-02-19 Thread Apoorv Naik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56825/
---

Review request for atlas.


Bugs: ATLAS-1570
https://issues.apache.org/jira/browse/ATLAS-1570


Repository: atlas


Description
---

Introduction of the StateTransactionCleanupFilter caused a side-effect that led 
to test failures


Diffs
-

  webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 
45df9c7c 

Diff: https://reviews.apache.org/r/56825/diff/


Testing
---

mvn clean install executes successfully with some regular IT failures


Thanks,

Apoorv Naik

[jira] [Updated] (ATLAS-1570) Fix for Taxonomy service test failures

2017-02-19 Thread Apoorv Naik (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-1570:
---
Attachment: 0001-ATLAS-1570-Taxonomy-test-failure-fix.patch

> Fix for Taxonomy service test failures
> --
>
> Key: ATLAS-1570
> URL: https://issues.apache.org/jira/browse/ATLAS-1570
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
> Fix For: 0.8-incubating
>
> Attachments: 0001-ATLAS-1570-Taxonomy-test-failure-fix.patch
>
>
> Tests are broken and fail because of a recent graph transaction related 
> checkin



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ATLAS-1570) Fix for Taxonomy service test failures

2017-02-19 Thread Apoorv Naik (JIRA)

Apoorv Naik created ATLAS-1570:
--

 Summary: Fix for Taxonomy service test failures
 Key: ATLAS-1570
 URL: https://issues.apache.org/jira/browse/ATLAS-1570
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.8-incubating
Reporter: Apoorv Naik
Assignee: Apoorv Naik
 Fix For: 0.8-incubating


Tests are broken and fail because of a recent graph transaction related checkin



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: apache-atlas-nightly #629

2017-02-19 Thread Apache Jenkins Server

See 


Changes:

[madhan] ATLAS-1568: moved helper methods from org.apache.atlas.model package

--
[...truncated 436.53 KB...]
testDeleteSubTerm(org.apache.atlas.web.resources.TaxonomyServiceTest)  Time 
elapsed: 0.002 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testDeleteSubTerm(TaxonomyServiceTest.java:529)

testDeleteTaxonomy(org.apache.atlas.web.resources.TaxonomyServiceTest)  Time 
elapsed: 0.001 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testDeleteTaxonomy(TaxonomyServiceTest.java:194)

testDeleteTerm(org.apache.atlas.web.resources.TaxonomyServiceTest)  Time 
elapsed: 0.001 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testDeleteTerm(TaxonomyServiceTest.java:493)

testGetSubTerms_collection(org.apache.atlas.web.resources.TaxonomyServiceTest)  
Time elapsed: 0.129 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testGetSubTerms_collection(TaxonomyServiceTest.java:378)

testGetSubTerms_instance(org.apache.atlas.web.resources.TaxonomyServiceTest)  
Time elapsed: 0.003 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testGetSubTerms_instance(TaxonomyServiceTest.java:326)

testGetTaxonomies(org.apache.atlas.web.resources.TaxonomyServiceTest)  Time 
elapsed: 0.001 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testGetTaxonomies(TaxonomyServiceTest.java:125)

testGetTaxonomy(org.apache.atlas.web.resources.TaxonomyServiceTest)  Time 
elapsed: 0.001 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testGetTaxonomy(TaxonomyServiceTest.java:84)

testGetTaxonomyTerm(org.apache.atlas.web.resources.TaxonomyServiceTest)  Time 
elapsed: 0.001 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testGetTaxonomyTerm(TaxonomyServiceTest.java:235)

testGetTaxonomyTerms(org.apache.atlas.web.resources.TaxonomyServiceTest)  Time 
elapsed: 0.002 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.testng.Assert.fail(Assert.java:89)
at org.testng.Assert.failNotEquals(Assert.java:489)
at org.testng.Assert.assertTrue(Assert.java:37)
at org.testng.Assert.assertTrue(Assert.java:47)
at 
org.apache.atlas.web.resources.TaxonomyServiceTest.testGetTaxonomyTerms(TaxonomyServiceTest.java:277)

Running org.apache.atlas.web.filters.ActiveServerFilterTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.028 sec - in 
org.apache.atlas.web.filters.ActiveServerFilterTest
Running org.apache.atlas.web.filters.AtlasCSRFPreventionFilterTest
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0,

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

2017-02-19 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56818/#review166038
---




webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 (line 259)


Good point. It makes sense to audit at the end of handling the message - 
whether it is successful or not. Similarly, the audit generated for the webapp 
should also be  done post-exec - so that the result (HTTP status code) can be 
recorded.

I would suggest this update be taken up in a seprate JIRA.


- Madhan Neethiraj


On Feb. 19, 2017, 7:09 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56818/
> ---
> 
> (Updated Feb. 19, 2017, 7:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1569
> https://issues.apache.org/jira/browse/ATLAS-1569
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - cleared the contents of RequestContextV2 at the end of each servlet request 
> and notification processing
> - updated notification processing to generate audit log only on the first 
> attempt (and not during retries)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 9ad9c16 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  c16fd66 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 030788a 
> 
> Diff: https://reviews.apache.org/r/56818/diff/
> 
> 
> Testing
> ---
> 
> Verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

2017-02-19 Thread Vimal Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56818/#review166037
---




webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 (line 259)


Does it make sense to record audit only after the entity 
creation/updation/deletion was successful


- Vimal Sharma


On Feb. 19, 2017, 7:09 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56818/
> ---
> 
> (Updated Feb. 19, 2017, 7:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1569
> https://issues.apache.org/jira/browse/ATLAS-1569
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - cleared the contents of RequestContextV2 at the end of each servlet request 
> and notification processing
> - updated notification processing to generate audit log only on the first 
> attempt (and not during retries)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 9ad9c16 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  c16fd66 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 030788a 
> 
> Diff: https://reviews.apache.org/r/56818/diff/
> 
> 
> Testing
> ---
> 
> Verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56815: ATLAS-1568: moved helper methods from org.apache.atlas.model package classes into an utility class

2017-02-19 Thread Vimal Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56815/#review166036
---


Fix it, then Ship it!





repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
 (line 243)


Since this is printing to STDOUT, consider removing it


- Vimal Sharma


On Feb. 18, 2017, 7:46 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56815/
> ---
> 
> (Updated Feb. 18, 2017, 7:46 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1568
> https://issues.apache.org/jira/browse/ATLAS-1568
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Moved the following methods to AtlasTypeUtil class:
> - AtlasEntity.getObjectId()
> - AtlasEntityHeader.getObjectId()
> - AtlasObjectId.isValidGuid(guid)
> - AtlasObjectId.isAssignedGuid(guid)
> - AtlasObjectId.isUnassignedGuid(guid)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/CreateUpdateEntitiesResult.java 
> a1aef61 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java e74813a 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> 94b3aa6 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> dea3a93 
>   intg/src/main/java/org/apache/atlas/model/instance/GuidMapping.java 43ce3b0 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 626f18e 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 0a82f40 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 6d85672 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
>  436de49 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  8a6501c 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  8c96c7b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  527ce15 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java
>  e773f02 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  1ac9bd1 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
>  c55e3f7 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  7f76236 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 26bf496 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> b90627f 
>   webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java 
> 04bb4d3 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 2d48770 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
> 1df9d2f 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 
> 5e57518 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
>  96e6f9b 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
>  639d581 
> 
> Diff: https://reviews.apache.org/r/56815/diff/
> 
> 
> Testing
> ---
> 
> verified that unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Commented] (ATLAS-1410) V2 Glossary API

2017-02-19 Thread Mandy Chessell (JIRA)

[
https://issues.apache.org/jira/browse/ATLAS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873650#comment-15873650
]

Mandy Chessell commented on ATLAS-1410:
---

Comments on V1.0

- Page numbers would help to tie these comments to the document.
- Page 2 - Asset type - defined in terms of itself. How are they used? or is
this not relevant to this paper?
- Page 2 - Why do we need to know about V1 and V2? I think it is because the
current interfaces works with V1 and the new one will work with V2 - it would
be helpful to state this explicitly.
- Page 4 - bullets 4-5 - has-a and is-a relationships are semantic
relationships.
- Page 4 - missing from list - ability to associate a semantic meaning to a
classification (v2), trait (v1)?
- Page 4 - Missing from the list - "typed-by" relationship to associate terms
that include meaning in context with terms that describe more pure objects.
For example Home Address is typed by Address.
- Page 5 - Figure 1 - I am not comfortable with terms being owned by
categories. I think each terms should be owned by a glossary and linked into
0, 1 or more categories as appropriate. This creates a much simpler deletion
rule for the API/End user - particularly when you look at Figure 2 where terms
are owned by multiple categories. IE, delete term from its glossary and it is
deleted. In the proposed design, it raises such questions as "Is the term
deleted when unlinked from all categories - or the first category it is linked
to?"
- Page 6 - Figure 3 - I need more detail to understand the "classifies"
relationship and how it relates to a classification. It seems redundant.
Would you not relate a term to a classification which is in itself semantically
classified by its definition term?
- Page 6 - Bullet 6) - What is the alternative to using Gremlin queries?
- Page 6 - Bullet 7) - is this an incomplete sentence - or does the paragraph
that follows supposed to be a nested bullet list? Assuming it is a follow on
point. My confusion is that I do not understand why the term/category
hierarchy is relevant to the enhancement of classifications? The
Classification object is defining the type of classification and its meaning is
coming from the term? Is this suggesting that the relationships between
classifications is coming from the term relationships in the same way we do
thin in IGC today? If so it may help to show an example?
- Page 7 - Figure 4 and 5 - what is the difference between "Classification" and
"Classification Relationship"?
- Page 7 - Maybe strange examples - the Glossaries would be for different
subject areas - for example, there may be a marketing glossary, a customer care
glossary, a banking glossary. These may be used for associating meaning to
data assets (ie data assets). there may also be glossaries for different
regulations, or standard governance approaches, and these may include terms
that can be used to describe classification for data that drive operational
governance?
- Page 8 - I am not sure what the proposed enhancements are - it just seems to
list the problems with the current model. All relationships in metadata are
bi-directional. It should be the default. This mechanism seems complicated.
Really need to define relationships independent of entities so we can define
attributes on these relationships. The Classification is actually an example
of an independently defined relationship that includes the GUID of the 2
entities it connects. This should be the common style of relationship.
- Page 9 - on discussion point - a Taxonomy is a hierarchy of categories that
the terms are placed in - I thought this was included in the proposal and we do
need this for organising terms so that people can find them - and the category
hierarchies (taxonomies) help to provide context to terms too. Also, the
semantic relationships discussed would mean we could support a simple ontology.
- Page 9 - Fully-qualified name - What a grandparent or parent term? What does
a fully qualified name mean and when is it used? The unique name is its GUID.
Its path name (there may be many) is the navigation to the term through the
category hierarchies.
- Page 9 - why do Atlas terms need to follow the schema in defined at this link
-
https://www.ibm.com/support/knowledgecenter/en/SSN364_8.8.0/com.ibm.ima.using/comp/vocab/terms_prop.html?
it seem to imply a lifecycle which is not included in this proposal and a
very specific modelling of the IBM industry models that have mandatory fields
that are not always applicable to all glossaries. I think this doc should
describe the schema of the glossary term explicitly and explain the fields.
- page 10 - Figure 7 shows the navigation relationships and 1 way. We need to
be able to navigate from the hive table to its classification to support the
GAF.
- Page 11 - Figure 8 - Atlas entities box is hard

[jira] [Created] (ATLAS-1571) null value is set for ownerType field in the GET response of hive_db entity

Re: V2 REST Api documentation (first-cut)

Build failed in Jenkins: apache-atlas-nightly #631

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

Build failed in Jenkins: apache-atlas-nightly #630

Re: Review Request 56825: Taxonomy test failure fixes

Review Request 56825: Taxonomy test failure fixes

[jira] [Updated] (ATLAS-1570) Fix for Taxonomy service test failures

[jira] [Created] (ATLAS-1570) Fix for Taxonomy service test failures

Build failed in Jenkins: apache-atlas-nightly #629

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

Re: Review Request 56815: ATLAS-1568: moved helper methods from org.apache.atlas.model package classes into an utility class

[jira] [Commented] (ATLAS-1410) V2 Glossary API

14 matches

Site Navigation

Mail list logo

Footer information