[jira] [Comment Edited] (ATLAS-136) Add trait API to org.apache.atlas.AtlasClient

2015-12-01 Thread Suma Shivaprasad (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033633#comment-15033633
 ] 

Suma Shivaprasad edited comment on ATLAS-136 at 12/1/15 12:52 PM:
--

[~rishabhbhardwaj] Can you pls attach the latest patch for review. For 
EntityJerseyResourceIT, pls use "mvn verify" to run all integration tests or to 
run a single Integration test, you can check 
http://maven.apache.org/surefire/maven-failsafe-plugin/examples/single-test.html.
  In order to make changes to EntityJerseyResource to use AtlasClient, you can 
use HiveHookIT as a reference which is already doing this.




was (Author: suma.shivaprasad):
[~rishabhbhardwaj] Can you pls attach the latest patch for review. For 
EntityJerseyResourceIT, pls use "mvn verify" to run all integration tests or to 
run a single Integration test, you can check 
http://maven.apache.org/surefire/maven-failsafe-plugin/examples/single-test.html



> Add trait API to org.apache.atlas.AtlasClient
> -
>
> Key: ATLAS-136
> URL: https://issues.apache.org/jira/browse/ATLAS-136
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.6-incubating
>Reporter: Vladimir Antonevich`
>Assignee: Rishabh Bhardwaj
> Fix For: 0.6-incubating
>
> Attachments: ATLAS-136.patch, ATLAS-136.v2.patch, atlas.client.patch
>
>
> API to manipulate entity traits must be added to 
> org.apache.atlas.AtlasClient. These should include methods to add/remove a 
> trait POST/DELETE to /api/atlas/entities/{guid}/traits[/traitName], as 
> supported by exposed entities resource



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ATLAS-136) Add trait API to org.apache.atlas.AtlasClient

2015-11-09 Thread Suma Shivaprasad (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996453#comment-14996453
 ] 

Suma Shivaprasad edited comment on ATLAS-136 at 11/9/15 12:38 PM:
--

[~rishabhbhardwaj] 

1. Traits can have any number of super traits. So the API should be able to 
accept any no of super traits.
2. Pls remove the API to create trait and add to entity 
3. Also , pls change all trait related tests  in EntityJerseyResourceIt to go 
through AtlasClient 
4. addTrait should also be able to accept trait attribute values along with the 
name. 





was (Author: suma.shivaprasad):
[~rishabhbhardwaj] 

1. Traits can have any number of super traits. So the API should be able to 
accept any no of super traits.
2. Pls remove the API to create trait and add to entity 
3. Also , pls change all trait related tests  in EntityJerseyResourceIt to go 
through AtlasClient 




> Add trait API to org.apache.atlas.AtlasClient
> -
>
> Key: ATLAS-136
> URL: https://issues.apache.org/jira/browse/ATLAS-136
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.6-incubating
>Reporter: Vladimir Antonevich`
>Assignee: Rishabh Bhardwaj
> Fix For: 0.6-incubating
>
> Attachments: ATLAS-136.patch, ATLAS-136.v2.patch, atlas.client.patch
>
>
> API to manipulate entity traits must be added to 
> org.apache.atlas.AtlasClient. These should include methods to add/remove a 
> trait POST/DELETE to /api/atlas/entities/{guid}/traits[/traitName], as 
> supported by exposed entities resource



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ATLAS-136) Add trait API to org.apache.atlas.AtlasClient

2015-10-29 Thread Shwetha G S (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979995#comment-14979995
 ] 

Shwetha G S edited comment on ATLAS-136 at 10/29/15 7:55 AM:
-

[~vantonevich], are you working on this? will you address the review comments

[~patel_satya], addTrait() function in AtlasClient is a simple wrapper over 
rest API. Feel free to provide a patch if you have one


was (Author: shwethags):
@vantonevich, are you working on this? will you address the review comments

[~patel_satya], addTrait() function in AtlasClient is a simple wrapper over 
rest API. Feel free to provide a patch if you have one

> Add trait API to org.apache.atlas.AtlasClient
> -
>
> Key: ATLAS-136
> URL: https://issues.apache.org/jira/browse/ATLAS-136
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.6-incubating
>Reporter: Vladimir Antonevich`
> Fix For: 0.6-incubating
>
> Attachments: atlas.client.patch
>
>
> API to manipulate entity traits must be added to 
> org.apache.atlas.AtlasClient. These should include methods to add/remove a 
> trait POST/DELETE to /api/atlas/entities/{guid}/traits[/traitName], as 
> supported by exposed entities resource



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)