[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[ https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374708#comment-15374708 ] Vimal Sharma commented on ATLAS-847: +1 > UI: Audit versioning does not paginate details from Atlas server > > > Key: ATLAS-847 > URL: https://issues.apache.org/jira/browse/ATLAS-847 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Hemanth Yamijala >Assignee: Kalyani Kashikar >Priority: Critical > Attachments: ATLAS-847.1.patch, ATLAS-847.patch, audit_pagination.png > > > In ATLAS-664, the capability to view Audit events was added to the Atlas > admin UI. However, currently, the API call made only fetches the first 100 > events (which is the default if no count is sent). In order to fetch the next > set of events, further API calls need to be made to the Audit API, by > providing additional parameters in the API. This JIRA is to track the > required changes in UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[
https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372801#comment-15372801
]
ATLAS QA commented on ATLAS-847:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12817403/ATLAS-847.1.patch
against master revision e13fa5e.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/402//console
This message is automatically generated.
> UI: Audit versioning does not paginate details from Atlas server
>
>
> Key: ATLAS-847
> URL: https://issues.apache.org/jira/browse/ATLAS-847
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: Kalyani Kashikar
>Priority: Critical
> Attachments: ATLAS-847.1.patch, ATLAS-847.patch, audit_pagination.png
>
>
> In ATLAS-664, the capability to view Audit events was added to the Atlas
> admin UI. However, currently, the API call made only fetches the first 100
> events (which is the default if no count is sent). In order to fetch the next
> set of events, further API calls need to be made to the Audit API, by
> providing additional parameters in the API. This JIRA is to track the
> required changes in UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[ https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361283#comment-15361283 ] Vimal Sharma commented on ATLAS-847: [~Kalyanikashikar] After applying the patch and creating more than 100 audit events for a hive table, I find that only the most recent 100 audit events are fetched and paginated in sets of 25. Further, I still see that there are numerical labels for pages rather than "Previous" and "Next" buttons as suggested by Shwetha. Can you share the procedure you used to test this patch. I have attached the screenshot of audit page. > UI: Audit versioning does not paginate details from Atlas server > > > Key: ATLAS-847 > URL: https://issues.apache.org/jira/browse/ATLAS-847 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Hemanth Yamijala >Assignee: Kalyani Kashikar > Attachments: ATLAS-847.patch, audit_pagination.png > > > In ATLAS-664, the capability to view Audit events was added to the Atlas > admin UI. However, currently, the API call made only fetches the first 100 > events (which is the default if no count is sent). In order to fetch the next > set of events, further API calls need to be made to the Audit API, by > providing additional parameters in the API. This JIRA is to track the > required changes in UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[
https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355036#comment-15355036
]
ATLAS QA commented on ATLAS-847:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12814629/ATLAS-847.patch
against master revision 7403ebf.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
+1 checkstyle. The patch generated 0 code style errors.
{color:red}-1 findbugs{color}. The patch appears to introduce 380 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest
Test results:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/378//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/378//console
This message is automatically generated.
> UI: Audit versioning does not paginate details from Atlas server
>
>
> Key: ATLAS-847
> URL: https://issues.apache.org/jira/browse/ATLAS-847
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: Kalyani Kashikar
> Attachments: ATLAS-847.patch
>
>
> In ATLAS-664, the capability to view Audit events was added to the Atlas
> admin UI. However, currently, the API call made only fetches the first 100
> events (which is the default if no count is sent). In order to fetch the next
> set of events, further API calls need to be made to the Audit API, by
> providing additional parameters in the API. This JIRA is to track the
> required changes in UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[ https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350839#comment-15350839 ] Kalyani Kashikar commented on ATLAS-847: [~shwethags] Thanks for suggestion. I will implement next previous button instead of page number and I will put page size as 25. > UI: Audit versioning does not paginate details from Atlas server > > > Key: ATLAS-847 > URL: https://issues.apache.org/jira/browse/ATLAS-847 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Hemanth Yamijala >Assignee: Kalyani Kashikar > > In ATLAS-664, the capability to view Audit events was added to the Atlas > admin UI. However, currently, the API call made only fetches the first 100 > events (which is the default if no count is sent). In order to fetch the next > set of events, further API calls need to be made to the Audit API, by > providing additional parameters in the API. This JIRA is to track the > required changes in UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[ https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348483#comment-15348483 ] Shwetha G S commented on ATLAS-847: --- You don't need to show number of pages. Most recent entries are returned in the first page. So, instead of showing pages as 1, 2, 3 etc, just show the next link which fetches the next page. If we have user requirements, we can change this to page count later. > UI: Audit versioning does not paginate details from Atlas server > > > Key: ATLAS-847 > URL: https://issues.apache.org/jira/browse/ATLAS-847 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Hemanth Yamijala >Assignee: Kalyani Kashikar > > In ATLAS-664, the capability to view Audit events was added to the Atlas > admin UI. However, currently, the API call made only fetches the first 100 > events (which is the default if no count is sent). In order to fetch the next > set of events, further API calls need to be made to the Audit API, by > providing additional parameters in the API. This JIRA is to track the > required changes in UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[
https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348176#comment-15348176
]
Kalyani Kashikar commented on ATLAS-847:
[~shwethags] I am afraid without {{totalCount}} in the first request itself I
wont be able to create the pagination bar (which contains the number of pages)
and also for number of pages we require the pageSize.
Generally the following info would be required for creating an efficient
pagination widget:
* In the first API call OR a separate call get the following info:
** Total number of records : {{totalCount}}
** page size of table : {{pageSize}}, This can be done on client side also
* Once the {{totalCount}} is known, the pagination bar is created with number
of boxes = {{totalCount}} / {{pageSize}}
* Now if user clicks on 4th page, an API request is made with {{startKey}} =
{{pageSize}} * 4
If the {{totalCount}} is not available from the server end, creation of the
pagination bar will not be possible and only client side pagination can be
supported.
> UI: Audit versioning does not paginate details from Atlas server
>
>
> Key: ATLAS-847
> URL: https://issues.apache.org/jira/browse/ATLAS-847
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: Kalyani Kashikar
>
> In ATLAS-664, the capability to view Audit events was added to the Atlas
> admin UI. However, currently, the API call made only fetches the first 100
> events (which is the default if no count is sent). In order to fetch the next
> set of events, further API calls need to be made to the Audit API, by
> providing additional parameters in the API. This JIRA is to track the
> required changes in UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[
https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348127#comment-15348127
]
Shwetha G S commented on ATLAS-847:
---
bq. For pagination it requires total number of records. How do I get that ?
The API doesn't return total number of records currently. Make an API call to
check if there are any remaining records
bq. Regarding usage of "startKey" the output remain same when I tried
startKey=any number
For the first page, don't set startKey. For the second page, startKey should be
equal to the startKey specified in the last record of the previous call(made
for first page)
bq. the api do not returns audit data in json
Here is the json response from audit API
{noformat}
{
"requestId":"qtp966396367-171 - a8c0fada-9c4b-4616-84b2-bccdf90ca54d",
"events":[
{
"entityId":"c402c96b-72d8-4d6b-ad15-101b38870140",
"timestamp":1466764733583,
"user":"admin",
"action":"TAG_ADD",
"details":"Added trait: {\n
\"jsonClass\":\"org.apache.atlas.typesystem.json.InstanceSerialization$_Struct\",\n
\"typeName\":\"tag1\",\n \"values\":{\n\n }\n}",
"eventKey":"c402c96b-72d8-4d6b-ad15-101b38870140:1466764733583",
"entityDefinition":{
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
"id":{
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
"id":"c402c96b-72d8-4d6b-ad15-101b38870140",
"version":0,
"typeName":"hive_column",
"state":"ACTIVE"
},
"typeName":"hive_column",
"values":{
"name":"id",
"qualifiedName":"default.t1.id@primary",
"owner":"sshivalingamurthy",
"type":"string",
"table":{
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
"id":"cebdf4a6-838c-45d7-b166-302c0e4c6c48",
"version":0,
"typeName":"hive_table",
"state":"ACTIVE"
}
},
"traitNames":[
"tag1"
],
"traits":{
"tag1":{
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Struct",
"typeName":"tag1",
"values":{
}
}
}
}
},
{
"entityId":"c402c96b-72d8-4d6b-ad15-101b38870140",
"timestamp":1466764387184,
"user":"sshivalingamurthy",
"action":"ENTITY_UPDATE",
"details":"Updated: {\n
\"jsonClass\":\"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference\",\n
\"id\":{\n
\"jsonClass\":\"org.apache.atlas.typesystem.json.InstanceSerialization$_Id\",\n
\"id\":\"c402c96b-72d8-4d6b-ad15-101b38870140\",\n\"version\":0,\n
\"typeName\":\"hive_column\",\n\"state\":\"ACTIVE\"\n },\n
\"typeName\":\"hive_column\",\n \"values\":{\n\"name\":\"id\",\n
\"description\":null,\n\"qualifiedName\":\"default.t1.id@primary\",\n
\"comment\":null,\n\"owner\":\"sshivalingamurthy\",\n
\"type\":\"string\",\n\"table\":{\n
\"jsonClass\":\"org.apache.atlas.typesystem.json.InstanceSerialization$_Id\",\n
\"id\":\"cebdf4a6-838c-45d7-b166-302c0e4c6c48\",\n \"version\":0,\n
\"typeName\":\"hive_table\",\n \"state\":\"ACTIVE\"\n}\n },\n
\"traitNames\":[\n\n ],\n \"traits\":{\n\n }\n}",
"eventKey":"c402c96b-72d8-4d6b-ad15-101b38870140:1466764387184",
"entityDefinition":{
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
"id":{
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
"id":"c402c96b-72d8-4d6b-ad15-101b38870140",
"version":0,
"typeName":"hive_column",
"state":"ACTIVE"
},
"typeName":"hive_column",
"values":{
"name":"id",
"qualifiedName":"default.t1.id@primary",
"owner":"sshivalingamurthy",
"type":"string",
"table":{
"jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
"id":"cebdf4a6-838c-45d7-b166-302c0e4c6c48",
"version":0,
"typeName":"hive_table",
"state":"ACTIVE"
}
},
"traitNames":[
],
"traits":{
}
}
},
{
"entityId":"c402c96b-72d8-4d6b-ad15-101b38870140",
"timestamp":1466764385464,
"user":"sshivalingamurthy",
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[ https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346437#comment-15346437 ] Kalyani Kashikar commented on ATLAS-847: * For pagination it requires total number of records. How do I get that ? * Regarding usage of "startKey" the output remain same when I tried startKey=any number, the api do not returns audit data in json. > UI: Audit versioning does not paginate details from Atlas server > > > Key: ATLAS-847 > URL: https://issues.apache.org/jira/browse/ATLAS-847 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Hemanth Yamijala >Assignee: Kalyani Kashikar > > In ATLAS-664, the capability to view Audit events was added to the Atlas > admin UI. However, currently, the API call made only fetches the first 100 > events (which is the default if no count is sent). In order to fetch the next > set of events, further API calls need to be made to the Audit API, by > providing additional parameters in the API. This JIRA is to track the > required changes in UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-847) UI: Audit versioning does not paginate details from Atlas server
[
https://issues.apache.org/jira/browse/ATLAS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311740#comment-15311740
]
Hemanth Yamijala commented on ATLAS-847:
{{EntityResource.getAuditEvents}} has the documentation on how to fetch
additional events. In specific, AFAIK, the steps to be followed are:
(Assuming we want to get 100 events in every call)
* Make a call to get 101 events, by setting the query parameter {{count}} to
101.
* Assuming 101 events are received, show the first 100 events, but remember the
101st event received.
* The next API call needs to set the {{startKey}} parameter to the 101st event,
and repeat from the first step.
* Things will stop when the API call gets fewer than the requested number of
items.
Hope this helps to develop the solution.
> UI: Audit versioning does not paginate details from Atlas server
>
>
> Key: ATLAS-847
> URL: https://issues.apache.org/jira/browse/ATLAS-847
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Hemanth Yamijala
>Assignee: Kalyani Kashikar
> Fix For: 0.7-incubating
>
>
> In ATLAS-664, the capability to view Audit events was added to the Atlas
> admin UI. However, currently, the API call made only fetches the first 100
> events (which is the default if no count is sent). In order to fetch the next
> set of events, further API calls need to be made to the Audit API, by
> providing additional parameters in the API. This JIRA is to track the
> required changes in UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
