[jira] [Commented] (ATLAS-919) UI : Deleted references should be shown in red or filtered out
[ https://issues.apache.org/jira/browse/ATLAS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352975#comment-15352975 ] Keval Bhatt commented on ATLAS-919: --- [~suma.shivaprasad] If name is not present then *qualifiedName* is used and if *qualifiedName* is not present then *typeName* is used The latest patch handles above case. > UI : Deleted references should be shown in red or filtered out > -- > > Key: ATLAS-919 > URL: https://issues.apache.org/jira/browse/ATLAS-919 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Suma Shivaprasad >Assignee: Keval Bhatt >Priority: Critical > Attachments: 91529261-d568-40ee-9b2e-b488cff61de1.json, > ATLAS-919.1.patch, ATLAS-919.2.patch, ATLAS-919.3.patch, ATLAS-919.patch, > ATLAS-919.rebased.patch, Screen Shot 2016-06-20 at 3.56.33 PM.png, Screen > Shot 2016-06-23 at 11.26.17 AM.png > > > Foe eg: In a hive_table one of the columns could be dropped in which case the > columns array will have the deleted column as well. This could be completely > filtered out in the UI. The way to identify this is to check if the entity > state is DELETED when going through the references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-919) UI : Deleted references should be shown in red or filtered out
[ https://issues.apache.org/jira/browse/ATLAS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351919#comment-15351919 ] Suma Shivaprasad commented on ATLAS-919: [~kevalbhatt18] Took a look at the patch. Can you use "qualifiedName" if "name" is not available to display the link for references. And if "qualifiedName" is not available, only then use "typeName". Please make these changes . Rest looks fine. > UI : Deleted references should be shown in red or filtered out > -- > > Key: ATLAS-919 > URL: https://issues.apache.org/jira/browse/ATLAS-919 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Suma Shivaprasad >Assignee: Keval Bhatt >Priority: Critical > Attachments: 91529261-d568-40ee-9b2e-b488cff61de1.json, > ATLAS-919.1.patch, ATLAS-919.2.patch, ATLAS-919.patch, > ATLAS-919.rebased.patch, Screen Shot 2016-06-20 at 3.56.33 PM.png, Screen > Shot 2016-06-23 at 11.26.17 AM.png > > > Foe eg: In a hive_table one of the columns could be dropped in which case the > columns array will have the deleted column as well. This could be completely > filtered out in the UI. The way to identify this is to check if the entity > state is DELETED when going through the references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-919) UI : Deleted references should be shown in red or filtered out
[ https://issues.apache.org/jira/browse/ATLAS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350456#comment-15350456 ] Shwetha G S commented on ATLAS-919: --- When a deleted table is viewed, sd is displayed for me, but is not marked as deleted. Also, when sd is clicked, the sd entity shown is not marked as deleted. The API has the deleted state in all these cases > UI : Deleted references should be shown in red or filtered out > -- > > Key: ATLAS-919 > URL: https://issues.apache.org/jira/browse/ATLAS-919 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Suma Shivaprasad >Assignee: Keval Bhatt >Priority: Critical > Attachments: 91529261-d568-40ee-9b2e-b488cff61de1.json, > ATLAS-919.1.patch, ATLAS-919.patch, ATLAS-919.rebased.patch, Screen Shot > 2016-06-20 at 3.56.33 PM.png, Screen Shot 2016-06-23 at 11.26.17 AM.png > > > Foe eg: In a hive_table one of the columns could be dropped in which case the > columns array will have the deleted column as well. This could be completely > filtered out in the UI. The way to identify this is to check if the entity > state is DELETED when going through the references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-919) UI : Deleted references should be shown in red or filtered out
[ https://issues.apache.org/jira/browse/ATLAS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348977#comment-15348977 ] Suma Shivaprasad commented on ATLAS-919: When a deleted table is viewed, property "sd" is not displayed . Can you check this? That should also be displayed with a deleted icon > UI : Deleted references should be shown in red or filtered out > -- > > Key: ATLAS-919 > URL: https://issues.apache.org/jira/browse/ATLAS-919 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Suma Shivaprasad >Assignee: Keval Bhatt >Priority: Critical > Attachments: 91529261-d568-40ee-9b2e-b488cff61de1.json, > ATLAS-919.1.patch, ATLAS-919.patch, ATLAS-919.rebased.patch, Screen Shot > 2016-06-20 at 3.56.33 PM.png, Screen Shot 2016-06-23 at 11.26.17 AM.png > > > Foe eg: In a hive_table one of the columns could be dropped in which case the > columns array will have the deleted column as well. This could be completely > filtered out in the UI. The way to identify this is to check if the entity > state is DELETED when going through the references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-919) UI : Deleted references should be shown in red or filtered out
[
https://issues.apache.org/jira/browse/ATLAS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348218#comment-15348218
]
ATLAS QA commented on ATLAS-919:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12813065/ATLAS-919.1.patch
against master revision 7993de0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
+1 checkstyle. The patch generated 0 code style errors.
{color:red}-1 findbugs{color}. The patch appears to introduce 378 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest
Test results:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/365//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/365//console
This message is automatically generated.
> UI : Deleted references should be shown in red or filtered out
> --
>
> Key: ATLAS-919
> URL: https://issues.apache.org/jira/browse/ATLAS-919
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 0.7-incubating
>Reporter: Suma Shivaprasad
>Assignee: Keval Bhatt
>Priority: Critical
> Attachments: 91529261-d568-40ee-9b2e-b488cff61de1.json,
> ATLAS-919.1.patch, ATLAS-919.patch, ATLAS-919.rebased.patch, Screen Shot
> 2016-06-20 at 3.56.33 PM.png, Screen Shot 2016-06-23 at 11.26.17 AM.png
>
>
> Foe eg: In a hive_table one of the columns could be dropped in which case the
> columns array will have the deleted column as well. This could be completely
> filtered out in the UI. The way to identify this is to check if the entity
> state is DELETED when going through the references.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-919) UI : Deleted references should be shown in red or filtered out
[ https://issues.apache.org/jira/browse/ATLAS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348180#comment-15348180 ] Keval Bhatt commented on ATLAS-919: --- [~suma.shivaprasad] I have created new patch against master which will solve the above problem. > UI : Deleted references should be shown in red or filtered out > -- > > Key: ATLAS-919 > URL: https://issues.apache.org/jira/browse/ATLAS-919 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Suma Shivaprasad >Assignee: Keval Bhatt >Priority: Critical > Attachments: 91529261-d568-40ee-9b2e-b488cff61de1.json, > ATLAS-919.1.patch, ATLAS-919.patch, ATLAS-919.rebased.patch, Screen Shot > 2016-06-20 at 3.56.33 PM.png, Screen Shot 2016-06-23 at 11.26.17 AM.png > > > Foe eg: In a hive_table one of the columns could be dropped in which case the > columns array will have the deleted column as well. This could be completely > filtered out in the UI. The way to identify this is to check if the entity > state is DELETED when going through the references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-919) UI : Deleted references should be shown in red or filtered out
[ https://issues.apache.org/jira/browse/ATLAS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346932#comment-15346932 ] Suma Shivaprasad commented on ATLAS-919: [~kevalbhatt18] There were some minor issues while applying. So rebased the patch and applied. However I see that there is another issue after applying the rebased patch . the db, sd and paremeters are appearing blank in the UI after applying this. Attached screenshot . Not sure if it was a problem with the rebase or with the patch itself. Please check and let me know. > UI : Deleted references should be shown in red or filtered out > -- > > Key: ATLAS-919 > URL: https://issues.apache.org/jira/browse/ATLAS-919 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating >Reporter: Suma Shivaprasad >Assignee: Keval Bhatt >Priority: Critical > Attachments: 91529261-d568-40ee-9b2e-b488cff61de1.json, > ATLAS-919.patch, Screen Shot 2016-06-20 at 3.56.33 PM.png > > > Foe eg: In a hive_table one of the columns could be dropped in which case the > columns array will have the deleted column as well. This could be completely > filtered out in the UI. The way to identify this is to check if the entity > state is DELETED when going through the references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
