[jira] [Commented] (ATLAS-991) Lower bound checking not always disabled for Entities being deleted
[
https://issues.apache.org/jira/browse/ATLAS-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402571#comment-15402571
]
David Kantor commented on ATLAS-991:
[~shwethags] [~suma.shivaprasad] Can someone please review and commit or
provide comments? It has been in the Patch Available state since July 12.
Thanks...
> Lower bound checking not always disabled for Entities being deleted
> ---
>
> Key: ATLAS-991
> URL: https://issues.apache.org/jira/browse/ATLAS-991
> Project: Atlas
> Issue Type: Bug
>Reporter: Jeffrey Hagelberg
>Assignee: David Kantor
> Attachments: rb49869.patch
>
>
> It is often the case multiple entities get deleted at the same time. The
> current delete logic does not compute the delete closure up front, so it is
> possible for the processing of a particular Entity to trigger a lower bound
> violation in an entity that will be deleted but has not been processed yet.
> This issue is specific to hard delete. It does not happen when soft delete
> is being used.
> Here's a simple test that can be added to
> GraphBackedMetadataRepositoryDeleteTestBase to reproduce the issue:
> {noformat}
> @Test
> public void testLowerBoundsIgnoredOnDeletedEntities() throws Exception {
>
> String hrDeptGuid = createHrDeptGraph();
> ITypedReferenceableInstance hrDept =
> repositoryService.getEntityDefinition(hrDeptGuid);
> Map nameGuidMap = getEmployeeNameGuidMap(hrDept);
> ITypedReferenceableInstance john =
> repositoryService.getEntityDefinition(nameGuidMap.get("John"));
> String johnGuid = john.getId()._getId();
> ITypedReferenceableInstance max =
> repositoryService.getEntityDefinition(nameGuidMap.get("Max"));
> String maxGuid = max.getId()._getId();
>
> ITypedReferenceableInstance jane =
> repositoryService.getEntityDefinition(nameGuidMap.get("Jane"));
> String janeGuid = jane.getId()._getId();
>
> //the lower bound constraint on jane.subordinates should not be
> enforced since jane is being deleted
> deleteEntities(johnGuid, maxGuid, janeGuid);
>
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ATLAS-991) Lower bound checking not always disabled for Entities being deleted
[
https://issues.apache.org/jira/browse/ATLAS-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373948#comment-15373948
]
ATLAS QA commented on ATLAS-991:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12817532/rb49869.patch
against master revision e13fa5e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
+1 checkstyle. The patch generated 0 code style errors.
{color:red}-1 findbugs{color}. The patch appears to introduce 381 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.atlas.repository.typestore.GraphBackedTypeStoreTest
Test results:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsplugin-classloader.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningscatalog.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ATLAS-Build/405//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/405//console
This message is automatically generated.
> Lower bound checking not always disabled for Entities being deleted
> ---
>
> Key: ATLAS-991
> URL: https://issues.apache.org/jira/browse/ATLAS-991
> Project: Atlas
> Issue Type: Bug
>Reporter: Jeffrey Hagelberg
>Assignee: David Kantor
> Attachments: rb49869.patch
>
>
> It is often the case multiple entities get deleted at the same time. The
> current delete logic does not compute the delete closure up front, so it is
> possible for the processing of a particular Entity to trigger a lower bound
> violation in an entity that will be deleted but has not been processed yet.
> This issue is specific to hard delete. It does not happen when soft delete
> is being used.
> Here's a simple test that can be added to
> GraphBackedMetadataRepositoryDeleteTestBase to reproduce the issue:
> {noformat}
> @Test
> public void testLowerBoundsIgnoredOnDeletedEntities() throws Exception {
>
> String hrDeptGuid = createHrDeptGraph();
> ITypedReferenceableInstance hrDept =
> repositoryService.getEntityDefinition(hrDeptGuid);
> Map nameGuidMap = getEmployeeNameGuidMap(hrDept);
> ITypedReferenceableInstance john =
> repositoryService.getEntityDefinition(nameGuidMap.get("John"));
> String johnGuid =
