Re: Review Request 50747: (ATLAS-762) Assertion in NegativeSSLAndKerberosTest.testUnsecuredClient needs to be hardened

2016-08-04 Thread Nixon Rodrigues 


> On Aug. 3, 2016, 7:01 p.m., Suma Shivaprasad wrote:
> > webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java,
> >  line 101
> > 
> >
> > why is this commented? Dont we require kinit for zk?

This is commented because it was overriding the keytab for principal dgi since 
filename for dgi.keytab is same and was causing issue on server startup in 
LoginProcessor login method where login is done via dgi principal, the dgi 
keytab was not used previously because authentication method was not set in 
application.properties, secondly security for zookeeper is disabled in this 
testcase by method -> disableZookeeperSecurity(), so it is not needed, so i 
went ahead to comment it.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50747/#review144646
---


On Aug. 3, 2016, 2:01 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50747/
> ---
> 
> (Updated Aug. 3, 2016, 2:01 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Mehul Parikh, 
> Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-762
> https://issues.apache.org/jira/browse/ATLAS-762
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch has changes to fix NegativeSSLKerberosTest & SSL related testcases.
> Created ssl-client.xml in testcase file from SSLConfiguration properties. so 
> that it is available in runtime execution. 
> This patch has changes to test cases to add basic-auth headers for 
> authentication.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java e284ab4 
>   client/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
> 0adb97a 
>   typesystem/src/test/resources/atlas-application.properties 4d7e9b5 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
> 6b54fcd 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
>  9102c75 
>   
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java
>  3d1a63a 
>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 
> 54c570c 
>   
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosTest.java
>  4d7794a 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 
> b550f70 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLTest.java 8afcc26 
>   
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTest.java
>  c356be6 
>   webapp/src/test/webapp/WEB-INF/web.xml 0562643 
> 
> Diff: https://reviews.apache.org/r/50747/diff/
> 
> 
> Testing
> ---
> 
> run mvn clean install.
> run mvn clean package -Pdist,embedded-hbase-solr
> run quick_started.py.
> Did sanity testing on UI.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 50747: (ATLAS-762) Assertion in NegativeSSLAndKerberosTest.testUnsecuredClient needs to be hardened

2016-08-03 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50747/#review144648
---


Ship it!




Ship It!

- Suma Shivaprasad


On Aug. 3, 2016, 2:01 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50747/
> ---
> 
> (Updated Aug. 3, 2016, 2:01 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Mehul Parikh, 
> Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-762
> https://issues.apache.org/jira/browse/ATLAS-762
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch has changes to fix NegativeSSLKerberosTest & SSL related testcases.
> Created ssl-client.xml in testcase file from SSLConfiguration properties. so 
> that it is available in runtime execution. 
> This patch has changes to test cases to add basic-auth headers for 
> authentication.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java e284ab4 
>   client/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
> 0adb97a 
>   typesystem/src/test/resources/atlas-application.properties 4d7e9b5 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
> 6b54fcd 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
>  9102c75 
>   
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java
>  3d1a63a 
>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 
> 54c570c 
>   
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosTest.java
>  4d7794a 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 
> b550f70 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLTest.java 8afcc26 
>   
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTest.java
>  c356be6 
>   webapp/src/test/webapp/WEB-INF/web.xml 0562643 
> 
> Diff: https://reviews.apache.org/r/50747/diff/
> 
> 
> Testing
> ---
> 
> run mvn clean install.
> run mvn clean package -Pdist,embedded-hbase-solr
> run quick_started.py.
> Did sanity testing on UI.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 50747: (ATLAS-762) Assertion in NegativeSSLAndKerberosTest.testUnsecuredClient needs to be hardened

2016-08-03 Thread Suma Shivaprasad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50747/#review144646
---




webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java 
(line 101)


why is this commented? Dont we require kinit for zk?


- Suma Shivaprasad


On Aug. 3, 2016, 2:01 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50747/
> ---
> 
> (Updated Aug. 3, 2016, 2:01 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Mehul Parikh, 
> Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-762
> https://issues.apache.org/jira/browse/ATLAS-762
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch has changes to fix NegativeSSLKerberosTest & SSL related testcases.
> Created ssl-client.xml in testcase file from SSLConfiguration properties. so 
> that it is available in runtime execution. 
> This patch has changes to test cases to add basic-auth headers for 
> authentication.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java e284ab4 
>   client/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
> 0adb97a 
>   typesystem/src/test/resources/atlas-application.properties 4d7e9b5 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
> 6b54fcd 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
>  9102c75 
>   
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java
>  3d1a63a 
>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 
> 54c570c 
>   
> webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosTest.java
>  4d7794a 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 
> b550f70 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLTest.java 8afcc26 
>   
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTest.java
>  c356be6 
>   webapp/src/test/webapp/WEB-INF/web.xml 0562643 
> 
> Diff: https://reviews.apache.org/r/50747/diff/
> 
> 
> Testing
> ---
> 
> run mvn clean install.
> run mvn clean package -Pdist,embedded-hbase-solr
> run quick_started.py.
> Did sanity testing on UI.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>