Re: Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls
> On May 15, 2017, 4:12 p.m., Apoorv Naik wrote: > > Similarly here, would it be possible for you to go through all modules and > > check if any unused dependency declaration exists. > > Jan Hentschel wrote: > Thanks for the review. It seems that SLF4J is duplicated in most of the > sub-modules, because it is already defined in the root pom. Should this be > part of this ticket or should I open another one to cover the rest? Same review/JIRA should be ok. That way we can have one single commit for this change across modules. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59263/#review174962 --- On May 14, 2017, 3:57 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59263/ > --- > > (Updated May 14, 2017, 3:57 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1786 > https://issues.apache.org/jira/browse/ATLAS-1786 > > > Repository: atlas > > > Description > --- > > Removed one of the dependencies for **atlas-graphdb-impls** from the main pom > file. > > > Diffs > - > > webapp/pom.xml 045ccdb > > > Diff: https://reviews.apache.org/r/59263/diff/1/ > > > Testing > --- > > > Thanks, > > Jan Hentschel > >
Re: Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls
> On May 15, 2017, 6:12 p.m., Apoorv Naik wrote: > > Similarly here, would it be possible for you to go through all modules and > > check if any unused dependency declaration exists. Thanks for the review. It seems that SLF4J is duplicated in most of the sub-modules, because it is already defined in the root pom. Should this be part of this ticket or should I open another one to cover the rest? - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59263/#review174962 --- On May 14, 2017, 5:57 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59263/ > --- > > (Updated May 14, 2017, 5:57 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1786 > https://issues.apache.org/jira/browse/ATLAS-1786 > > > Repository: atlas > > > Description > --- > > Removed one of the dependencies for **atlas-graphdb-impls** from the main pom > file. > > > Diffs > - > > webapp/pom.xml 045ccdb > > > Diff: https://reviews.apache.org/r/59263/diff/1/ > > > Testing > --- > > > Thanks, > > Jan Hentschel > >
Re: Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59263/#review174962 --- Similarly here, would it be possible for you to go through all modules and check if any unused dependency declaration exists. - Apoorv Naik On May 14, 2017, 3:57 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59263/ > --- > > (Updated May 14, 2017, 3:57 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1786 > https://issues.apache.org/jira/browse/ATLAS-1786 > > > Repository: atlas > > > Description > --- > > Removed one of the dependencies for **atlas-graphdb-impls** from the main pom > file. > > > Diffs > - > > webapp/pom.xml 045ccdb > > > Diff: https://reviews.apache.org/r/59263/diff/1/ > > > Testing > --- > > > Thanks, > > Jan Hentschel > >
