Re: Review Request 49956: ATLAS-1010 Atlas allows recreation of tags with same name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49956/#review141995 --- PLease hold off on committing this, I need more time to review. The fact that it breaks StoreBackedTypeCache is a concern. - David Kantor On July 12, 2016, 4:11 p.m., Shwetha GS wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49956/ > --- > > (Updated July 12, 2016, 4:11 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1010 > https://issues.apache.org/jira/browse/ATLAS-1010 > > > Repository: atlas > > > Description > --- > > Transient type system which validates the new types being added, wasn't > checking against the singleton instance > > > Diffs > - > > > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java > ee4cc28 > > repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java > 4cb5c67 > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > c355ba9 > typesystem/src/test/java/org/apache/atlas/typesystem/types/EnumTest.java > adbeb19 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java > 574e0f9 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > 7675195 > > Diff: https://reviews.apache.org/r/49956/diff/ > > > Testing > --- > > UT, IT added > > > Thanks, > > Shwetha GS > >
Re: Review Request 49956: ATLAS-1010 Atlas allows recreation of tags with same name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49956/#review141992 --- Ship it! Ship It! - Madhan Neethiraj On July 12, 2016, 4:11 p.m., Shwetha GS wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49956/ > --- > > (Updated July 12, 2016, 4:11 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1010 > https://issues.apache.org/jira/browse/ATLAS-1010 > > > Repository: atlas > > > Description > --- > > Transient type system which validates the new types being added, wasn't > checking against the singleton instance > > > Diffs > - > > > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java > ee4cc28 > > repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java > 4cb5c67 > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > c355ba9 > typesystem/src/test/java/org/apache/atlas/typesystem/types/EnumTest.java > adbeb19 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java > 574e0f9 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > 7675195 > > Diff: https://reviews.apache.org/r/49956/diff/ > > > Testing > --- > > UT, IT added > > > Thanks, > > Shwetha GS > >
