Re: Review Request 53749: [ATLAS-1293] Add query text information for hive_process entities in lineage

2016-11-14 Thread Shwetha GS

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53749/#review155886
---




repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
(line 199)


For hdfs path, qualified name contains the full path including namenode 
endpoint which is not relevant while viewing the lineage(Only part of the value 
is shown in UI and only the namenode endpoint is visible, which is not a good 
user experience). 

Instead of hardcoding these attributes on server side, we should make this 
part of model(type definition), just like attributes marked for search results 
display


- Shwetha GS


On Nov. 15, 2016, 1:44 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53749/
> ---
> 
> (Updated Nov. 15, 2016, 1:44 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, keval bhatt, Madhan Neethiraj, Shwetha 
> GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1293
> https://issues.apache.org/jira/browse/ATLAS-1293
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When UI renders lineage for an entity using v2 lineage APIs, query text needs 
> to be displayed for hive_process types.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
> 14bf143 
> 
> Diff: https://reviews.apache.org/r/53749/diff/
> 
> 
> Testing
> ---
> 
> verified using POST man rest client and ran all unit tests.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



Review Request 53749: [ATLAS-1293] Add query text information for hive_process entities in lineage

2016-11-14 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53749/
---

Review request for atlas, Apoorv Naik, keval bhatt, Madhan Neethiraj, Shwetha 
GS, and Suma Shivaprasad.


Bugs: ATLAS-1293
https://issues.apache.org/jira/browse/ATLAS-1293


Repository: atlas


Description
---

When UI renders lineage for an entity using v2 lineage APIs, query text needs 
to be displayed for hive_process types.


Diffs
-

  repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
14bf143 

Diff: https://reviews.apache.org/r/53749/diff/


Testing
---

verified using POST man rest client and ran all unit tests.


Thanks,

Sarath Subramanian