Re: Review Request 59261: ATLAS-1784: Use explicit imports instead of wildcards

2017-05-15 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59261/#review174964
---


Ship it!




Ship It!

- Apoorv Naik


On May 14, 2017, 11:56 a.m., Jan Hentschel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59261/
> ---
> 
> (Updated May 14, 2017, 11:56 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1784
> https://issues.apache.org/jira/browse/ATLAS-1784
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Changed wildcard imports to explicit imports.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 979e729 
>   
> authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java
>  b36c9c7 
>   catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java 
> cee102a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
> c2a843b 
>   catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java 
> a63309e 
>   
> catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
> b59dcae 
>   catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
> 3202d04 
>   catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 966a3ae 
>   
> catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java
>  6a67b25 
>   
> catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java
>  052a21d 
>   
> catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java
>  c5a4213 
>   
> catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java
>  434a189 
>   
> catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java
>  51ef65a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java
>  e435628 
>   catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java 
> 4adf861 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java
>  b4d759a 
>   
> catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java
>  b915877 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java 
> a4fd4ad 
>   catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java 
> a228546 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java
>  67af409 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  96cb523 
>   catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java 
> 60cc210 
>   catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java 
> 146ca0c 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
>  8dfce5e 
>   
> catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
> 7d61579 
>   catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java 
> 41d934f 
>   
> catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java
>  41f50c7 
>   
> catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java
>  1af8d14 
>   
> catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java
>  b7b23da 
>   
> catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java
>  528c83a 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java
>  d454f37 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java
>  54ff7cb 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java a9aaed2 
>   intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 385a9ae 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e882473 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
> aaf4a6a 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java accba77 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
>  d9bc924 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  560b338 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  075b9b6 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java
>  8a6a0e3 
>   
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
>  ac13586 
>

Review Request 59261: ATLAS-1784: Use explicit imports instead of wildcards

2017-05-14 Thread Jan Hentschel 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59261/
---

Review request for atlas.


Bugs: ATLAS-1784
https://issues.apache.org/jira/browse/ATLAS-1784


Repository: atlas


Description
---

Changed wildcard imports to explicit imports.


Diffs
-

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
979e729 
  
authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java
 b36c9c7 
  catalog/src/main/java/org/apache/atlas/catalog/EntityResourceProvider.java 
cee102a 
  catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java 
c2a843b 
  catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java a63309e 
  catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java 
b59dcae 
  catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java 
3202d04 
  catalog/src/main/java/org/apache/atlas/catalog/VertexWrapper.java 966a3ae 
  
catalog/src/main/java/org/apache/atlas/catalog/definition/BaseResourceDefinition.java
 6a67b25 
  
catalog/src/main/java/org/apache/atlas/catalog/definition/EntityResourceDefinition.java
 052a21d 
  
catalog/src/main/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinition.java
 c5a4213 
  
catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java
 434a189 
  
catalog/src/main/java/org/apache/atlas/catalog/definition/TermResourceDefinition.java
 51ef65a 
  
catalog/src/main/java/org/apache/atlas/catalog/projection/RelationProjection.java
 e435628 
  catalog/src/main/java/org/apache/atlas/catalog/projection/RelationSet.java 
4adf861 
  
catalog/src/main/java/org/apache/atlas/catalog/query/BooleanQueryExpression.java
 b4d759a 
  
catalog/src/main/java/org/apache/atlas/catalog/query/ProjectionQueryExpression.java
 b915877 
  catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java 
a4fd4ad 
  catalog/src/test/java/org/apache/atlas/catalog/CollectionRequestTest.java 
a228546 
  
catalog/src/test/java/org/apache/atlas/catalog/EntityResourceProviderTest.java 
67af409 
  
catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
 96cb523 
  catalog/src/test/java/org/apache/atlas/catalog/JsonSerializerTest.java 
60cc210 
  catalog/src/test/java/org/apache/atlas/catalog/ResourceComparatorTest.java 
146ca0c 
  
catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java
 8dfce5e 
  catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java 
7d61579 
  catalog/src/test/java/org/apache/atlas/catalog/VertexWrapperTest.java 41d934f 
  
catalog/src/test/java/org/apache/atlas/catalog/definition/EntityTagResourceDefinitionTest.java
 41f50c7 
  
catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java
 1af8d14 
  
catalog/src/test/java/org/apache/atlas/catalog/definition/TermResourceDefinitionTest.java
 b7b23da 
  
catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java 
528c83a 
  
graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java
 d454f37 
  
graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java
 54ff7cb 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java a9aaed2 
  intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 385a9ae 
  intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e882473 
  intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
aaf4a6a 
  intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java accba77 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
 d9bc924 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
 560b338 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 075b9b6 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java
 8a6a0e3 
  
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
 ac13586 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java a7cb2e5 
  repository/src/test/java/org/apache/atlas/TestUtils.java cf39d8d 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 18573fc 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
 4fd416c 
  
repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
 65cd938 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 
2f2b090 
  
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java