Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59262/#review174973 --- Ship it! Ship It! - Apoorv Naik On May 14, 2017, 12:20 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59262/ > --- > > (Updated May 14, 2017, 12:20 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1785 > https://issues.apache.org/jira/browse/ATLAS-1785 > > > Repository: atlas > > > Description > --- > > Fixed the following Findbugs warnings: > > * Repeated conditional test in > org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, > ConfigurationStore) > * Switch statement found in > org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where > default case is missing > > > Diffs > - > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > 349da66 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 842b2ce > > > Diff: https://reviews.apache.org/r/59262/diff/1/ > > > Testing > --- > > > Thanks, > > Jan Hentschel > >
Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module
> On May 15, 2017, 4:13 p.m., Apoorv Naik wrote: > > I think there are other modules too where there are quite a few findbugs > > errors. Could you check on that too ? > > Jan Hentschel wrote: > I already created a list, but it seems that there are too much errors to > cover them in one ticket. I'm going to create an uber-ticket for tracking > Findbugs errors and one sub-task per module. One JIRA per module sounds like a good idea. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59262/#review174963 --- On May 14, 2017, 12:20 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59262/ > --- > > (Updated May 14, 2017, 12:20 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1785 > https://issues.apache.org/jira/browse/ATLAS-1785 > > > Repository: atlas > > > Description > --- > > Fixed the following Findbugs warnings: > > * Repeated conditional test in > org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, > ConfigurationStore) > * Switch statement found in > org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where > default case is missing > > > Diffs > - > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > 349da66 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 842b2ce > > > Diff: https://reviews.apache.org/r/59262/diff/1/ > > > Testing > --- > > > Thanks, > > Jan Hentschel > >
Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module
> On May 15, 2017, 6:13 p.m., Apoorv Naik wrote: > > I think there are other modules too where there are quite a few findbugs > > errors. Could you check on that too ? I already created a list, but it seems that there are too much errors to cover them in one ticket. I'm going to create an uber-ticket for tracking Findbugs errors and one sub-task per module. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59262/#review174963 --- On May 14, 2017, 2:20 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59262/ > --- > > (Updated May 14, 2017, 2:20 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1785 > https://issues.apache.org/jira/browse/ATLAS-1785 > > > Repository: atlas > > > Description > --- > > Fixed the following Findbugs warnings: > > * Repeated conditional test in > org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, > ConfigurationStore) > * Switch statement found in > org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where > default case is missing > > > Diffs > - > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > 349da66 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 842b2ce > > > Diff: https://reviews.apache.org/r/59262/diff/1/ > > > Testing > --- > > > Thanks, > > Jan Hentschel > >
Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59262/#review174963 --- I think there are other modules too where there are quite a few findbugs errors. Could you check on that too ? - Apoorv Naik On May 14, 2017, 12:20 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59262/ > --- > > (Updated May 14, 2017, 12:20 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1785 > https://issues.apache.org/jira/browse/ATLAS-1785 > > > Repository: atlas > > > Description > --- > > Fixed the following Findbugs warnings: > > * Repeated conditional test in > org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, > ConfigurationStore) > * Switch statement found in > org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where > default case is missing > > > Diffs > - > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > 349da66 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 842b2ce > > > Diff: https://reviews.apache.org/r/59262/diff/1/ > > > Testing > --- > > > Thanks, > > Jan Hentschel > >
Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59262/ --- Review request for atlas. Bugs: ATLAS-1785 https://issues.apache.org/jira/browse/ATLAS-1785 Repository: atlas Description --- Fixed the following Findbugs warnings: * Repeated conditional test in org.apache.atlas.falcon.bridge.FalconBridge.createFeedCreationEntity(Feed, ConfigurationStore) * Switch statement found in org.apache.atlas.falcon.hook.FalconHook.fireAndForget(FalconEvent) where default case is missing Diffs - addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java 349da66 addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 842b2ce Diff: https://reviews.apache.org/r/59262/diff/1/ Testing --- Thanks, Jan Hentschel
