[jira] [Created] (AVRO-1576) TestSchemaCompatibility is platform dependant
Stevo Slavic created AVRO-1576: -- Summary: TestSchemaCompatibility is platform dependant Key: AVRO-1576 URL: https://issues.apache.org/jira/browse/AVRO-1576 Project: Avro Issue Type: Bug Components: java Affects Versions: 1.7.7 Environment: Windows Reporter: Stevo Slavic Priority: Minor In several test methods of this test class, platform specific newline character is used, so the test fails on other platforms (Windows). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AVRO-1576) TestSchemaCompatibility is platform dependant
[ https://issues.apache.org/jira/browse/AVRO-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stevo Slavic updated AVRO-1576: --- Attachment: AVRO-1576.patch Attached [^AVRO-1576.patch] TestSchemaCompatibility is platform dependant - Key: AVRO-1576 URL: https://issues.apache.org/jira/browse/AVRO-1576 Project: Avro Issue Type: Bug Components: java Affects Versions: 1.7.7 Environment: Windows Reporter: Stevo Slavic Priority: Minor Attachments: AVRO-1576.patch In several test methods of this test class, platform specific newline character is used, so the test fails on other platforms (Windows). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AVRO-1576) TestSchemaCompatibility is platform dependant
[ https://issues.apache.org/jira/browse/AVRO-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stevo Slavic updated AVRO-1576: --- Fix Version/s: 1.8.0 Status: Patch Available (was: Open) TestSchemaCompatibility is platform dependant - Key: AVRO-1576 URL: https://issues.apache.org/jira/browse/AVRO-1576 Project: Avro Issue Type: Bug Components: java Affects Versions: 1.7.7 Environment: Windows Reporter: Stevo Slavic Priority: Minor Fix For: 1.8.0 Attachments: AVRO-1576.patch In several test methods of this test class, platform specific newline character is used, so the test fails on other platforms (Windows). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AVRO-1577) TestSpecificCompiler is not closing resources
Stevo Slavic created AVRO-1577:
--
Summary: TestSpecificCompiler is not closing resources
Key: AVRO-1577
URL: https://issues.apache.org/jira/browse/AVRO-1577
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.7.7
Environment: Windows
Reporter: Stevo Slavic
Fix For: 1.8.0
Test methods in {{TestSpecificCompiler}} are opening various {{Closable}}
resources, but they are not closing them. Because of this, file deletion in
{{tearDown}} silently fails (on platforms like Windows which are locking files
that are being used). This causes few test methods to fail since they are using
same temp file as output file - they generate new file content but only if file
is not already present, and then assertions comparing actual and expected
output content fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (AVRO-1579) Support CI for patches submitted through JIRA
Stevo Slavic created AVRO-1579: -- Summary: Support CI for patches submitted through JIRA Key: AVRO-1579 URL: https://issues.apache.org/jira/browse/AVRO-1579 Project: Avro Issue Type: Task Components: build Affects Versions: 1.7.7 Reporter: Stevo Slavic Other Apache projects (e.g. Kafka) have already JIRA - CI integration enabled, so that patches submitted through JIRA get automatically built and build report published back to JIRA as comment. Please consider supporting this for Avro project as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AVRO-1577) TestSpecificCompiler is not closing resources
[
https://issues.apache.org/jira/browse/AVRO-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stevo Slavic updated AVRO-1577:
---
Status: Patch Available (was: Open)
TestSpecificCompiler is not closing resources
-
Key: AVRO-1577
URL: https://issues.apache.org/jira/browse/AVRO-1577
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.7.7
Environment: Windows
Reporter: Stevo Slavic
Fix For: 1.8.0
Attachments: AVRO-1577.patch
Test methods in {{TestSpecificCompiler}} are opening various {{Closable}}
resources, but they are not closing them. Because of this, file deletion in
{{tearDown}} silently fails (on platforms like Windows which are locking
files that are being used). This causes few test methods to fail since they
are using same temp file as output file - they generate new file content but
only if file is not already present, and then assertions comparing actual and
expected output content fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (AVRO-1577) TestSpecificCompiler is not closing resources
[
https://issues.apache.org/jira/browse/AVRO-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stevo Slavic updated AVRO-1577:
---
Attachment: AVRO-1577.patch
Attached [^AVRO-1577.patch]
TestSpecificCompiler is not closing resources
-
Key: AVRO-1577
URL: https://issues.apache.org/jira/browse/AVRO-1577
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.7.7
Environment: Windows
Reporter: Stevo Slavic
Fix For: 1.8.0
Attachments: AVRO-1577.patch
Test methods in {{TestSpecificCompiler}} are opening various {{Closable}}
resources, but they are not closing them. Because of this, file deletion in
{{tearDown}} silently fails (on platforms like Windows which are locking
files that are being used). This causes few test methods to fail since they
are using same temp file as output file - they generate new file content but
only if file is not already present, and then assertions comparing actual and
expected output content fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (AVRO-1578) Add a link to CI
Stevo Slavic created AVRO-1578: -- Summary: Add a link to CI Key: AVRO-1578 URL: https://issues.apache.org/jira/browse/AVRO-1578 Project: Avro Issue Type: Improvement Components: doc Affects Versions: 1.7.7 Reporter: Stevo Slavic Please consider adding a link to CI job(s) on project site and/or wiki. I found one Avro CI job here: https://builds.apache.org/view/All/job/AvroJava/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-1577) TestSpecificCompiler is not closing resources
[
https://issues.apache.org/jira/browse/AVRO-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119837#comment-14119837
]
Stevo Slavic commented on AVRO-1577:
Attached patch makes use of {{IOUtils.closeQuietly(Closable)}} from
{{commons-io}} - it's Apache, and only for tests.
If not upgrade target JVM to 1.7 and use {{try-with-resources}}, another
alternative is using [Google Guava's
Closer|https://code.google.com/p/guava-libraries/wiki/ClosingResourcesExplained].
TestSpecificCompiler is not closing resources
-
Key: AVRO-1577
URL: https://issues.apache.org/jira/browse/AVRO-1577
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.7.7
Environment: Windows
Reporter: Stevo Slavic
Fix For: 1.8.0
Attachments: AVRO-1577.patch
Test methods in {{TestSpecificCompiler}} are opening various {{Closable}}
resources, but they are not closing them. Because of this, file deletion in
{{tearDown}} silently fails (on platforms like Windows which are locking
files that are being used). This causes few test methods to fail since they
are using same temp file as output file - they generate new file content but
only if file is not already present, and then assertions comparing actual and
expected output content fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (AVRO-1580) Use newer version of surefire, 2.17 instead of 2.12
Zoltan Farkas created AVRO-1580: --- Summary: Use newer version of surefire, 2.17 instead of 2.12 Key: AVRO-1580 URL: https://issues.apache.org/jira/browse/AVRO-1580 Project: Avro Issue Type: Improvement Components: build, java Affects Versions: 1.7.7 Reporter: Zoltan Farkas Priority: Minor version 2.12 does not work well with Netbeans 8.0 and makes development cumbersome. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AVRO-1581) TestIdl unit test error on Windows
Zoltan Farkas created AVRO-1581: --- Summary: TestIdl unit test error on Windows Key: AVRO-1581 URL: https://issues.apache.org/jira/browse/AVRO-1581 Project: Avro Issue Type: Bug Components: java Affects Versions: 1.7.8 Environment: windows Reporter: Zoltan Farkas Priority: Minor in testIdl.java line 155: assertEquals(slurped.trim(), output.replace(\r, ).trim()); needs to be changed to; assertEquals(slurped.trim(), output.replace(\\r, ).trim()); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AVRO-680) Allow for non-string keys
[
https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120389#comment-14120389
]
Rob Turner commented on AVRO-680:
-
I appreciate the work that has gone into this already, but, I think we should
consider going the elegant route and reversing AVRO-9 and allowing map keys to
be defined in the schema and IDL. I think most of the languages support
hash/dictionary implementations that allow object keys, Perl and PHP do not
directly but there are workarounds.
Allow for non-string keys
-
Key: AVRO-680
URL: https://issues.apache.org/jira/browse/AVRO-680
Project: Avro
Issue Type: Improvement
Affects Versions: 1.7.6, 1.7.7
Reporter: Jeremy Hanna
Attachments: AVRO-680.patch, AVRO-680.patch, PERF_8000_cycles.zip,
isMap_Call_Hierarchy.png, non_string_map_keys.zip, non_string_map_keys2.zip,
non_string_map_keys3.zip, non_string_map_keys4.patch,
non_string_map_keys5.patch, non_string_map_keys6.patch,
non_string_map_keys7.patch, non_string_map_perf.txt,
non_string_map_perf2.txt, original_perf.txt
Based on an email thread back in April, Doug Cutting proposed a possible
solution for having non-string keys:
Stu Hood wrote:
I can understand the reasoning behind AVRO-9, but now I need to look for an
alternative to a 'map' that will allow me to store an association of bytes
keys to values.
A map of Foo has the same binary format as an array of records, each
with a string field and a Foo field. So an application can use an array
schema similar to this to represent map-like structures with, e.g.,
non-string keys.
Perhaps we could establish standard properties that indicate that a
given array of records should be represented in a map-like way if
possible? E.g.,:
{type: array, isMap: true, items: {type:record, ...}}
Doug
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
AVRO-457: add tools that read/write xml records from/to avro data files
Hi Avro Developers! I posted a patch for AVRO-457 a couple of weeks ago and I thought I'd check in. I know it's a lot of code to review, and two weeks really isn't enough time to review it all. I was just curious if anyone started to take a look, and if so, if they had any feedback for me! Thanks! Mike
