Hey Ryan, I would appreciate your help on getting these patches in.
Thanks Sachin On Wed, Feb 4, 2015 at 11:25 AM, S G <sg.online.em...@gmail.com> wrote: > I have submitted a modified patch for #3 as well. > > Please help me review and get these committed. > > Thanks > Sachin > > > On Tue, Feb 3, 2015 at 12:42 PM, S G <sg.online.em...@gmail.com> wrote: > >> Thanks a lot for the useful comments Ryan. >> >> 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical references) >> is just ready to be patched in. >> It has all the suggestions from Doug Cutting and an exhaustive testcase. >> Doug Cutting, if you can respond to this JIRA ticket, your help would be >> much appreciated. >> >> 2) https://issues.apache.org/jira/browse/AVRO-680 (Non-string map keys) >> is also completely ready for review. >> Please go ahead for the review. >> >> 3) https://issues.apache.org/jira/browse/AVRO-1554 (Supporting UUID in >> Avro) >> Yes, I will remove the date-part and re-submit the patch. >> >> Thanks >> Sachin >> >> >> >> >> >> On Mon, Feb 2, 2015 at 3:36 PM, Ryan Blue <b...@cloudera.com> wrote: >> >>> On 01/26/2015 11:03 AM, S G wrote: >>> >>>> Hi, >>>> >>>> I have submitted a couple of patches that need some review. >>>> 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical references) >>>> >>> >>> This looks complicated and has a long history, so I'll try to help out >>> on the other two. >>> >>> 2) https://issues.apache.org/jira/browse/AVRO-680 (Non-string map keys) >>>> >>> >>> Looks like the latest on this is some discussion about whether or not it >>> would be useful. In my opinion, it would be a good addition. Other formats >>> and processing engines don't have the restriction that keys are strings. >>> For example, Parquet allows any object to be a key and Hive allows any >>> primitive type. >>> >>> Is there anything else blocking this, or is the current patch ready for >>> review? >>> >>> 3) https://issues.apache.org/jira/browse/AVRO-1554 (Supporting UUID in >>>> Avro) >>>> >>> >>> This notes some updates that need to be done as of September last year >>> (remove Date), but the last patch is from June. Do you want to update the >>> patch? >>> >>> rb >>> >>> >>> -- >>> Ryan Blue >>> Software Engineer >>> Cloudera, Inc. >>> >> >> >
