[jira] [Updated] (AVRO-1990) CreateRandomFileTool should validate arguments

2017-05-26 Thread Nandor Kollar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nandor Kollar updated AVRO-1990:

Status: Patch Available  (was: Open)

> CreateRandomFileTool should validate arguments
> --
>
> Key: AVRO-1990
> URL: https://issues.apache.org/jira/browse/AVRO-1990
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Sean Busbey
>Assignee: Nandor Kollar
>  Labels: beginner
>
> Running CreateRandomFileTool without the {{--count}} argument results in a 
> NPE. it should instead give a useful error message.
> {code}
> java -jar lang/java/tools/target/avro-tools-1.9.0-SNAPSHOT.jar random 
> --schema '{ "type": "record", "name": "foobar", "fields": [ {"name": 
> "field0", "type": "string"}, {"name":"field2", "type":"int"}]}' 
> ~/Downloads/example.0.avro
> log4j:WARN No appenders could be found for logger 
> (org.apache.hadoop.metrics2.lib.MutableMetricsFactory).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
> info.
> Exception in thread "main" java.lang.NullPointerException
>   at 
> org.apache.avro.tool.CreateRandomFileTool.run(CreateRandomFileTool.java:89)
>   at org.apache.avro.tool.Main.run(Main.java:87)
>   at org.apache.avro.tool.Main.main(Main.java:76)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1990) CreateRandomFileTool should validate arguments

2017-05-26 Thread Nandor Kollar (JIRA) 

[ 
https://issues.apache.org/jira/browse/AVRO-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026366#comment-16026366
 ] 

Nandor Kollar commented on AVRO-1990:
-

[~busbey] could you please review my pull request?

> CreateRandomFileTool should validate arguments
> --
>
> Key: AVRO-1990
> URL: https://issues.apache.org/jira/browse/AVRO-1990
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Sean Busbey
>Assignee: Nandor Kollar
>  Labels: beginner
>
> Running CreateRandomFileTool without the {{--count}} argument results in a 
> NPE. it should instead give a useful error message.
> {code}
> java -jar lang/java/tools/target/avro-tools-1.9.0-SNAPSHOT.jar random 
> --schema '{ "type": "record", "name": "foobar", "fields": [ {"name": 
> "field0", "type": "string"}, {"name":"field2", "type":"int"}]}' 
> ~/Downloads/example.0.avro
> log4j:WARN No appenders could be found for logger 
> (org.apache.hadoop.metrics2.lib.MutableMetricsFactory).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
> info.
> Exception in thread "main" java.lang.NullPointerException
>   at 
> org.apache.avro.tool.CreateRandomFileTool.run(CreateRandomFileTool.java:89)
>   at org.apache.avro.tool.Main.run(Main.java:87)
>   at org.apache.avro.tool.Main.main(Main.java:76)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1990) CreateRandomFileTool should validate arguments

2017-05-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/AVRO-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026362#comment-16026362
 ] 

ASF GitHub Bot commented on AVRO-1990:
--

GitHub user nandorKollar opened a pull request:

https://github.com/apache/avro/pull/226

AVRO-1990: CreateRandomFileTool should validate arguments



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nandorKollar/avro AVRO-1990

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #226


commit fa24958e8fd4c204a96d59b78243ffedac4d4b99
Author: Nandor Kollar 
Date:   2017-05-26T14:51:27Z

AVRO-1990: CreateRandomFileTool should validate arguments




> CreateRandomFileTool should validate arguments
> --
>
> Key: AVRO-1990
> URL: https://issues.apache.org/jira/browse/AVRO-1990
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.9.0
>Reporter: Sean Busbey
>Assignee: Nandor Kollar
>  Labels: beginner
>
> Running CreateRandomFileTool without the {{--count}} argument results in a 
> NPE. it should instead give a useful error message.
> {code}
> java -jar lang/java/tools/target/avro-tools-1.9.0-SNAPSHOT.jar random 
> --schema '{ "type": "record", "name": "foobar", "fields": [ {"name": 
> "field0", "type": "string"}, {"name":"field2", "type":"int"}]}' 
> ~/Downloads/example.0.avro
> log4j:WARN No appenders could be found for logger 
> (org.apache.hadoop.metrics2.lib.MutableMetricsFactory).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
> info.
> Exception in thread "main" java.lang.NullPointerException
>   at 
> org.apache.avro.tool.CreateRandomFileTool.run(CreateRandomFileTool.java:89)
>   at org.apache.avro.tool.Main.run(Main.java:87)
>   at org.apache.avro.tool.Main.main(Main.java:76)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] avro pull request #226: AVRO-1990: CreateRandomFileTool should validate argu...

2017-05-26 Thread nandorKollar 
GitHub user nandorKollar opened a pull request:

https://github.com/apache/avro/pull/226

AVRO-1990: CreateRandomFileTool should validate arguments



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nandorKollar/avro AVRO-1990

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #226


commit fa24958e8fd4c204a96d59b78243ffedac4d4b99
Author: Nandor Kollar 
Date:   2017-05-26T14:51:27Z

AVRO-1990: CreateRandomFileTool should validate arguments




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---