[jira] [Commented] (AVRO-1837) Add support for logical date, time, timestamp type for python AVRO

2017-08-11 Thread Abrar Ahmed Sheikh (JIRA)

[ 
https://issues.apache.org/jira/browse/AVRO-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123928#comment-16123928
 ] 

Abrar Ahmed Sheikh commented on AVRO-1837:
--

sorry about the delayed response on this. I have addressed all comments on my 
PR. i suppose Its now ready to be merged.

> Add support for logical date, time, timestamp type for python AVRO
> --
>
> Key: AVRO-1837
> URL: https://issues.apache.org/jira/browse/AVRO-1837
> Project: Avro
>  Issue Type: New Feature
>  Components: python
>Affects Versions: 1.9.0
>Reporter: Abrar Ahmed Sheikh
>
> Currently, python Avro does not seem to support a TIME, TIMESTAMP and DATE 
> logicalType type. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (AVRO-1658) Add avroDoc on reflect

2017-08-11 Thread Nandor Kollar (JIRA)

[ 
https://issues.apache.org/jira/browse/AVRO-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123468#comment-16123468
 ] 

Nandor Kollar commented on AVRO-1658:
-

I didn't see any test failure after merging Evan's PR, all unit test passed. I 
just had to resolve a merge conflict in the test class, the patch looks good to 
me.

> Add avroDoc on reflect
> --
>
> Key: AVRO-1658
> URL: https://issues.apache.org/jira/browse/AVRO-1658
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Zhaonan Sun
>Assignee: Zhaonan Sun
>  Labels: reflection
> Attachments: 
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch, 
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch, 
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch
>
>
> Looks like @AvroMeta can't add reserved fields, like @AvroMeta("doc", "some 
> doc") will have exceptions.
> I would be greate if we have a @AvroDoc("some documentations") in 
> org.apache.avro.reflect



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)