[jira] [Updated] (AVRO-2061) Improve Invalid File Format Error Message

2017-08-14 Thread Gabor Szadovszky (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gabor Szadovszky updated AVRO-2061:
---
   Resolution: Fixed
Fix Version/s: 1.9.0
   Status: Resolved  (was: Patch Available)

> Improve Invalid File Format Error Message
> -
>
> Key: AVRO-2061
> URL: https://issues.apache.org/jira/browse/AVRO-2061
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.9.0, 1.8.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 1.9.0
>
> Attachments: AVRO-2061.1.patch, AVRO-2061.2.patch
>
>
> {code:title=org.apache.avro.file.DataFileStream}
> try {
>   vin.readFixed(magic); // read magic
> } catch (IOException e) {
>   throw new IOException("Not a data file.", e);
> }
> if (!Arrays.equals(DataFileConstants.MAGIC, magic))
>   throw new IOException("Not a data file.");
> {code}
> Please consider improving the error message here.  I just saw a MapReduce job 
> fail with an IOException with the message "Not a data file."  There was 
> definitely data files in the input directory, however, they were not Avro 
> files. It would have been much more helpful if it told me that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-2061) Improve Invalid File Format Error Message

2017-08-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125461#comment-16125461
 ] 

ASF subversion and git services commented on AVRO-2061:
---

Commit 040a3be09216f188dff2b1bf1c23d21ecd4a265c in avro's branch 
refs/heads/master from [~belugabehr]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=040a3be ]

AVRO-2061: Improve Invalid File Format Error Message


> Improve Invalid File Format Error Message
> -
>
> Key: AVRO-2061
> URL: https://issues.apache.org/jira/browse/AVRO-2061
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.9.0, 1.8.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: AVRO-2061.1.patch, AVRO-2061.2.patch
>
>
> {code:title=org.apache.avro.file.DataFileStream}
> try {
>   vin.readFixed(magic); // read magic
> } catch (IOException e) {
>   throw new IOException("Not a data file.", e);
> }
> if (!Arrays.equals(DataFileConstants.MAGIC, magic))
>   throw new IOException("Not a data file.");
> {code}
> Please consider improving the error message here.  I just saw a MapReduce job 
> fail with an IOException with the message "Not a data file."  There was 
> definitely data files in the input directory, however, they were not Avro 
> files. It would have been much more helpful if it told me that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-2066) Wrong schema file used in one TestSpecificCompiler test case

2017-08-14 Thread Nandor Kollar (JIRA) 

[ 
https://issues.apache.org/jira/browse/AVRO-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125438#comment-16125438
 ] 

Nandor Kollar commented on AVRO-2066:
-

[~blue_impala_48d6] it seems you you did this test, could you please have a 
look at the attached patch? I think the file reference in the test is not the 
one you wanted to use.

> Wrong schema file used in one TestSpecificCompiler test case
> 
>
> Key: AVRO-2066
> URL: https://issues.apache.org/jira/browse/AVRO-2066
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Reporter: Nandor Kollar
>Priority: Trivial
> Attachments: AVRO-2066.patch
>
>
> I think instead of simple_record.avsc 
> {{TestSpecificCompiler#testLogicalTypesWithMultipleFields}} meant to use 
> logical_types_with_multiple_fields.avsc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (AVRO-2066) Wrong schema file used in one TestSpecificCompiler test case

2017-08-14 Thread Nandor Kollar (JIRA) 
Nandor Kollar created AVRO-2066:
---

 Summary: Wrong schema file used in one TestSpecificCompiler test 
case
 Key: AVRO-2066
 URL: https://issues.apache.org/jira/browse/AVRO-2066
 Project: Avro
  Issue Type: Bug
  Components: java
Reporter: Nandor Kollar
Priority: Trivial


I think instead of simple_record.avsc 
{{TestSpecificCompiler#testLogicalTypesWithMultipleFields}} meant to use 
logical_types_with_multiple_fields.avsc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-2066) Wrong schema file used in one TestSpecificCompiler test case

2017-08-14 Thread Nandor Kollar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nandor Kollar updated AVRO-2066:

Attachment: AVRO-2066.patch

> Wrong schema file used in one TestSpecificCompiler test case
> 
>
> Key: AVRO-2066
> URL: https://issues.apache.org/jira/browse/AVRO-2066
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Reporter: Nandor Kollar
>Priority: Trivial
> Attachments: AVRO-2066.patch
>
>
> I think instead of simple_record.avsc 
> {{TestSpecificCompiler#testLogicalTypesWithMultipleFields}} meant to use 
> logical_types_with_multiple_fields.avsc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)