[jira] [Commented] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527608#comment-16527608 ] Nandor Kollar commented on AVRO-2173: - [~nielsbasjes] fine for me, let's drop CHANGES.txt from branch-1.8 too. > remove CHANGES.txt > -- > > Key: AVRO-2173 > URL: https://issues.apache.org/jira/browse/AVRO-2173 > Project: Avro > Issue Type: Improvement >Reporter: Doug Cutting >Priority: Major > > The CHANGES.txt file is not well maintained and redundant with information in > Jira. > Let's remove this file, and instead generate release notes from Jira. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527531#comment-16527531 ] Niels Basjes edited comment on AVRO-2173 at 6/29/18 1:09 PM: - It is removed now from master. I propose we kick is from branch-1.8 too and let all other branches remain untouched. [~nkollar] / [~cutting] what do you think? was (Author: nielsbasjes): I is removed now from master. I propose we kick is from branch-1.8 too and let all other branches remain untouched. [~nkollar] / [~cutting] what do you think? > remove CHANGES.txt > -- > > Key: AVRO-2173 > URL: https://issues.apache.org/jira/browse/AVRO-2173 > Project: Avro > Issue Type: Improvement >Reporter: Doug Cutting >Priority: Major > > The CHANGES.txt file is not well maintained and redundant with information in > Jira. > Let's remove this file, and instead generate release notes from Jira. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527531#comment-16527531 ] Niels Basjes commented on AVRO-2173: I is removed now from master. I propose we kick is from branch-1.8 too and let all other branches remain untouched. [~nkollar] / [~cutting] what do you think? > remove CHANGES.txt > -- > > Key: AVRO-2173 > URL: https://issues.apache.org/jira/browse/AVRO-2173 > Project: Avro > Issue Type: Improvement >Reporter: Doug Cutting >Priority: Major > > The CHANGES.txt file is not well maintained and redundant with information in > Jira. > Let's remove this file, and instead generate release notes from Jira. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527509#comment-16527509 ] ASF GitHub Bot commented on AVRO-2173: -- nielsbasjes closed pull request #310: AVRO-2173: remove CHANGES.txt URL: https://github.com/apache/avro/pull/310 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/CHANGES.txt b/CHANGES.txt deleted file mode 100644 index 41d0a2ef2..0 --- a/CHANGES.txt +++ /dev/null @@ -1,3611 +0,0 @@ -Avro Change Log - -Trunk (not yet released) - - INCOMPATIBLE CHANGES - -AVRO-2003: Report specific location of schema incompatibilities (teabot via nkollar) - -AVRO-2035: Java: validate default values when parsing schemas. (cutting) - -AVRO-2043: Move to java8 - -AVRO-2061: Improve Invalid File Format Error Message (Beluga Behr via gabor) - -AVRO-1933: Add more specific error details to SchemaCompatibility class -(Anders Sundelin via gabor) - -AVRO-2072: ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions -(Nandor Kollar via gabor) - -AVRO-2059: Remove support of Hadoop 1 (gabor) - - NEW FEATURES - -AVRO-1704: Java: Add support for single-message encoding. (blue) - -AVRO-1704: Spec: Add single-message encoding format. (Niels Basjes via blue) - -AVRO-1884: Java: Add method to set the compiler output suffix. -(shijinkui via blue) - -AVRO-1932: Java: Allow setting the SchemaStore on generated classes. -(Niels Basjes) - -AVRO-2132: Allow dots in IDL property names. (kdrakon via cutting) - - OPTIMIZATIONS - - IMPROVEMENTS - -AVRO-1889: Update maven-shade-plugin to enable building in Java 8 on Mac. -(Sachin Goyal via blue) - -AVRO-1695. Java: Fix GenericData#deepCopy() to support logical types. -(cutting) - -AVRO-1719: C++: Fix tests with Boost >= 1.59. (Romain Geissler via blue) - -AVRO-1879: Make conversions field static. (Michael Wong via blue) - -AVRO-1919: Formalize the presence of build.sh. (Suraj Acharya via cutting) - -AVRO-1918: Improve logical type documentation. (Gabor Szadovszky via cutting) - -AVRO-1907: Java: Add debug logging for invalid logical types. -(Gabor Szadovszky via blue) - -AVRO-1897: Fix build issues due to VERSION.txt newline, avro-tools. -(Suraj Acharya via blue) - -AVRO-1993: C++ Byte ordering macro does not work on FreeBSD (thiru) - -AVRO-1975: Upgrade java dependencies (gabor) - -AVRO-1960: Add log4j properties for avro-tools - -AVRO-1748. Add Snappy Compression to C++ DataFile (J. Langley via thiru) - -AVRO-1723. Add support for forward declarations in avro IDL (Zoltan Farcas via thiru) - -AVRO-1971: Allow alias annotation on fields (Johannes Schulte via gabor) - -AVRO-2021: uuid logical type is not documented (Nandor Kollar via gabor) - -AVRO-2056: DirectBinaryEncoder Creates Buffer For Each Call To writeDouble -(Beluga Behr via gabor) - -AVRO-2054: Use StringBuilder instead of StringBuffer -(Beluga Behr via gabor) - -AVRO-2050: Clear Array To Allow GC -(Beluga Behr via gabor) - -AVRO-2049: Remove Superfluous Configuration From AvroSerializer -(Beluga Behr via gabor) - -AVRO-2048: Avro Binary Decoding - Gracefully Handle Long Strings -(Beluga Behr via gabor) - -AVRO-2053: Remove Reference To Deprecated Property mapred.output.compression.type -(Beluga Behr via gabor) - -AVRO-2055: Remove Magic Value From org.apache.avro.hadoop.io.AvroSequenceFile -(Beluga Behr via gabor) - -AVRO-1047: Remaining warnings in generated Java code exposed by -Xlint:all fixed. -(Michael Werle via Niels Basjes) - -AVRO-2080: Fix Javadoc Warnings in Generated Records -(Bridger Howell via Niels Basjes) - -AVRO-2114: Make missing value exceptions in nested structures easier to read. -(Niels Basjes) - -AVRO-2115: Java: Permit @Union annotations on fields of classes. -(Miguel Martinez-Espronceda via cutting). - -AVRO-2119: Run Apache Rat check on every java build (Niels Basjes) - -AVRO-2117: Overall cleanup of java code (Niels Basjes) - -AVRO-2109: Reset buffers in case of IOException (gabor) - -AVRO-2133: Log rat failures (gabor) - -AVRO-2113: Improve unexpected type error message (thiru) - - BUG FIXES - -AVRO-1741: Python3: Fix error when codec is not in the header. -(Matthew Hayes via blue) - -AVRO-1869: Java: Fix Decimal conversion from ByteBuffer. (blue) - -AVRO-607: Java: Make SpecificData schema cache thread-safe. -(Andrius Druzinis-Vitkus via blue) - -AVRO-1888: Java: Fix single-record encoding marker check. (blue) - -AVRO-1848:
[jira] [Commented] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527512#comment-16527512 ] ASF subversion and git services commented on AVRO-2173: --- Commit 5f885281acb5a4c3e6bae402761036828c6736d4 in avro's branch refs/heads/master from [~nielsbasjes] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=5f88528 ] Merge pull request #310 from nandorKollar/AVRO-2173 AVRO-2173: remove CHANGES.txt > remove CHANGES.txt > -- > > Key: AVRO-2173 > URL: https://issues.apache.org/jira/browse/AVRO-2173 > Project: Avro > Issue Type: Improvement >Reporter: Doug Cutting >Priority: Major > > The CHANGES.txt file is not well maintained and redundant with information in > Jira. > Let's remove this file, and instead generate release notes from Jira. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527511#comment-16527511 ] ASF subversion and git services commented on AVRO-2173: --- Commit 5f885281acb5a4c3e6bae402761036828c6736d4 in avro's branch refs/heads/master from [~nielsbasjes] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=5f88528 ] Merge pull request #310 from nandorKollar/AVRO-2173 AVRO-2173: remove CHANGES.txt > remove CHANGES.txt > -- > > Key: AVRO-2173 > URL: https://issues.apache.org/jira/browse/AVRO-2173 > Project: Avro > Issue Type: Improvement >Reporter: Doug Cutting >Priority: Major > > The CHANGES.txt file is not well maintained and redundant with information in > Jira. > Let's remove this file, and instead generate release notes from Jira. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527510#comment-16527510 ] ASF subversion and git services commented on AVRO-2173: --- Commit 18164dc87649265c85f1dca76efd4ac5d16424dc in avro's branch refs/heads/master from [~nkollar] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=18164dc ] AVRO-2173: remove CHANGES.txt > remove CHANGES.txt > -- > > Key: AVRO-2173 > URL: https://issues.apache.org/jira/browse/AVRO-2173 > Project: Avro > Issue Type: Improvement >Reporter: Doug Cutting >Priority: Major > > The CHANGES.txt file is not well maintained and redundant with information in > Jira. > Let's remove this file, and instead generate release notes from Jira. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527508#comment-16527508 ] Niels Basjes commented on AVRO-2173: [~nkollar] Perhaps fixing the 'wiki' can be put under the umbrella of AVRO-2175 ? > remove CHANGES.txt > -- > > Key: AVRO-2173 > URL: https://issues.apache.org/jira/browse/AVRO-2173 > Project: Avro > Issue Type: Improvement >Reporter: Doug Cutting >Priority: Major > > The CHANGES.txt file is not well maintained and redundant with information in > Jira. > Let's remove this file, and instead generate release notes from Jira. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2173) remove CHANGES.txt
[ https://issues.apache.org/jira/browse/AVRO-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527499#comment-16527499 ] ASF GitHub Bot commented on AVRO-2173: -- nielsbasjes commented on issue #310: AVRO-2173: remove CHANGES.txt URL: https://github.com/apache/avro/pull/310#issuecomment-401330133 +1 yes, let's get rid of it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove CHANGES.txt > -- > > Key: AVRO-2173 > URL: https://issues.apache.org/jira/browse/AVRO-2173 > Project: Avro > Issue Type: Improvement >Reporter: Doug Cutting >Priority: Major > > The CHANGES.txt file is not well maintained and redundant with information in > Jira. > Let's remove this file, and instead generate release notes from Jira. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2196) Build fails on a clean machine
[
https://issues.apache.org/jira/browse/AVRO-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527478#comment-16527478
]
ASF GitHub Bot commented on AVRO-2196:
--
nielsbasjes opened a new pull request #318: AVRO-2196: Fix build problem about
missing avro-mapred tests jar
URL: https://github.com/apache/avro/pull/318
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build fails on a clean machine
> --
>
> Key: AVRO-2196
> URL: https://issues.apache.org/jira/browse/AVRO-2196
> Project: Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.9.0
>Reporter: Niels Basjes
>Assignee: Niels Basjes
>Priority: Major
> Fix For: 1.9.0
>
>
> On a clean machine (i.e. empty ~/.m2/reporsitory) when I simply run mvn clean
> package the build fails with
> {code:java}
> {code:java}
> [INFO]
>
> [INFO] Building Apache Avro Tools 1.9.0-SNAPSHOT
> [INFO]
>
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Avro Toplevel .. SUCCESS [1.009s]
> [INFO] Apache Avro Java .. SUCCESS [0.930s]
> [INFO] Apache Avro Guava Dependencies SUCCESS [1.377s]
> [INFO] Apache Avro ... SUCCESS [1:02.460s]
> [INFO] Apache Avro Compiler .. SUCCESS [10.705s]
> [INFO] Apache Avro Maven Plugin .. SUCCESS [5.190s]
> [INFO] Apache Avro IPC ... SUCCESS [47.988s]
> [INFO] Trevni Java ... SUCCESS [0.089s]
> [INFO] Trevni Java Core .. SUCCESS [4.526s]
> [INFO] Apache Avro Mapred API SUCCESS [1:29.866s]
> [INFO] Trevni Java Avro .. SUCCESS [14.612s]
> [INFO] Trevni Specification .. SUCCESS [0.229s]
> [INFO] Apache Avro Tools . FAILURE [0.042s]
> [INFO] Apache Avro Protobuf Compatibility SKIPPED
> [INFO] Apache Avro Thrift Compatibility .. SKIPPED
> [INFO] Apache Avro Maven Archetypes .. SKIPPED
> [INFO] Apache Avro Maven Service Archetype ... SKIPPED
> [INFO] Apache Avro gRPC .. SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3:59.636s
> [INFO] Finished at: Fri Jun 29 09:14:04 UTC 2018
> [INFO] Final Memory: 80M/1309M
> [INFO]
>
> [ERROR] Failed to execute goal on project avro-tools: Could not resolve
> dependencies for project org.apache.avro:avro-tools:jar:1.9.0-SNAPSHOT: Could
> not find artifact org.apache.avro:avro-mapred:jar:tests:1.9.0-SNAPSHOT ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :avro-tools
> {code}
>
> Apparently the
> {code:java}
> org.apache.avro:avro-mapred:jar:tests:1.9.0-SNAPSHOT{code}
> is not created (but seems needed).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AVRO-2196) Build fails on a clean machine
Niels Basjes created AVRO-2196:
--
Summary: Build fails on a clean machine
Key: AVRO-2196
URL: https://issues.apache.org/jira/browse/AVRO-2196
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.9.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 1.9.0
On a clean machine (i.e. empty ~/.m2/reporsitory) when I simply run mvn clean
package the build fails with
{code:java}
{code:java}
[INFO]
[INFO] Building Apache Avro Tools 1.9.0-SNAPSHOT
[INFO]
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Avro Toplevel .. SUCCESS [1.009s]
[INFO] Apache Avro Java .. SUCCESS [0.930s]
[INFO] Apache Avro Guava Dependencies SUCCESS [1.377s]
[INFO] Apache Avro ... SUCCESS [1:02.460s]
[INFO] Apache Avro Compiler .. SUCCESS [10.705s]
[INFO] Apache Avro Maven Plugin .. SUCCESS [5.190s]
[INFO] Apache Avro IPC ... SUCCESS [47.988s]
[INFO] Trevni Java ... SUCCESS [0.089s]
[INFO] Trevni Java Core .. SUCCESS [4.526s]
[INFO] Apache Avro Mapred API SUCCESS [1:29.866s]
[INFO] Trevni Java Avro .. SUCCESS [14.612s]
[INFO] Trevni Specification .. SUCCESS [0.229s]
[INFO] Apache Avro Tools . FAILURE [0.042s]
[INFO] Apache Avro Protobuf Compatibility SKIPPED
[INFO] Apache Avro Thrift Compatibility .. SKIPPED
[INFO] Apache Avro Maven Archetypes .. SKIPPED
[INFO] Apache Avro Maven Service Archetype ... SKIPPED
[INFO] Apache Avro gRPC .. SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3:59.636s
[INFO] Finished at: Fri Jun 29 09:14:04 UTC 2018
[INFO] Final Memory: 80M/1309M
[INFO]
[ERROR] Failed to execute goal on project avro-tools: Could not resolve
dependencies for project org.apache.avro:avro-tools:jar:1.9.0-SNAPSHOT: Could
not find artifact org.apache.avro:avro-mapred:jar:tests:1.9.0-SNAPSHOT -> [Help
1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :avro-tools
{code}
Apparently the
{code:java}
org.apache.avro:avro-mapred:jar:tests:1.9.0-SNAPSHOT{code}
is not created (but seems needed).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-1891) Generated Java code fails with union containing logical type
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527372#comment-16527372
]
Sangram commented on AVRO-1891:
---
Hi [~rdblue],
Do we have an estimate on when this JIRA is going to be merged?
> Generated Java code fails with union containing logical type
>
>
> Key: AVRO-1891
> URL: https://issues.apache.org/jira/browse/AVRO-1891
> Project: Avro
> Issue Type: Bug
> Components: java, logical types
>Affects Versions: 1.8.1
>Reporter: Ross Black
>Priority: Blocker
> Fix For: 1.8.3
>
> Attachments: AVRO-1891.patch, AVRO-1891.yshi.1.patch,
> AVRO-1891.yshi.2.patch, AVRO-1891.yshi.3.patch, AVRO-1891.yshi.4.patch
>
>
> Example schema:
> {code}
> {
> "type": "record",
> "name": "RecordV1",
> "namespace": "org.brasslock.event",
> "fields": [
> { "name": "first", "type": ["null", {"type": "long",
> "logicalType":"timestamp-millis"}]}
> ]
> }
> {code}
> The avro compiler generates a field using the relevant joda class:
> {code}
> public org.joda.time.DateTime first
> {code}
> Running the following code to perform encoding:
> {code}
> final RecordV1 record = new
> RecordV1(DateTime.parse("2016-07-29T10:15:30.00Z"));
> final DatumWriter datumWriter = new
> SpecificDatumWriter<>(record.getSchema());
> final ByteArrayOutputStream stream = new ByteArrayOutputStream(8192);
> final BinaryEncoder encoder =
> EncoderFactory.get().directBinaryEncoder(stream, null);
> datumWriter.write(record, encoder);
> encoder.flush();
> final byte[] bytes = stream.toByteArray();
> {code}
> fails with the exception stacktrace:
> {code}
> org.apache.avro.AvroRuntimeException: Unknown datum type
> org.joda.time.DateTime: 2016-07-29T10:15:30.000Z
> at org.apache.avro.generic.GenericData.getSchemaName(GenericData.java:741)
> at
> org.apache.avro.specific.SpecificData.getSchemaName(SpecificData.java:293)
> at org.apache.avro.generic.GenericData.resolveUnion(GenericData.java:706)
> at
> org.apache.avro.generic.GenericDatumWriter.resolveUnion(GenericDatumWriter.java:192)
> at
> org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:110)
> at
> org.apache.avro.specific.SpecificDatumWriter.writeField(SpecificDatumWriter.java:87)
> at
> org.apache.avro.generic.GenericDatumWriter.writeRecord(GenericDatumWriter.java:143)
> at
> org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:105)
> at
> org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:73)
> at
> org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:60)
> at
> org.brasslock.avro.compiler.GeneratedRecordTest.shouldEncodeLogicalTypeInUnion(GeneratedRecordTest.java:82)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:117)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
> at
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:253)
> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:84)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
>
[jira] [Commented] (AVRO-1927) If a default value is set, Avro allows null values in non-nullable fields.
[
https://issues.apache.org/jira/browse/AVRO-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527320#comment-16527320
]
Mykola Polonskyi commented on AVRO-1927:
hello (bump message)
*same behavior from builder on 1.8.2 and same error onto serialization call*
can any one share reference for spec that explain this behavior if its valid?
or clarify status
tnx
> If a default value is set, Avro allows null values in non-nullable fields.
> --
>
> Key: AVRO-1927
> URL: https://issues.apache.org/jira/browse/AVRO-1927
> Project: Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.8.1
>Reporter: Andreas Maier
>Priority: Major
>
> With an avro schema like
> {code}
> {
> "name": "myfield",
> "type": "string",
> "default": ""
> }
> {code}
> the following code should throw an exception
> {code}
> MyObject myObject = MyObject.newBuilder().setMyfield(null).build();
> {code}
> But instead the value of myfield is set to null, which causes an exception
> later when serializing myObject, because null is not a valid value for
> myfield.
> I believe in this case setMyfield(null) should throw an exception,
> independent of the value of default.
> See also
> https://stackoverflow.com/questions/38509279/generated-avro-builder-set-null-doesnt-overwrite-with-default
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2195) Add Zstandard Codec
[
https://issues.apache.org/jira/browse/AVRO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527317#comment-16527317
]
Benson Qiu commented on AVRO-2195:
--
Initial Patch (AVRO-2195.patch):
* Code is based on AVRO-1373
* Existing tests pass. However, I did not write new unit tests yet.
* I did a manual test by creating a quick Java application that writes Avro
files using zstandard compression:
{code:java}
// ...
dataFileWriter.setCodec(CodecFactory.zstandardCodec());
// ...
while (dataFileReader.hasNext()) {
record = dataFileReader.next();
dataFileWriter.append(record);
}
// ...
{code}
In my manual test, I observed that my Java application needs a dependency on
`ztd-jni`. Without that dependency, we get a `ClassNotFoundException` for
`com.github.luben.zstd.ZstdOutputStream`.
{code:java}
com.github.luben
zstd-jni
1.3.4-10
{code}
> Add Zstandard Codec
> ---
>
> Key: AVRO-2195
> URL: https://issues.apache.org/jira/browse/AVRO-2195
> Project: Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.9.0
>Reporter: Benson Qiu
>Priority: Major
> Labels: patch
> Attachments: AVRO-2195.patch
>
>
> Inspired by AVRO-1373. The Zstandard algorithm is available in the
> commons-library, which Avro projects already depend on.
> In a quick test that I did, Zstandard had a better compression ratio than
> deflate (compression level 9), with significantly faster compression times.
> [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AVRO-2195) Add Zstandard Codec
[ https://issues.apache.org/jira/browse/AVRO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benson Qiu updated AVRO-2195: - Description: Inspired by AVRO-1373. The Zstandard algorithm is available in the commons-library, which Avro projects already depend on. In a quick test that I did, Zstandard had a better compression ratio than deflate (compression level 9). [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] was: Inspired by AVRO-1373. The Zstandard algorithm is available in the commons-library, which Avro projects already depend on. In a quick test that I did, Zstandard had a better compression ratio than deflate (compression level 9), with significantly faster compression times. [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] > Add Zstandard Codec > --- > > Key: AVRO-2195 > URL: https://issues.apache.org/jira/browse/AVRO-2195 > Project: Avro > Issue Type: Bug > Components: java >Affects Versions: 1.9.0 >Reporter: Benson Qiu >Priority: Major > Labels: patch > Attachments: AVRO-2195.patch > > > Inspired by AVRO-1373. The Zstandard algorithm is available in the > commons-library, which Avro projects already depend on. > In a quick test that I did, Zstandard had a better compression ratio than > deflate (compression level 9). > [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2195) Add Zstandard Codec
[ https://issues.apache.org/jira/browse/AVRO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benson Qiu updated AVRO-2195: - Attachment: (was: AVRO-2195.patch) > Add Zstandard Codec > --- > > Key: AVRO-2195 > URL: https://issues.apache.org/jira/browse/AVRO-2195 > Project: Avro > Issue Type: Bug > Components: java >Affects Versions: 1.9.0 >Reporter: Benson Qiu >Priority: Major > Labels: patch > Attachments: AVRO-2195.patch > > > Inspired by AVRO-1373. The Zstandard algorithm is available in the > commons-library, which Avro projects already depend on. > > In a quick test that I did, Zstandard had a better compression ratio than > deflate (compression level 9), with significantly faster compression times. > > [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2195) Add Zstandard Codec
[ https://issues.apache.org/jira/browse/AVRO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benson Qiu updated AVRO-2195: - Attachment: AVRO-2195.patch > Add Zstandard Codec > --- > > Key: AVRO-2195 > URL: https://issues.apache.org/jira/browse/AVRO-2195 > Project: Avro > Issue Type: Bug > Components: java >Affects Versions: 1.9.0 >Reporter: Benson Qiu >Priority: Major > Labels: patch > Attachments: AVRO-2195.patch > > > Inspired by AVRO-1373. The Zstandard algorithm is available in the > commons-library, which Avro projects already depend on. > > In a quick test that I did, Zstandard had a better compression ratio than > deflate (compression level 9), with significantly faster compression times. > > [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2195) Add Zstandard Codec
[ https://issues.apache.org/jira/browse/AVRO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benson Qiu updated AVRO-2195: - Attachment: AVRO-2195.patch Status: Patch Available (was: Open) > Add Zstandard Codec > --- > > Key: AVRO-2195 > URL: https://issues.apache.org/jira/browse/AVRO-2195 > Project: Avro > Issue Type: Bug > Components: java >Affects Versions: 1.9.0 >Reporter: Benson Qiu >Priority: Major > Labels: patch > Attachments: AVRO-2195.patch > > > Inspired by AVRO-1373. The Zstandard algorithm is available in the > commons-library, which Avro projects already depend on. > > In a quick test that I did, Zstandard had a better compression ratio than > deflate (compression level 9), with significantly faster compression times. > > [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2195) Add Zstandard Codec
[ https://issues.apache.org/jira/browse/AVRO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benson Qiu updated AVRO-2195: - Description: Inspired by AVRO-1373. The Zstandard algorithm is available in the commons-library, which Avro projects already depend on. In a quick test that I did, Zstandard had a better compression ratio than deflate (compression level 9), with significantly faster compression times. [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] was: Inspired by AVRO-1373. The Zstandard algorithm is available in the commons-library, which Avro projects already depend on. In a quick test that I did, Zstandard had a better compression ratio than deflate (compression level 9), with significantly faster compression times. [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] > Add Zstandard Codec > --- > > Key: AVRO-2195 > URL: https://issues.apache.org/jira/browse/AVRO-2195 > Project: Avro > Issue Type: Bug > Components: java >Affects Versions: 1.9.0 >Reporter: Benson Qiu >Priority: Major > Labels: patch > Attachments: AVRO-2195.patch > > > Inspired by AVRO-1373. The Zstandard algorithm is available in the > commons-library, which Avro projects already depend on. > In a quick test that I did, Zstandard had a better compression ratio than > deflate (compression level 9), with significantly faster compression times. > [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AVRO-2195) Add Zstandard Codec
Benson Qiu created AVRO-2195: Summary: Add Zstandard Codec Key: AVRO-2195 URL: https://issues.apache.org/jira/browse/AVRO-2195 Project: Avro Issue Type: Bug Components: java Affects Versions: 1.9.0 Reporter: Benson Qiu Inspired by AVRO-1373. The Zstandard algorithm is available in the commons-library, which Avro projects already depend on. In a quick test that I did, Zstandard had a better compression ratio than deflate (compression level 9), with significantly faster compression times. [https://code.fb.com/core-data/smaller-and-faster-data-compression-with-zstandard/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
