[jira] [Commented] (AVRO-2297) Ruby build fails in docker container
[ https://issues.apache.org/jira/browse/AVRO-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736384#comment-16736384 ] Fokko Driesprong commented on AVRO-2297: Yes, thanks [~tjwp] > Ruby build fails in docker container > > > Key: AVRO-2297 > URL: https://issues.apache.org/jira/browse/AVRO-2297 > Project: Apache Avro > Issue Type: Improvement > Components: ruby >Reporter: Thiruvalluvan M. G. >Assignee: Tim Perkins >Priority: Major > > It appears that the latest release of Ruby bundler on Jan 4, 2019 breaks our > build. We are installing the bundler without version constraints and hence it > installs the latest version of bundler, which in turn requires ruby 2.3.0. > Can someone familiar with our Ruby binding take care of this. Until it is > fixed, we'll disable ruby build in docker. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (AVRO-2297) Ruby build fails in docker container
[ https://issues.apache.org/jira/browse/AVRO-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AVRO-2297. Resolution: Fixed Fix Version/s: 1.9.0 > Ruby build fails in docker container > > > Key: AVRO-2297 > URL: https://issues.apache.org/jira/browse/AVRO-2297 > Project: Apache Avro > Issue Type: Improvement > Components: ruby >Reporter: Thiruvalluvan M. G. >Assignee: Tim Perkins >Priority: Major > Fix For: 1.9.0 > > > It appears that the latest release of Ruby bundler on Jan 4, 2019 breaks our > build. We are installing the bundler without version constraints and hence it > installs the latest version of bundler, which in turn requires ruby 2.3.0. > Can someone familiar with our Ruby binding take care of this. Until it is > fixed, we'll disable ruby build in docker. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736362#comment-16736362 ] Felix GV commented on AVRO-1340: It is great to see this issue resolved! Avro 1.9.0 is not released yet, right? Is there any documentation on how to use this feature? (i.e.: schema design, expected semantics, etc.) I have tried the following but the page is not there yet: [https://avro.apache.org/docs/1.9.0/spec.html] Thanks! -F > use default to allow old readers to specify default enum value when > encountering new enum symbols > - > > Key: AVRO-1340 > URL: https://issues.apache.org/jira/browse/AVRO-1340 > Project: Apache Avro > Issue Type: Improvement > Components: spec > Environment: N/A >Reporter: Jim Donofrio >Assignee: Adam Bellemare >Priority: Minor > Fix For: 1.9.0 > > > The schema resolution page says: > > if both are enums: > > if the writer's symbol is not present in the reader's enum, then an > error is signalled. > This makes it difficult to use enum's because you can never add a enum value > and keep old reader's compatible. Why not use the default option to refer to > one of enum values so that when a old reader encounters a enum ordinal it > does not recognize, it can default to the optional schema provided one. If > the old schema does not provide a default then the older reader can continue > to fail as it does today. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2297) Ruby build fails in docker container
[ https://issues.apache.org/jira/browse/AVRO-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736257#comment-16736257 ] Tim Perkins commented on AVRO-2297: --- Should this be resolved now that a fix has been merged? > Ruby build fails in docker container > > > Key: AVRO-2297 > URL: https://issues.apache.org/jira/browse/AVRO-2297 > Project: Apache Avro > Issue Type: Improvement > Components: ruby >Reporter: Thiruvalluvan M. G. >Assignee: Tim Perkins >Priority: Major > > It appears that the latest release of Ruby bundler on Jan 4, 2019 breaks our > build. We are installing the bundler without version constraints and hence it > installs the latest version of bundler, which in turn requires ruby 2.3.0. > Can someone familiar with our Ruby binding take care of this. Until it is > fixed, we'll disable ruby build in docker. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (AVRO-2295) Move C++ to std from boost wherever possible
[
https://issues.apache.org/jira/browse/AVRO-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. reassigned AVRO-2295:
-
Assignee: Thiruvalluvan M. G.
> Move C++ to std from boost wherever possible
>
>
> Key: AVRO-2295
> URL: https://issues.apache.org/jira/browse/AVRO-2295
> Project: Apache Avro
> Issue Type: Improvement
> Components: c++
>Reporter: Thiruvalluvan M. G.
>Assignee: Thiruvalluvan M. G.
>Priority: Major
>
> Now that we have mandated C++11 as a requirement for 1.9.0 onwards, the
> following boost features can be moved to \{{std::}}:
> * array
> * scoped_ptr (in favor of unique_ptr)
> * shared_ptr
> * static_assert
> * type_traits
> * weak_ptr
> * noncopyable (in favor of {{= delete}} for copy constructors)
> * ptr_container (in favor of container of unique_ptr)
> With that the only boost features still in use will be:
> * any
> * blank
> * format
> * iostreams
> * regex
> * program_options
> Of these any is part of \{{C++ }}17 and hence when \{{C++ }}17 is used we can
> use {{std::}} for that too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2297) Ruby build fails in docker container
[ https://issues.apache.org/jira/browse/AVRO-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736045#comment-16736045 ] ASF subversion and git services commented on AVRO-2297: --- Commit 7740efa3ee8e3ddd01405c8f3af1937859f6bd1a in avro's branch refs/heads/master from Tim Perkins [ https://gitbox.apache.org/repos/asf?p=avro.git;h=7740efa ] Revert "Merge pull request #422 from thiru-apache/AVRO-2297" This reverts commit efd6274a4c7a9ed7c1c0d41477649b68baeefa0b, reversing changes made to 0c223c9da6d0286c9e16257cef8b9988099cf8a2. > Ruby build fails in docker container > > > Key: AVRO-2297 > URL: https://issues.apache.org/jira/browse/AVRO-2297 > Project: Apache Avro > Issue Type: Improvement > Components: ruby >Reporter: Thiruvalluvan M. G. >Assignee: Tim Perkins >Priority: Major > > It appears that the latest release of Ruby bundler on Jan 4, 2019 breaks our > build. We are installing the bundler without version constraints and hence it > installs the latest version of bundler, which in turn requires ruby 2.3.0. > Can someone familiar with our Ruby binding take care of this. Until it is > fixed, we'll disable ruby build in docker. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-1520) seek error when using compression and schema evolution
[ https://issues.apache.org/jira/browse/AVRO-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. updated AVRO-1520: -- Resolution: Fixed Status: Resolved (was: Patch Available) Merged the pull request. > seek error when using compression and schema evolution > -- > > Key: AVRO-1520 > URL: https://issues.apache.org/jira/browse/AVRO-1520 > Project: Apache Avro > Issue Type: Bug > Components: c++ >Affects Versions: 1.7.6, 1.7.7 > Environment: All >Reporter: Steve Roehrs >Assignee: Thiruvalluvan M. G. >Priority: Major > Labels: patch > Fix For: 1.9.0 > > Attachments: AVRO-1520.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > When using compression and schema evolution, FileStream sometimes attempts to > seek on a IStreamBuffer, which fails. This make compression unusable for our > application. A fix has been developed, patch will be included shortly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-1520) seek error when using compression and schema evolution
[ https://issues.apache.org/jira/browse/AVRO-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735867#comment-16735867 ] ASF subversion and git services commented on AVRO-1520: --- Commit a7e72b5b581605d70919b8d244414b879533bd8f in avro's branch refs/heads/master from Thiruvalluvan M. G. [ https://gitbox.apache.org/repos/asf?p=avro.git;h=a7e72b5 ] Merge pull request #424 from thiru-apache/AVRO-1520 New tests to catch skip problems with deflate compressor and the fix. > seek error when using compression and schema evolution > -- > > Key: AVRO-1520 > URL: https://issues.apache.org/jira/browse/AVRO-1520 > Project: Apache Avro > Issue Type: Bug > Components: c++ >Affects Versions: 1.7.6, 1.7.7 > Environment: All >Reporter: Steve Roehrs >Assignee: Thiruvalluvan M. G. >Priority: Major > Labels: patch > Fix For: 1.9.0 > > Attachments: AVRO-1520.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > When using compression and schema evolution, FileStream sometimes attempts to > seek on a IStreamBuffer, which fails. This make compression unusable for our > application. A fix has been developed, patch will be included shortly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AVRO-2298) Specific Avro compiler does not annotate generated Builder class with AvroGenerated
[
https://issues.apache.org/jira/browse/AVRO-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olli Salonen updated AVRO-2298:
---
Description:
According to current [AvroGenerated
documentation|https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/specific/AvroGenerated.html]
{quote}All Avro generated classes will be annotated with this annotation.
{quote}
However, the nested Builder class that the specific Avro compiler generates
does not get annotated with AvroGenerated or any user specified
javaAnnotations. The Builder template is missing annotation generation as can
be seen in the [template file on
Github|https://github.com/apache/avro/blob/7ed38d7c7e150987ef8bf035196576fc158e03eb/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm#L296]
This has implications for tools relying on Generated annotations, such as test
coverage tools like JaCoCo, which can ignore the generated SpecificRecord class
but not the nested SpecificBuilder class as a result. [Here is one JaCoCo bug
describing the issue|https://github.com/jacoco/jacoco/issues/814].
was:
According to current [AvroGenerated
documentation|[https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/specific/AvroGenerated.html]]
{quote}All Avro generated classes will be annotated with this annotation.
{quote}
However, the nested Builder class that the specific Avro compiler generates
does not get annotated with AvroGenerated or any user specified
javaAnnotations. The Builder template is missing annotation generation as can
be seen in the [template file on
Github|[https://github.com/apache/avro/blob/7ed38d7c7e150987ef8bf035196576fc158e03eb/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm#L296]]
This has implications for tools relying on Generated annotations, such as test
coverage tools like JaCoCo, which can ignore the generated SpecificRecord class
but not the nested SpecificBuilder class as a result. [Here is one JaCoCo bug
describing the issue|https://github.com/jacoco/jacoco/issues/814].
> Specific Avro compiler does not annotate generated Builder class with
> AvroGenerated
> ---
>
> Key: AVRO-2298
> URL: https://issues.apache.org/jira/browse/AVRO-2298
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.8.2
>Reporter: Olli Salonen
>Priority: Major
>
> According to current [AvroGenerated
> documentation|https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/specific/AvroGenerated.html]
> {quote}All Avro generated classes will be annotated with this annotation.
> {quote}
> However, the nested Builder class that the specific Avro compiler generates
> does not get annotated with AvroGenerated or any user specified
> javaAnnotations. The Builder template is missing annotation generation as can
> be seen in the [template file on
> Github|https://github.com/apache/avro/blob/7ed38d7c7e150987ef8bf035196576fc158e03eb/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm#L296]
> This has implications for tools relying on Generated annotations, such as
> test coverage tools like JaCoCo, which can ignore the generated
> SpecificRecord class but not the nested SpecificBuilder class as a result.
> [Here is one JaCoCo bug describing the
> issue|https://github.com/jacoco/jacoco/issues/814].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AVRO-2298) Specific Avro compiler does not annotate generated Builder class with AvroGenerated
[
https://issues.apache.org/jira/browse/AVRO-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olli Salonen updated AVRO-2298:
---
Description:
According to current [AvroGenerated
documentation|[https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/specific/AvroGenerated.html]]
{quote}All Avro generated classes will be annotated with this annotation.
{quote}
However, the nested Builder class that the specific Avro compiler generates
does not get annotated with AvroGenerated or any user specified
javaAnnotations. The Builder template is missing annotation generation as can
be seen in the [template file on
Github|[https://github.com/apache/avro/blob/7ed38d7c7e150987ef8bf035196576fc158e03eb/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm#L296]]
This has implications for tools relying on Generated annotations, such as test
coverage tools like JaCoCo, which can ignore the generated SpecificRecord class
but not the nested SpecificBuilder class as a result. [Here is one JaCoCo bug
describing the issue|https://github.com/jacoco/jacoco/issues/814].
was:
According to current [AvroGenerated
documentation|[https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/specific/AvroGenerated.html],]
{quote}All Avro generated classes will be annotated with this annotation.
{quote}
However, the nested Builder class that the specific Avro compiler generates
does not get annotated with AvroGenerated or any user specified
javaAnnotations. The Builder template is missing annotation generation as can
be seen in the [template file on
Github|[https://github.com/apache/avro/blob/7ed38d7c7e150987ef8bf035196576fc158e03eb/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm#L296].]
This has implications for tools relying on Generated annotations, such as test
coverage tools like JaCoCo, which can ignore the generated SpecificRecord class
but not the nested SpecificBuilder class as a result. [Here is one JaCoCo bug
describing the issue|https://github.com/jacoco/jacoco/issues/814].
> Specific Avro compiler does not annotate generated Builder class with
> AvroGenerated
> ---
>
> Key: AVRO-2298
> URL: https://issues.apache.org/jira/browse/AVRO-2298
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Affects Versions: 1.8.2
>Reporter: Olli Salonen
>Priority: Major
>
> According to current [AvroGenerated
> documentation|[https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/specific/AvroGenerated.html]]
> {quote}All Avro generated classes will be annotated with this annotation.
> {quote}
> However, the nested Builder class that the specific Avro compiler generates
> does not get annotated with AvroGenerated or any user specified
> javaAnnotations. The Builder template is missing annotation generation as can
> be seen in the [template file on
> Github|[https://github.com/apache/avro/blob/7ed38d7c7e150987ef8bf035196576fc158e03eb/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm#L296]]
> This has implications for tools relying on Generated annotations, such as
> test coverage tools like JaCoCo, which can ignore the generated
> SpecificRecord class but not the nested SpecificBuilder class as a result.
> [Here is one JaCoCo bug describing the
> issue|https://github.com/jacoco/jacoco/issues/814].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AVRO-2298) Specific Avro compiler does not annotate generated Builder class with AvroGenerated
Olli Salonen created AVRO-2298:
--
Summary: Specific Avro compiler does not annotate generated
Builder class with AvroGenerated
Key: AVRO-2298
URL: https://issues.apache.org/jira/browse/AVRO-2298
Project: Apache Avro
Issue Type: Bug
Components: java
Affects Versions: 1.8.2
Reporter: Olli Salonen
According to current [AvroGenerated
documentation|[https://avro.apache.org/docs/1.8.2/api/java/org/apache/avro/specific/AvroGenerated.html],]
{quote}All Avro generated classes will be annotated with this annotation.
{quote}
However, the nested Builder class that the specific Avro compiler generates
does not get annotated with AvroGenerated or any user specified
javaAnnotations. The Builder template is missing annotation generation as can
be seen in the [template file on
Github|[https://github.com/apache/avro/blob/7ed38d7c7e150987ef8bf035196576fc158e03eb/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm#L296].]
This has implications for tools relying on Generated annotations, such as test
coverage tools like JaCoCo, which can ignore the generated SpecificRecord class
but not the nested SpecificBuilder class as a result. [Here is one JaCoCo bug
describing the issue|https://github.com/jacoco/jacoco/issues/814].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Java snapshot builds of 1.9.0 ?
Hello, Are there recent (-SNAPSHOT) builds of Avro 1.9.x ? At https://repository.apache.org/content/repositories/snapshots/org/apache/avro/avro/1.9.0-SNAPSHOT/ I see some from 2016/2017 Thanks! Regards, Martin
